From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3D8FA04B5 for ; Thu, 1 Oct 2020 10:41:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAE7F1D961; Thu, 1 Oct 2020 10:41:41 +0200 (CEST) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id CEFA11D961; Thu, 1 Oct 2020 10:41:38 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 01 Oct 2020 01:39:54 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 1 Oct 2020 08:41:36 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 1 Oct 2020 08:41:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/MF3LvnKHTdRLwvpJK6dHlo/eowwT/3aPJwgqbQ/RuMtdIH3/BJTPxSCQLeMo9gGtcVBxiUC9l6NMB8mIrLhzRKR5O6f9VhDUIDGKbytom4Ihr10PzqtDXVYY4vpHysiq8VcqGu1kr6tNvXAzJre0OnbO2yl3+je7YGkbvK2195JMN+qL7CT1zppQqIk09PjDNdzTwBawQ3SIr4Dtt7hzOID7k3avOL12Aq3XcQxKzYKBPVExQt7aL7Vw86YUZPSif1px+3U8hcEp5sIOuSTTlnZTcjf6CY62YpRv/clAS8O/K6wQMQSXWLrCTDKBwLIifG6a4Vrr45cIvEGNgtnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NTfmz/L76gNfFPLBRckC8FUr2lTighO8B7us6tDvVM0=; b=Qn/2ivn9oRzB/1PN/y8PVtUWdZZKjXu5Mk2bOenTlg3fPbFhraNCQw1C6ETHqUfeV348oFVW43q+A9rlijPOKnfm8CE+BPwIr4NcI3ret4ZAXbLzQsd/MKPoUjkLvItgu9Tu/RS1dwAeWJZxWQnaNndPpo+oj8ldyJYHNs5nQLxdp56/qe8KoqITGJiBOMy1Dx580u7wTd8/YzvCEQH0TAoFp/TUEcwiQcDB/u1pvgXmqHh1Wqwag0aYcx6RfzX+wjfzB+4A20KIqAyZQQ6Th9ZJnAXCsGxoALcflEHGEja3eEcAAWXP3YMYg2ZoY4pXIMbrKCmtn82dW1tRLJPnOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB2376.namprd12.prod.outlook.com (2603:10b6:4:b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Thu, 1 Oct 2020 08:41:35 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3412.029; Thu, 1 Oct 2020 08:41:35 +0000 From: Raslan Darawsheh To: Dekel Peled , Slava Ovsiienko , Shahaf Shuler , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix DevX CQ attributes values Thread-Index: AQHWlyQZorxDhmJWIk+oGBd+Ex4kyamCbvdw Date: Thu, 1 Oct 2020 08:41:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0072bdfa-7934-48c3-f719-08d865e5ce20 x-ms-traffictypediagnostic: DM5PR12MB2376: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p25G9S+OUSI5/a4CHzJbyWtkfNAGHhNx/ZNrRzVgro87o8zhGsW35RTyyng9NtsxEpx/MMqKk+A+OP/3KMpIB/chu3vmd0gNv9vehZ/DB9r6Yy/AdBjNh8Zz608LWtMVSAVSdzhKS4JUZgwcyQZ+nosioOYJxDor6ombnmilAvvK8TPKX4U33zr2DE4eGhWXjqA5U+Bl3t6VgJlT6R/rWIZ2TwBC7vDtzT9S29fe9/QVVusBKQdpndvc6PDBNhFnoX96RrnSvAN9TOdqFNU2KRSh61otZjEZ+jBebP+dXgK6IjFvL+MW7foExctyz+vPhUQB0NOgNb3KIt554TF3oQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(39860400002)(346002)(366004)(8676002)(478600001)(4326008)(33656002)(450100002)(8936002)(66556008)(83380400001)(54906003)(6506007)(71200400001)(55016002)(53546011)(76116006)(9686003)(66476007)(66446008)(64756008)(66946007)(86362001)(26005)(52536014)(7696005)(6636002)(5660300002)(186003)(2906002)(110136005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: V0/Cdq0Uzcxfw7kF9OCAEvZR4a5t8npuE7lrmxZ/A35H5mkKET+mYHV+H+o/D89dyclRiQs/A27l8cizwnxmSWCAHDTYug2W1tq3DQod5Y0rR9Et4jzh/8xSu/0DqW7C8gP7hqepMy3ngDBOAVd2K8ZFiKabJmzaE6d6HKLKxPBstJmrtfDVUBkrd/4tmmZq7t4CGbY0+tItOKIq/4DoBD6nXikThXFqctQoa9mG5ycJ8CyuthdoKmoOKjoVMbwTuN9rjqgK2S4Mr3xzsLIt3b7oB+1Q7J0AfAVqMzhoaj4xJ7SzxQRVpzvPkgGCm4kfYWnFJ7W+FPJK00mkOu1HzdeOpKmxV1/lAUatrxOrzezCw+TnRcyccr0S1EyFRdXICShjo8S3QyOAlF5rLbiLrzBOBgPaUw7/+ajIrAW8bWxY16THsmYVq1d2GXvLb6bg0EJF1jKJ1V6/mNXP1fjYRM+yYxUfZnt4d1A1ewaYclwanqTbD0k5laWsF0FByxeVGFOEguy2zBferfC8/P+YOR42EpNpWaNZo73gBs/tBzg+Rq9DF2J/S/xGwhWElZeRqjPg4ALM3qqS1rQBp8qcQof/GLffcXG30z9dRkZazp8MbBinul9l5CH56RViKKLc5YtyrTDqnJGp3qG6p+vvLA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0072bdfa-7934-48c3-f719-08d865e5ce20 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2020 08:41:35.1848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QCU5LUtspKrra+I2xrpw9z2s0gsA0Cfr36FFCJBX0oe3VGq5MWd89fQx9yb5YV6nevtW9tOcP+VS8kMhC96ZLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2376 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601541594; bh=NTfmz/L76gNfFPLBRckC8FUr2lTighO8B7us6tDvVM0=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=MKcwPOwg+B23oiR+1h/T3r/30UelHcfsqvHBKWgy5xyO42akNSPLQo12+veorpz09 I85sJqcw1ovBdvKstOknpmjyCQEY0Hro96/49mLR6ilB/qwFUVpzMzzTwAbxdOyEBg NUdxDCoooOkcr/+15uF4IwXf7EGXZ7Al8jZMlzNwH7NOemTephA7GvDhPjJvlRfoqt iTh8lpSOSpHm8WeZz9QM8gr+Kpa4VyME+pW16qGLiFruXuculeNHSe3qOdiZqLfqQV MzjmlyfjBuUJ4OFepvPQ3PLoTRoykTRH4fd+ZjvKqxWV3azR1hgjxhFWBryT+2x0Fh liQUQdi6BR9PQ== Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix DevX CQ attributes values X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, September 30, 2020 3:20 PM > To: Slava Ovsiienko ; Shahaf Shuler > ; Matan Azrad > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix DevX CQ attributes values >=20 > Previous patch wrongly used rdma-core defined values, when preparing > attributes for creating DevX CQ object. > This patch adds the correct value definition and uses them instead. >=20 > Fixes: 08d1838f645a ("net/mlx5: implement CQ for Rx using DevX API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_prm.h | 8 ++++++++ > drivers/net/mlx5/mlx5_devx.c | 14 ++++---------- > 2 files changed, 12 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_prm.h > b/drivers/common/mlx5/mlx5_prm.h > index 563e7c8..20f2fcc 100644 > --- a/drivers/common/mlx5/mlx5_prm.h > +++ b/drivers/common/mlx5/mlx5_prm.h > @@ -2835,6 +2835,14 @@ struct mlx5_mini_cqe8 { > uint32_t byte_cnt; > }; >=20 > +/* Mini CQE responder format. */ > +enum { > + MLX5_CQE_RESP_FORMAT_HASH =3D 0x0, > + MLX5_CQE_RESP_FORMAT_CSUM =3D 0x1, > + MLX5_CQE_RESP_FORMAT_CSUM_FLOW_TAG =3D 0x2, > + MLX5_CQE_RESP_FORMAT_CSUM_STRIDX =3D 0x3, > +}; > + > /* srTCM PRM flow meter parameters. */ > enum { > MLX5_FLOW_COLOR_RED =3D 0, > diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c > index 3e81fcc..cb4a522 100644 > --- a/drivers/net/mlx5/mlx5_devx.c > +++ b/drivers/net/mlx5/mlx5_devx.c > @@ -367,15 +367,11 @@ > } > if (priv->config.cqe_comp && !rxq_data->hw_timestamp && > !rxq_data->lro) { > - cq_attr.cqe_comp_en =3D > MLX5DV_CQ_INIT_ATTR_MASK_COMPRESSED_CQE; > -#ifdef HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT > + cq_attr.cqe_comp_en =3D 1u; > cq_attr.mini_cqe_res_format =3D > mlx5_rxq_mprq_enabled(rxq_data) ? > - MLX5DV_CQE_RES_FORMAT_CSUM_STRIDX > : > - MLX5DV_CQE_RES_FORMAT_HASH; > -#else > - cq_attr.mini_cqe_res_format =3D > MLX5DV_CQE_RES_FORMAT_HASH; > -#endif > + > MLX5_CQE_RESP_FORMAT_CSUM_STRIDX : > + MLX5_CQE_RESP_FORMAT_HASH; > /* > * For vectorized Rx, it must not be doubled in order to > * make cq_ci and rq_ci aligned. > @@ -392,10 +388,8 @@ > "Port %u Rx CQE compression is disabled for LRO.", > dev->data->port_id); > } > -#ifdef HAVE_IBV_MLX5_MOD_CQE_128B_PAD > if (priv->config.cqe_pad) > - cq_attr.cqe_size =3D > MLX5DV_CQ_INIT_ATTR_FLAGS_CQE_PAD; > -#endif > + cq_attr.cqe_size =3D MLX5_CQE_SIZE_128B; > log_cqe_n =3D log2above(cqe_n); > cq_size =3D sizeof(struct mlx5_cqe) * (1 << log_cqe_n); > /* Query the EQN for this core. */ > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh