From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 382C1A04C7 for ; Tue, 15 Sep 2020 10:14:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07DF91C000; Tue, 15 Sep 2020 10:14:17 +0200 (CEST) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 8CD53DE0; Tue, 15 Sep 2020 10:14:13 +0200 (CEST) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 15 Sep 2020 01:13:25 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 15 Sep 2020 01:14:12 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 15 Sep 2020 01:14:12 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 15 Sep 2020 08:14:12 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.54) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 15 Sep 2020 08:14:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kRAfcaE4ATq6QYkwEhsgC/57MZEbunbbjOHMhbNjWW72MUw+XwT7CIhyDMZPHGMWR2HTjvF8YQRgJit1VgOCcahRQCmdXzCwgr+SCIZow+A2z4Mt4z/Vbj09ULenpJeXatNkvuTUa9C/lCBNdCbzipaJXT+TIv5YZFT9Q+ceW9r+Er5BJUUFnu9M6+i1gBFhwMG9WPNlB1aQBi1IWdhG4zZG0K+u5RBmpN8FK4PRsJtSAy7lmcMhuI3povYWEQM3icKN6pG7VndWgX/Gu7GNwoNRdsvz4pMhOLwxo6ihBzjNrsZzCxHFrEfbX7NxBdscOWny4HRDKsklJZ+9YpKL0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BbLqN05fLYJGfRgA3NuKOIgDGU4GfD99SmzoM0nuAsc=; b=W4ANzImi/Ht6i8ekwfDwez8siNBgGHqJblsZwrJJXgEGa6OvnZKNktG7tkTsBYPmXDFBpuiheOenyQH7eiWvDYMZHPQNsDLjUkJHMw9wT7jt3rZapATaqHltgRu45Z4pC31b/0eH+HUOnOeuigTLK/lQi5qaRZK5yr4ckF+PsskYG34EVCq3NvDTczjsGYlEYFoKYrDyfYv9C6Ku5af69KS9Y4k1xoLIJUzmqPI96wRx8L+QHnBNMGElLSg5+uKwgqAX9OmrCiXn1Mk595W4WXCWlFIWPjFsJ/CSK/EEf4VNX3l8XYVCrvNA+zuYXvzJQLAVIXueLGV4nLazwxfFRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB2376.namprd12.prod.outlook.com (2603:10b6:4:b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Tue, 15 Sep 2020 08:14:10 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3370.019; Tue, 15 Sep 2020 08:14:10 +0000 From: Raslan Darawsheh To: Maxime Leroy , "dev@dpdk.org" CC: "stable@dpdk.org" , Raslan Darawsheh Thread-Topic: [PATCH] net/mlx5: fix rss reta is reset when device is started Thread-Index: AQHWafW04zoLVOo0pEinhunispKyoalpnFoQ Date: Tue, 15 Sep 2020 08:14:10 +0000 Message-ID: References: <20200716104320.10582-1-maxime.leroy@6wind.com> In-Reply-To: <20200716104320.10582-1-maxime.leroy@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2956409-e67a-46a7-2de3-08d8594f5337 x-ms-traffictypediagnostic: DM5PR12MB2376: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:519; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Pww0oNE1BMn0WR34zHC4vk2flTdNruVYSsRxNaY0phtfRqp5SvKaELApfNrV1n/o0GUYATATk1XQV/8Zln5GzG3LfuBo+Sjy1GAwfmaZDcpZgiB8MuBpQeBARfoWGBC9Of7Gve/IFt4+IfbBu5HY/J9ADfvClYIDddPEWCZ41PloziSc0yfWHV2o8C05nxV5trn5Kl5QKovYwdhA/HgbhJxuNyE6KOvvOejcoLPIA/WdNaWo3y1dkp5dwW+h05TZbebm9Ap/ehJWQxi8v5y2B4KG5pvKXkzEDlIpFKMOuoz9jNtBhnldAnPdY381LfEq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(346002)(396003)(366004)(66476007)(33656002)(66446008)(64756008)(66556008)(7696005)(110136005)(54906003)(52536014)(316002)(86362001)(66946007)(76116006)(55016002)(9686003)(6506007)(5660300002)(53546011)(71200400001)(26005)(4326008)(478600001)(186003)(8676002)(2906002)(83380400001)(107886003)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: MZW+hN3SoNHyJ87KZfD8fuZvjPHkncS0H98zC3BLhwdJ4o284PvHSLLJHAReRTmdGzBq+WQ1Ym1KzKpi3odcCZr0EWizYEA4rL8I6hSjRld6A6wpk+4Muti+6MCw7MXU7/C2zF8KbNUoZuz7BhNSKsHLLE9QBtJdkWdUcEf3CNojoJq6O/nrWQQUTUOSJAk1Pdk6Lz6ELHQcwKq+DNx3PhRlIWURhCdFR5SK7dsZ33ORbu0Jq66lhJNMvbsy7+qiHFUlqIpnhp7MoPTkJ8o3wLEV4+Qje8CusJdC4GQUE+9NEOaKxuvXEYPa1P2mjTr5pBgQE7zPp/W93wz3u8BZG92ErN3Bj1ZMObfX5u9g8MJ2qe+LyejY5EuxbKwukOcn+VQlW7gVK6tHTiFVL/b/AmZZQ35l+VEeQjy+Am+IJEmv+B553IstHzHHSO+G2/LRsDgPR+NY0hU1jNiCgS2N39bzxNqRXkLmPeNb2sLU09/vphgP5KidrovAWrsdMJq61rxOAr1qske8qRKTL3hQQsCBjvUMLgDJokNTYHuMPzHz2GuguE58u+UJ99Ks1RM5JAYfawuXvY5WLhxLET7MVu07IKuGYsMx1Ror27Ms+BPtf14HusSQPsXFSFsPF2s0A9LO4kbLOYflUe7tMCdA/w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2956409-e67a-46a7-2de3-08d8594f5337 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 08:14:10.4949 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nxcCVbEOeq8ABYCaDaBux9qudjyXZCB0yoTHcv/srqAevnaQLxo02ndj8EE2hxE1CZ1pYY5WEwp9vAJhHUbEWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2376 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600157605; bh=BbLqN05fLYJGfRgA3NuKOIgDGU4GfD99SmzoM0nuAsc=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-exchange-transport-forked:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=HdLgGfr6PaigrD2Y27MqRFPRSoR+iD+JJ7BjlwOjX/xSLhoDyYWCDzSTWm2TsY9R7 1t5wObDrMmhX0z7WFt+Hy9HVkA7K3USY3gTSFS46sviXCjf4cYEM+h+ha94pz+4y3h M5D186zY+6MjlV/YCXUE+F/U9MwXcoXMe0LlHFizfFCtpcTFsmUGX/ri4rj9QsPSlL vAf7th/wt0bVzry31ZvTeapAEHenLftazyv741ECaXVvqdu7e8ifmJsPrg1ptJjtHk 3OztmwcJzyrRaQ82Kb0uZeqqadim/v5v5gJq/gcbaQqEZMLizUdw91pLAyLSgo80DF aCyf/e7hQ3KNw== Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix rss reta is reset when device is started X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Maxime Leroy > Sent: Thursday, July 16, 2020 1:43 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix rss reta is reset when device is started >=20 > The following sequences was working fine on mlx5: > rte_eth_dev_configure(portid, ...); >=20 > for (queueid =3D 0; queueid < nb_txq; queueid++) > rte_eth_tx_queue_setup(portid, queueid, ...); >=20 > for (queueid =3D 0; queueid < nb_rxq; queueid++) > rte_eth_rx_queue_setup(portid, queueid, ...); >=20 > // use a custom reta configuration > rte_eth_dev_rss_reta_update(portid, reta_conf, reta_size); > rte_eth_dev_start(portid); >=20 > We were able to configure a custom reta before starting the port. >=20 > The commit "net/mlx5: support RSS on hairpin" breaks this logic by > moving the code initializing the RSS reta from rte_eth_dev_configure > into rte_eth_dev_start. >=20 > To fix the issue, the skip_default_rss_reta is always set to 1 in > rte_eth_dev_rss_reta to avoid reconfigure the rss reta when the device > is started. >=20 > Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin") > Signed-off-by: Maxime Leroy > --- > drivers/net/mlx5/mlx5_rss.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c > index 653b0691..6f75ece2 100644 > --- a/drivers/net/mlx5/mlx5_rss.c > +++ b/drivers/net/mlx5/mlx5_rss.c > @@ -220,9 +220,11 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev > *dev, > MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n); > (*priv->reta_idx)[i] =3D reta_conf[idx].reta[pos]; > } > + > + priv->skip_default_rss_reta =3D 1; > + > if (dev->data->dev_started) { > mlx5_dev_stop(dev); > - priv->skip_default_rss_reta =3D 1; > return mlx5_dev_start(dev); > } > return 0; > -- > 2.27.0 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh