From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8293EA0548 for ; Sun, 28 Mar 2021 13:39:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68837140D8E; Sun, 28 Mar 2021 13:39:20 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2070.outbound.protection.outlook.com [40.107.95.70]) by mails.dpdk.org (Postfix) with ESMTP id 2D63240040; Sun, 28 Mar 2021 13:39:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ia2OEhw/3OMRdF/MC7lIs80ekVUZAaVnI7uETp25qJqjLIJuomGa4mCRDmGVqFCvXaqNhJ+pjaFtLBXELH5XeqHqkzIeaGU+AeYiKLy0blR6tM4kAKbFBT2lEBBhQQppUHguhoHykI40DzGjS72F5aE2d6KgJMfcsa1MqT1k9NRF7KRCTLQ0REa9pBZToTFnj1Ml6whNO8K2sodc+8E7yLuok6jSeZ9IoGg7f4mVGlNl/nE0tU+VqnNRX3UvwmTk3AXm+O9f/HovRtNAJVXjLziQG8ZQl/Fhi2gBZMLdNc3Kpfr/INiCRHbHxez+sr6vD8yMlm/8ojlg4DjDNySqzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fsNtdDPhNZJyM/ULG/XEIkdwZic3SCjb2gU0hidUrto=; b=jMB8yA014z9l6QuH4LFID393cpsKWxdc0S+STIUzqry2qH5TIAcAg9LCOcOkcnsvowNpmRPU+T7VBeozcVi2CZyAr6sUIW/Sm7Z+FK1b/w1D74aVC+K9vYnxjtRRFzq5uofFJZAIPMZ3KuafXm1CexLBSxpWdG493h7zDXrCKV5oQ+Qkgyh1aDqVDA75ugwDfzunJ9NeANsyutBnYJDTGx5wZK6MoBfFCktD5trPtpwEZBmVEdyWobDneI7Xs0WhsuasVmQN0r3ldqEzm6Ep729jBLwkKTal4h1wvTTmMc/DDYYcqumCPB7uEV6foZrVouSSi3JN1466Tq42IrILEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fsNtdDPhNZJyM/ULG/XEIkdwZic3SCjb2gU0hidUrto=; b=UkAYPvTXL+m/Gzq9ODrluq9LoKgb2NIrYdkVVY4+XIuERoMEXzxwrDcEp/XQ5+VmQtCDg8347ZhW5SWsSRrD6zNMjopcjWb2sXh0/CWUBJMlhtDUW9LsG4z6A8iqsnwWHPX+6YyHwEUvDB4khA7+LRnUboIsOu8vJjPkJVZADPC2T4p9oJAnGGx7nI8oJT1Igjr8sViBRcSbQJqve2XtkgUjKvLdxQ2S6GYBGUGzDxirtmGRuum3lhN6bYT+7Psv6KXQ4oQJE1OqfC39Cw6VFLRkC//6C/2Uxpr4lxw99gPHsr7fxY5H6Z9/c89JVwyYXrzNrd/7t3YPPMfH1nUTgQ== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4028.namprd12.prod.outlook.com (2603:10b6:5:1ce::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Sun, 28 Mar 2021 11:39:14 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::3d94:1f7f:178f:aba2]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::3d94:1f7f:178f:aba2%6]) with mapi id 15.20.3912.031; Sun, 28 Mar 2021 11:39:14 +0000 From: Raslan Darawsheh To: wangyunjian , "dev@dpdk.org" CC: Matan Azrad , Shahaf Shuler , Slava Ovsiienko , "jerry.lilijun@huawei.com" , "chenchanghu@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check Thread-Index: AQHXIrMzeO3rVS6cNESMcaM8rOntuqqZSHFg Date: Sun, 28 Mar 2021 11:39:14 +0000 Message-ID: References: <8a980b235eeba49721dfef9d0f23be375e8958b0.1616741870.git.wangyunjian@huawei.com> <1616813049-19624-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1616813049-19624-1-git-send-email-wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.228.141] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53837bd4-6afc-4ba0-859b-08d8f1de1cf1 x-ms-traffictypediagnostic: DM6PR12MB4028: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OBvq0nBSKbHxzWy3Bm8ZvRflo0c5FY4i0NYlz75zTy85XRRDQ/2ENOs6xgh0b0MwYijM5sK8yFRBsGx1giTj0hO7VrUmNU23YgQZwXbyNtnL9JKmpMxrvEzxDGEigDFlFztnXL8seJhmLt11day3eeDP9BemSlKb57oYyuQM3L6BVgU7a/r0Fl4fwmOBubWObOvWhswJVMsxPko8k4EJ1kBItcK/ugvsBz2IvbXP9YfrdqwHdSPjhUMTAdf3TT5Jt0fgpxyVD2UJiCdvFMPcAKyP5LBvXZ2JFbLP+rmRTiiikNwIjlf7Tla9d2E8hbpWNxhFwLqjTqJiDufizwHFxsrLY7g08NyMW+2LSoLutyA6ztaqGTNbWhMbLzTXenoctKhEUyAb9KUlSz1+pFs19io4u8YSdeW1i03VVktUevv6Z52ASqxCxOSAijkNJ2BWvw8kX/DJeTG6/bIOql26YPKlR+RZBLYjrqFBqwPABwdiWNGErAFXhvVgfzPUa3bhX4DhQz//Cyt6tds2RaSRN4QY/Yt+OSf2j5rVF/tnSvczj7FADJc/8dabn2cC21007HbO1O8F+NHXSZ3S152/2a/Ew440l3+WpHc5P5gUvo7Q/GgIDKzqIUnfjVH1++a2yD+Q0C9QOedGAp7XK5J7rlfO0+IBq3jy9fHF38pr9uk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(136003)(396003)(39860400002)(316002)(66946007)(9686003)(2906002)(55016002)(76116006)(54906003)(478600001)(66556008)(83380400001)(66446008)(66476007)(64756008)(110136005)(38100700001)(5660300002)(8676002)(26005)(4744005)(33656002)(52536014)(4326008)(8936002)(53546011)(6506007)(86362001)(7696005)(71200400001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?WYFgnEnx384XQkZutbXitYR8EnAQZI/8EV0ce3RC3QexEa7ceFHbHZe1qnkr?= =?us-ascii?Q?2n6u3vXlJzdYaEcLXL3wobdPvfZjSxp20Qlx9sX49G3JLQBUDScrTEETbuLt?= =?us-ascii?Q?2+wTMV6wO2It9IEUOn6cErgraJzcPbKqam+VxWHRCCa/AO9JtNJ1cei7344E?= =?us-ascii?Q?SHrec/gLm6s162TNm1FACv/U8dvmCB0yEV8cMxPbcCeabv2QTUq6Ypk9N7V7?= =?us-ascii?Q?7A1cniXxAvR8YiVmW3n6IJaOkke7oWBIw5Xhx0dWNy0P1lkZ8v3BXt3B1sQl?= =?us-ascii?Q?l2dZjNEpS4sqkL0RkhtGqhDKLQ6/AAzYroAXX44KpnBZrvwwsYXXdiMPLaME?= =?us-ascii?Q?zeQqY8VB4CfVGZgEifY2U96CfOzHnjnbOBXKeQSM7Rxji+JmA2poCwLv9qNS?= =?us-ascii?Q?ZQBEo3d1PtrigkaVDw9jNO8lJP1kLeVSYKUdwbOOdHGhLRV1ZDxe4L+tRsX4?= =?us-ascii?Q?NASZ0hk2gG4D6h1N2/iBVKd+DrbBesETuju/JIP1s7GdE1ZVF15aZZxkca5Y?= =?us-ascii?Q?ncbfKf1dl6qjRDCtGor3hr5o5KVDdEgk677qIl+0ekgqL4rlwn0KEYX6xyK7?= =?us-ascii?Q?G85zGneVPwNgrvhVzfBWhQWwMwzkYdqZWAbtTq7ZMPN9kNv0mwXsScfU+A5F?= =?us-ascii?Q?zInxnJxhsWol7U6eDeh58+4WQlugsfrUsab0PU13Z1atxJKwhkn11A1tNifc?= =?us-ascii?Q?AVp1vA35fg2c8ZK20gR03OjIY0Y6v4ZZNZrHf2fSrLRO0q5QEqLgPoyHOsHP?= =?us-ascii?Q?XGMItoozIgDaJ9ZDWQC9V/PzV1hcN8C8M+mX6RInqIHO+5MNHqLwmfsmSJGx?= =?us-ascii?Q?ceG75RoYDSaz4OBdubJ6z/ulPTTblx5Tj2WnHvBTgsKRBYkYUnx9NDiQLitt?= =?us-ascii?Q?Q6zzwfNOdU/ZeWbUMJMBrpzK53CJ8mAKm8Nl0t1OMi7dFL72E5q03Z36Diqk?= =?us-ascii?Q?niG+A5SuGTWlovnfyTYPXwrpbEdoNem6CGpaJyeDwS4IMFgSpPQsCwlG+ERU?= =?us-ascii?Q?qml4+ZQhu/Sn4AtCcrPsk3SJf6g1vrrDq3Is9C8PQYokveq9Hj+9ZQu7ys0C?= =?us-ascii?Q?LWFDlUAAWr7JnY2CNHHnddB2Q+ZWWOw+CC5EHo+ZOsCOXJbWiLNbqsdkLceM?= =?us-ascii?Q?WudcjUaU4xoJ2Ral9jFU+96i0ErB0TdaF8pDjJKo/qLkxSINidYMfX5PXmA8?= =?us-ascii?Q?PTGcJEMhMNApweolNjD4aOEC6PFrrOcm5anrmxgc35jGOcs/KdYv2xziAGXa?= =?us-ascii?Q?A9geu/i8ZL7NlLc1ruBadSVfNhWhp7Ciql26LSzQi56eJGhKhsDRgPzP7OYA?= =?us-ascii?Q?bsQfHbtcAkIPtBq2X+SI0hrk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53837bd4-6afc-4ba0-859b-08d8f1de1cf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2021 11:39:14.1660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8tjI25FzT00CNLFxodiDEmb/2Box76Srp1SQIkEWRthDx/6Cp/ksZ1WlZrYA93NWcY6WDPlag8q5Ubh5cAEX0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4028 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of wangyunjian > Sent: Saturday, March 27, 2021 5:44 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > jerry.lilijun@huawei.com; chenchanghu@huawei.com; Yunjian Wang > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before nul= l > check >=20 > From: Yunjian Wang >=20 > Coverity flags that 'ctx->tunnel' variable is used before > it's checked for NULL. This patch fixes this issue. >=20 > Coverity issue: 366201 > Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread > protection") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > Acked-by: Viacheslav Ovsiienko > --- > v2: > add cc: stable@dpdk.org > --- Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh