From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93678A04DD for ; Mon, 26 Oct 2020 23:44:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19A0D2BA3; Mon, 26 Oct 2020 23:44:53 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id C0F94100C; Mon, 26 Oct 2020 23:44:48 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 27 Oct 2020 06:44:46 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 26 Oct 2020 22:44:46 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.50) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 26 Oct 2020 22:44:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D1uefHpBQep1fUj3h3inVdoWPAJcNTH/MmsADvgSvUMQ2o/LqNmQow3gi3xUuqpCxkxqOA70MGUUt/sBLqn5r/QpjMqFV977IDJc1AikSYorHw8YLnUigDYfdtB3P/97Q5dkFWnX46iaAL14l6eL/QVkyzh/r9kNzoUaueGbFyIIHabcppXK98ONFh+xYpC2JmmqgFSNhiHjJNko+NFOW5H/wbKrAjzYtjQOMsKgDSr36WRnFG0wMNdpGrs1vNpBzOBPp79GHC9D0Sm6x7YI+fWIt20/3IPAI99MuXPcCK6V08I9TCWiD6gQG933PqGvED+VQS2CkXujXzxxTDVLkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/2kyyhUjxL674Ke9xQHyxm6Ro3KttwHlg4w7Zu4F12I=; b=ecATMz59rrIJ5E/qHlKQtTBxA/KPNB7yegyBWFLuhV7RB+KKClNi/2db1N8qam49n1sekuIbwurXVL26Dv1IowR2HmfKjAYGel5zLtk3xrGZV5q01jsCyhSs5hI270jp3SG0Y3ETSz3dCiz+MGoBN0/fRXHKAzaToLQJoroojxOwDNTBJoOjVlVS2Rt2OQy1IciFddSF35udZdQ/ncCojimfg0taL7gGDfCOn2PnlxNrgoGj4cLxnoufcHjOLZ0q0E5TYpAbVHOY7BtBDKJtzE53hSTKheTfc8N/TgD5ge2I5zMyxGJRupUU2bAvFVIvTzn9brg+RjcFmkYn3jihHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB2747.namprd12.prod.outlook.com (2603:10b6:5:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Mon, 26 Oct 2020 22:44:42 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Mon, 26 Oct 2020 22:44:42 +0000 From: Raslan Darawsheh To: Bing Zhao , "viacheslavo@mellanox.com" , "matan@mellanox.com" CC: "dev@dpdk.org" , Ori Kam , "stable@dpdk.org" , "parav@mellanox.com" Thread-Topic: [PATCH] common/mlx5: fix PCI driver name Thread-Index: AQHWq3NZWa9KUybEJ0WGITSmiYRx46mqfCwA Date: Mon, 26 Oct 2020 22:44:42 +0000 Message-ID: References: <1603701462-250791-1-git-send-email-bingz@nvidia.com> In-Reply-To: <1603701462-250791-1-git-send-email-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68edd359-256a-462c-5b21-08d87a00ba9f x-ms-traffictypediagnostic: DM6PR12MB2747: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hvYNGKmEVA69ZKcA566Ld+KB/mwDPVyo+CZgDi32RXyM0CSwIgvYjbDLXdM2oC8Rr+4RtY91J67OaoPk35DYVcSDYxQiTHIYvX7oBsZ1E0+QVEJQvBrApyzYvL88Pk+2v4te+Y0/OIVhHDnYTwfku3jRhrE69VcuDdEoS6DvMTpjEzvF6KmICS0vb92NOIhoQgwiYrxatJLkIgRTXqkS5C9V6yOtA9PiMeCkzUI545im4wDMdebji4e5W5SdjBfo1rP4sAkYFzLoUIar4u2vuzk4nD3/l4hoiVcyKu6kHBRrLXrl8z8YJRTb8+/TdenO x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(110136005)(316002)(66476007)(53546011)(33656002)(66556008)(52536014)(4326008)(478600001)(450100002)(2906002)(76116006)(8676002)(55016002)(64756008)(186003)(9686003)(54906003)(86362001)(66946007)(26005)(8936002)(66446008)(5660300002)(71200400001)(83380400001)(7696005)(107886003)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: HC2n6uqJsMfRn9gCCodzC6fX9jNBRlXbi/U1mMkqqVIwX7JBERlNVSIyjbnfMC4pQbvQW9VnxDNgaa3eNAGXlV2ULVD+lzWaAPUIM0Q32qYXf45VhlLuqoSygDwgMgr5/4z11jyQYZzZCkO5VIKxa6SGYbrbgfbidnyv35X03MJNeBfPUstr8immhrjttDF14viAYr4jfmGg0342T5QQ2vr7fJYGN4+zza5rFOtfJF+ZE/Nb+Dma1rfz8f0tVcWyB0n8mIwBRcZi/kzPf6RfU17j/xYU2HUzHEXSgRF6x0bgXrsPIBmA2mPwmn+xCQi4KdVq2r57TyovfkDMkvil5+CR2pOLpSYmKfD5Ry+TF0XAE1SamKVgsEDBn0WLvgZPpQSJdJEhLfEk8uWghARoncCphLEwR7JASy8zMNGdgRnMtxJ3hgceno2Na46RHLPuwdE+nYvphvRATh8RkAt8KLKyiBSCZMeCxXU0z41gfULS0itcPr/WRbGOxwyx4MuuR2e5n86ygGhzPJMeLb1ONot9AbY71uSRT57NFEv2J+37CMWQqxgEG0U7Y0VVkAIrzul1qvsH1lPdNq2CwKTB/puWYLNvroPfPS24kEzg8WQhVEY1Jy/RdMF1vPrmp0dJbUrkCkNfe0lfsEhQDFm6KA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68edd359-256a-462c-5b21-08d87a00ba9f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 22:44:42.1130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0xuKw116eQ8/nsWzIF4cXH7ec/e0K1A7uOGPyjE0DZM2NWwqm/xrnDZxooRXLJeFkUI1ItsKGJg87NHpm8oDQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2747 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603752286; bh=/2kyyhUjxL674Ke9xQHyxm6Ro3KttwHlg4w7Zu4F12I=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=A159hJnnI+JHtp8Jod/Wo7GTQnWdsoQWMUGgV33hkc+1YtbU9VkFSP7EJgQ524d4b qog4lsSzxYt+/oJO/aIDgvp0Kj4o9/b7iSwLW9pgveX2R0sBitxjnUlpy6NiXsOnce /FWn9Cwd9sF+4RCincJaW5p6IUL7xslChb6IZKDCYBpemk1HaK6ZdSMbWlRHe13ZAA EJO8X2GF5QLVEIY9rzyV+GS0yoUsenVfdIH6Is4XEFwBqaDycFyEMIi61SHbzYwsjp QL+SdXCTg6k8dug5RU6s7ysyYjvXghVchSiAlEtHNaE5zCI0Wt+QA08UZ7II85lhwz n7Jkx4WPJLkAA== Subject: Re: [dpdk-stable] [PATCH] common/mlx5: fix PCI driver name X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Bing Zhao > Sent: Monday, October 26, 2020 10:38 AM > To: viacheslavo@mellanox.com; matan@mellanox.com > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; stable@dpdk.org; parav@mellanox.com > Subject: [PATCH] common/mlx5: fix PCI driver name >=20 > In the refactor of mlx5 common layer, the PCI driver name to the RTE > device was changed from "net_mlx5" to "mlx5_pci". The string of name > "mlx5_pci" is used directly in the structure rte_pci_driver. >=20 > In the past, a macro "MLX5_DRIVER_NAME" is used instead of any direct > string, and now it is missing. The functions that use > "MLX5_DRIVER_NAME" will get some mismatch, e.g mlx5_eth_find_next. >=20 > It needs to use this macro again in all code to make everything get > aligned. >=20 > Fixes: 8a41f4deccc3 ("common/mlx5: introduce layer for multiple class > drivers") > Cc: parav@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bing Zhao > Reviewed-by: Parav Pandit > Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_common.h | 2 ++ > drivers/common/mlx5/mlx5_common_pci.c | 2 +- > drivers/net/mlx5/mlx5_defs.h | 3 --- > 3 files changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_common.h > b/drivers/common/mlx5/mlx5_common.h > index ed44a45..3d3d109 100644 > --- a/drivers/common/mlx5/mlx5_common.h > +++ b/drivers/common/mlx5/mlx5_common.h > @@ -18,6 +18,8 @@ > #include "mlx5_prm.h" > #include "mlx5_devx_cmds.h" >=20 > +/* Reported driver name. */ > +#define MLX5_DRIVER_NAME "mlx5_pci" >=20 > /* Bit-field manipulation. */ > #define BITFIELD_DECLARE(bf, type, size) \ > diff --git a/drivers/common/mlx5/mlx5_common_pci.c > b/drivers/common/mlx5/mlx5_common_pci.c > index 02417c6..5208972 100644 > --- a/drivers/common/mlx5/mlx5_common_pci.c > +++ b/drivers/common/mlx5/mlx5_common_pci.c > @@ -408,7 +408,7 @@ class_name_to_value(const char *class_name) >=20 > static struct rte_pci_driver mlx5_pci_driver =3D { > .driver =3D { > - .name =3D "mlx5_pci", > + .name =3D MLX5_DRIVER_NAME, > }, > .probe =3D mlx5_common_pci_probe, > .remove =3D mlx5_common_pci_remove, > diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h > index 42916ed..2657081 100644 > --- a/drivers/net/mlx5/mlx5_defs.h > +++ b/drivers/net/mlx5/mlx5_defs.h > @@ -11,9 +11,6 @@ >=20 > #include "mlx5_autoconf.h" >=20 > -/* Reported driver name. */ > -#define MLX5_DRIVER_NAME "net_mlx5" > - > /* Maximum number of simultaneous VLAN filters. */ > #define MLX5_MAX_VLAN_IDS 128 >=20 > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh