From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24265A052A for ; Mon, 25 Jan 2021 09:31:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3854A140D73; Mon, 25 Jan 2021 09:31:06 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mails.dpdk.org (Postfix) with ESMTP id A79E5140D34; Mon, 25 Jan 2021 09:31:02 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Jan 2021 00:31:01 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 25 Jan 2021 00:31:01 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 25 Jan 2021 00:31:01 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Jan 2021 08:31:01 +0000 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Jan 2021 08:31:01 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 25 Jan 2021 08:31:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oaRR0Fmd/6WiQ+GR8UZm5RtrgXSU3vD/bbf97JCddtbJdj77zVQVbXZ3fT8SxMJRuM+ZrzS1yNKGCRPwm35Ru9AkX1epHjc7B0U2hvThUMnn4KTY1fcpwgDdiHI4yKhFQW6WUwJ2sbUmzbPdMHmTgtYZFhHmtgDBYLXMVFNm+pDHlJ/OmL04fVZ1NJ7rihVfM0iYJUUKQnmMAjVN9vk9/TFvJOlR72ltyl9+YsMTkr06pmtiZk7GpR9gtF88tQNvL/KgJucM4auxctPi8aPBaKYvnYgcYXERP6YLN60FoXxwqNdU71rXb48guQ26V+civTtCDIJyGVDswLUQZVOVtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHktzG9qkV5BBVk6fMIEBGch3ENWxvkpDKZQnEN4OUc=; b=Ii1ngP+C59SKBXHjsAiNV6LTN950KS0NZY0ytbrTeQ4jwU1CT1Qld3bocNmgMn5Lrsm0m7pduuCWgZQ+Y4UDE3FI8w1Wgepi1lKPIIOcJv2EQRJiOIzaeKdV/3pJsVsQQuPB3+HIwqGwazvO3ewI+UPNjwUifxdqxZZCiWqZ9JhiR2m9r822LMlrgLG9y/a4r0l5TwgdBX+aO/DdkzI69AW3REOYIQCK2APQnp1ZCEVzqcLHsmvRN6RFSpNjMLBLWrrqYmhDYf5RpMO9G1f4hJ5vg0lhMA+QsEgoFSUAKsExdWakDnLNI2EWEr0XXBzGtH9Ggw209gcEMktHIFWgUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4928.namprd12.prod.outlook.com (2603:10b6:5:1b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12; Mon, 25 Jan 2021 08:30:59 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3%7]) with mapi id 15.20.3742.012; Mon, 25 Jan 2021 08:30:58 +0000 From: Raslan Darawsheh To: Suanming Mou , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue Thread-Index: AQHW8kBlbMjvlHUT5EerSwvh7Cn9WKo4A9DQ Date: Mon, 25 Jan 2021 08:30:58 +0000 Message-ID: References: <1611486126-84749-1-git-send-email-suanmingm@nvidia.com> <1611486126-84749-4-git-send-email-suanmingm@nvidia.com> In-Reply-To: <1611486126-84749-4-git-send-email-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.199] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7737db43-9e45-42e6-5601-08d8c10b8abb x-ms-traffictypediagnostic: DM6PR12MB4928: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:486; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dSqUMNbSGimheH+NNaoxx9ivIzCdakJct67+GfalriMWH4228NsVO7ThlE8wlcJhwFluPkalhgRGoAMvoA1L2rNuA4fMpBCz4oCS72ELrIvmDbu5ZjvNNzFXECcoiyDzYQWnPP4+HDAYtQYMkJDC7x4N/zm4/TM3V0Nv7dsV/Nof2s3iPY/LD3ociYJDVvfugo18jJmLFkVk1LOWHF1nPc5nnqIsuhZG2ZcSgAWKwcWAYH6LbIxD0M0k2mqgKL+bOISE9b/Kg5/JKPiv7goz6Fh/wthjVE74wbBMGRxGSaRELJAY0l4YBzVAOEMYyrTbVMWbBH6Pdmrw8fvSp9wNQioquVuK9xB8BYf+pare9iY6lMVjfhozVA8TtLb0Hut77+DnNBZ2Zzg4x1jfJgKbwGykMnkfcFak5ePN/oA9x5DAlQL3ovkVHqd/3OAWrG+TY2ibFNnMkIM2Aw4Q8i9kVounpBSkDTw/r18Q4sYQHHncRfE61uHfUnOdUn3GvwJfycDhNUgLXF7wj+TE+2Q0jA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(346002)(366004)(39860400002)(4326008)(26005)(186003)(450100002)(53546011)(6506007)(316002)(71200400001)(33656002)(86362001)(478600001)(66446008)(6636002)(8936002)(83380400001)(54906003)(110136005)(76116006)(5660300002)(52536014)(2906002)(64756008)(7696005)(55016002)(9686003)(8676002)(66946007)(66476007)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6dv6WZMxaxbEeMcoxUe65nK/FfV+KoNPXRVUVgrmLDU1BMYeWqW89GdZiK3V?= =?us-ascii?Q?4tRuzELoo3/aRAYYYMaTAC6K2+vyjssApJZWTSfQRdinDmwWkv6oSyChf6cS?= =?us-ascii?Q?Glwk5/wTllqjhzAsLFhG+08i7v22o7PEWTV+Yk6PQGJxdeHppVpxdEOctlAu?= =?us-ascii?Q?2xLZVR/rImqAunjBE7Q95j4njhl2TKYTgb9HsY1QyXqUj9WypIBbY31gVJbw?= =?us-ascii?Q?SksaWuykjqhGISkAinKiG80xbNqZEe4wzzc4pAaMMREKruggP5ETLqlU5ax3?= =?us-ascii?Q?jLQB0fIwyy6PhFWdjbk0Bv7ssmcurbXKDlpFjvRol1Lc6IFn2jkauBRnUQnY?= =?us-ascii?Q?pS1ymzTyQt4aiIKXFptDPoP+CMcdNvSp64hirN5lufJ3C2HeNX0G9Wo28GDk?= =?us-ascii?Q?Pux0gPMME4plMJtCOxPN+T9dwLWFGwsqqRW78uX7MMuQ89jSy9/RwRyKqr3D?= =?us-ascii?Q?jrkTc2FnVx24IMZaC9gAmY3STCAXjbVpSJdHPYQe/iGY/NxQrS4q5VglXgmF?= =?us-ascii?Q?cIn/1+qEyRKrPFW5Ep4e2piLENCDiryqaeN2f/4Zh+EK4S/U9ivhvY2TqKPT?= =?us-ascii?Q?ibKEvXq+UQUY6ZoK3OprlwkzIq1DxVbf9TZe6AUWQAnBF4INHR9+iwaDtSfZ?= =?us-ascii?Q?O7jHU9QWLq9yN0DSkLS182RBLeYGpKT4W83FqYraY4d/HD5C6Y/utEXF4fhD?= =?us-ascii?Q?K6uBujsfEuiNF1SJOWvlOvKVv9xyVoHZu4UgAUZSDmgK+rlNGlE3y57x4Lnv?= =?us-ascii?Q?0gb9ieL8+lDg6RloxAGZtsbneYRj52RHQPf9/7eveiKOX2MNwQrxvB0gNIGR?= =?us-ascii?Q?0d+oUSQc3MLBfSKmuXGJ5wzogJ7DzB+hKo5BsOMw8NvmSvO2VZNSYVZoRM8G?= =?us-ascii?Q?zx3VkvjlYW6bJGXJ8mpkGZRo15iiNzoqVypPUNEoeMwYSsCmAtoZ88IsZcN2?= =?us-ascii?Q?rriS819xTUmGwFG+/kE7yB+yy4xkO0nOhcdoccDTFR0DZDKd+su9P1FnSJAF?= =?us-ascii?Q?um5bM+UzHVR/O+3bQ1fELOxWZKcqb/l9AGAyblRKUKxSP8yf62URe54lEEXG?= =?us-ascii?Q?ngtRyGeE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7737db43-9e45-42e6-5601-08d8c10b8abb X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2021 08:30:58.8179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VMF+yhYh4Q8AY1pJr1x21tbgMiMoc4S+qOST4Tkja+i0Dk6aa4+7SCphjckjnMR+fuczlnLi/i+sb7ijxbCcJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4928 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611563461; bh=DHktzG9qkV5BBVk6fMIEBGch3ENWxvkpDKZQnEN4OUc=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Copd6o4pyXuGJ3FVRunXg1hXZ2sdd6w+a1bMVCmtcrbcbI0ovQk4/SRaitxiLWhis kU0EQYqOqbXE4BM+bzxxbZfiEldOmWLFguEtV1fW6V6Vbu83B8sRHLRc4VKj51tIwC vH3y2MAWgOhJ5f5G/+fc9lqxy2TbihVVpNEbvWNl5cfzzzldLnEQHQ93NqDqWUJjmO 5xua6xs2sZctRkBjGQjLt205GAIXkbKNSSzLlxYWxzVKetxTlQO9YpWZCpW3j6gYxC lSfP3GSzpp6SAm46VcPv7VRR9Ua6tS2xhe5mKZL/lqLXFrF6Q3bQOHF47CWb3iHrjq 8OEyH2pv6+FuA== Subject: Re: [dpdk-stable] [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Sunday, January 24, 2021 1:02 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org; > stable@dpdk.org > Subject: [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue >=20 > Currently, the secondary process port UAR register mapping used by Tx > queue is done during port initializing. >=20 > Unluckily, in port hot-plug case, the secondary process was requested > to initialize the port when primary process did not complete the > device configuration and the port Tx queue number is not configured > yet. Hence, the secondary process getS the zero Tx queue number during > probing, causing the UAR registers not be mapped in the correct > fashion. >=20 > This commit checks the configured number of Tx queues in secondary > process when the port start is requested. In case the Tx queue > number mismatch found the UAR mapping is reinitialized accordingly. >=20 > Fixes: 2aac5b5d119f ("net/mlx5: sync stop/start with secondary process") > cc: stable@dpdk.org >=20 > Signed-off-by: Suanming Mou > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/linux/mlx5_mp_os.c | 19 +++++++++++++++++++ > drivers/net/mlx5/mlx5.c | 2 +- > drivers/net/mlx5/mlx5.h | 6 +++++- > 3 files changed, 25 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_mp_os.c > b/drivers/net/mlx5/linux/mlx5_mp_os.c > index 08ade75..95372e2 100644 > --- a/drivers/net/mlx5/linux/mlx5_mp_os.c > +++ b/drivers/net/mlx5/linux/mlx5_mp_os.c [...] >=20 > -/* Per-process private structure. */ > +/* > + * Per-process private structure. > + * Caution, secondary pocess may rebuid the struct during port start. > + */ Typo in pocess-> process rebuid-> rebuild will fix during integration. [...] > 1.8.3.1 Kindest regards Raslan Darawsheh