From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00914A0C44 for ; Mon, 12 Apr 2021 14:30:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E769814118C; Mon, 12 Apr 2021 14:30:05 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2053.outbound.protection.outlook.com [40.107.223.53]) by mails.dpdk.org (Postfix) with ESMTP id 03882141173; Mon, 12 Apr 2021 14:30:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOvWOEEgaQldE9rLO78FUe6XpK4dxS2BUm6WGuam2OPOx+qV8eDPDGo5w6M4xwlXsmfpULYqNoIzE3zprbwXmPuevvsXN1JjnusiU5+JPUNtGOdKcx63wgk6NPqjdXft1KFyaT6ADU2Zv/rddLAY5tOWFrZrnAPQ0SFPtgb5iv3mba8/0C0doXb5tYFbiyle76jB2hSjpt6WXIy+L9+u7thGJ0zo94ZGeYhDfSWh6uvaCel3e+2oXh8DwiUollZBSAkSBlWyIabdifVns+KvUaAa8t6ItKrPz1rdu+vafFRAx6PxKqwB0+1K/rgSXZcMJSEJUpD2X6hktIGFyivSWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ibyTMFjr1nLwXUGAvwhGVVSBhJAKAPBOQPgA8djyNOY=; b=mu6ZyRwgBwUqUuMyTHws5LiFnAC2GBzybDohpiRGewAH8l48rL6wscpWGfCH7spUA/uJv+WDAkNTFMt8gTxtZbjBVTKKj2IXiJ1O2S2aB39EZ6kAr6kfIyGaX+u0uqqxKi3moLLuTXcliidAKkLwr7drwOAkJmZK9kzZ+hUlOFmYi6qbLY825dYpeBmRYzx5mYVCGpTUnK5gVcaLFAhLiDrtJYg4VyP19L+pdEO3csF6PPoQHPEFD+6InfFi70E41L/+Y0fb9E+x7vkFZMBGRGlMp0FTk7SOvsWDjiyCr35L7s60rK5AJ03jg/Thj0z2WApF7QlKp/9oHVCnUW9L/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ibyTMFjr1nLwXUGAvwhGVVSBhJAKAPBOQPgA8djyNOY=; b=m7j/PNQkQ9kGqppY+fYjXu1cCtkRZ0aWp56zScD/5DZD3YH2YSPaxgvM8UCVKBKbwVjGX2eysCMIPyxfnCBs+6hz73kCPRhF1EmFkFlokBZ0JjOUG3lliJ4JGNuHmGUyCXKGg1G6wWVVZ1Mmedn84m10RUheOI17vPJpLGHBuqROf8EnXaP+OqKqfA7WmHpN8fYIXBbMnS0/W16PM7Hp3O0CIbGKNaLuhN9CLZkbqRYTsbRvmzREZY39NnSIYEr8mXnI4njy7QVwX0lfilNbF2pJ8yVQx0ZTST+gblZFb7N+jjlCoYvOZrwObO/+JmVMjxIlAedeGR28GDvpKS0UBw== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4204.namprd12.prod.outlook.com (2603:10b6:5:212::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Mon, 12 Apr 2021 12:30:02 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280%5]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 12:30:02 +0000 From: Raslan Darawsheh To: NBU-Contact-Thomas Monjalon , Tal Shnaiderman CC: "dev@dpdk.org" , Matan Azrad , Asaf Penso , Wisam Monther , "stable@dpdk.org" Thread-Topic: [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions Thread-Index: AQHXLs1U2hH+/jk9ukWQlvCHuVP9UaqwvyyggAARTACAAABRsA== Date: Mon, 12 Apr 2021 12:30:00 +0000 Message-ID: References: <20210411122136.2560-1-talshn@nvidia.com> <1737490.Msu5DJBOj2@thomas> In-Reply-To: <1737490.Msu5DJBOj2@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6393d9f8-441e-4f51-e01a-08d8fdaeb1d0 x-ms-traffictypediagnostic: DM6PR12MB4204: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1332; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FxBoom8+TFlAIJ1J17Fvptb5FJ6GHhsqlocDj3ALK78tnoSWKVSiNUWz3krwI0Dd2C6kU5ShC+gmbSS4zAGfL8Ifl85yXfQhozTusSG/mIyv4CMASlWCFVVXmphLU97ASepiWwfAq7BcuO0xGNH2H6ZaYbAUCFfcsx3+pJsxeA3qFny5XTraJb2Dh41fGU3vu+bL8pzub2gmWE/Bxa2CsbaAai/uMnIqDjck/Lexi21bYh7M5UB+jnr7TKM7vKq9TL7zRiortAU14Ue2zRI23YoExXQnC0gxfT7zrTz6QLIYSCo5tv19asABkERk8S5ibnr3igZIER/IIcNFdAs8ose99vtdzdJ/C91NJ7QoO15S+TTnY0V8qONwdcPpa4zRjzQHsjEHjDspv3UJlLevVRG8qqwY3/s757HoD1h9avwJX2nPZdJ9Sst71wDkX4HiCY4PEODsO5Q04qf09fOMRETrI6HsZU5HOyLewQ/LHTdOrkqXqQxlyvkiaQcJ2/Vum2AeB5wzRVjOBITffyJgYYX0gsPPMQqeE0ugIQzstF1JgTUvfMXhVC+Ih9VINlpOHSHNVfmSmymcEUQoMfjclP/40ofFg3kSdDnNON3MYIM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(66946007)(76116006)(478600001)(38100700002)(8936002)(66476007)(66556008)(6506007)(64756008)(53546011)(66446008)(71200400001)(4326008)(4744005)(2906002)(186003)(5660300002)(86362001)(8676002)(110136005)(52536014)(26005)(7696005)(33656002)(9686003)(316002)(54906003)(55016002)(6636002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?P+6G8IHYjm4aJkXh7PW5sDXSQt09YI21ArzRYAzZwc1Ac3lERUKt+AB7y0KR?= =?us-ascii?Q?As3UcDmT1D9931u/T7KjrREcbR9IRXaDVjDal8JCbxg9FH/XS5+Nj6lEhTKp?= =?us-ascii?Q?CVj8OnLHJGH1sT6BP+UWlZMllqd5iJgqfCJnIOPIfwPn6vt5i02VHs7R1KPz?= =?us-ascii?Q?KvClwOXLyH4bKjSRKehxatVBr6bW4oSzTFKGEBd+IqmXTJExcHst/nHUiTRF?= =?us-ascii?Q?8YFvMWYl4VVq8hlE/UPtCff9oJ24XpiGlQsNkuYwUe19SSWQaGsHMcbvesnK?= =?us-ascii?Q?I+p5S7XD2MqQon5oLXcW9RZzTt0Mh6gMjdzOEWB1+zWoM3bNJLutg9r4JN/B?= =?us-ascii?Q?qJF2hMhUdzfqKGNXtU/Jzt2g4TtVF13k8Zw9pz+8tMDwAN62WaEDY0CtmZMW?= =?us-ascii?Q?QjQ5BX+bzY1/r0l2lT+X6WwAC0qSVEuiORhOT/+ejph/QJ6M7b7eFVfYlfy6?= =?us-ascii?Q?1gThqXutKZ5jxHeqds44wQ0sN9OTv/VLXFJyKUwE9Bf5l0kwyBzrHGguyEwR?= =?us-ascii?Q?RUH+IxAr5+gW/BWiO8Hm39Ajqdn3ACdMLleUL+DGKwG8Gk5MT+Msd8FDMXyA?= =?us-ascii?Q?9g2OcgqI414LoEKT7j0+SWdHXe9qRB44qprByl7joJ+Qwz6cn/cMbeZC7sg+?= =?us-ascii?Q?WEg6Ucx1+2r6FoAETxZNZfJCbU7hjK6KNi4QRT9RoW5YMBE8xM1j+fOR3/zu?= =?us-ascii?Q?hnEI2PK5Aocw+nqA43OSUiGiWszy+EsuRSLAqsgnDK3DEguHEawjJQgVuWzl?= =?us-ascii?Q?OJCg9TKDrR3hW6l39scZeqAOAVYW0I3/WNGtypcXl8u37beDMYKqTjb1nXbx?= =?us-ascii?Q?oAnWD/QcEELRXobPYCI4grP/Sp/CsvITCYSTgeulxfYnp6cXC3akAseGo6B6?= =?us-ascii?Q?Zl4dkSpspFhj31xXFhGwgInBSzJi/jPHpXYW6LNSfFDxPoEGctUmohQV3Wbw?= =?us-ascii?Q?eUtmcvqipZ1fO3tqOVOLiFofD2rUxY9jvFPX9RlLHihHnMye4OQvIuju8JLr?= =?us-ascii?Q?KQDOsxMq/TiVnrocP9sIwZSaFnC/g9HC9lJiUNN+3auMOjllzShy+W/iwWcT?= =?us-ascii?Q?7vvOnoiHfzeoYylQTpk+FgbQhEUujvnr4pOCJCG1DlvVvxXwlQ7PydN5Em1J?= =?us-ascii?Q?H0Dy7i2qf46Mv6lC0f92ltQHFfRiWCSXIvckjbmFenKT0/TBmrNHiEtknYXx?= =?us-ascii?Q?r4rU0+mSAXmUHAlXXCBhpUHEtPuWKuGjhFWVVLZ6MgHdMntsJ7KhC2wZqf7o?= =?us-ascii?Q?GMcdANJIpoFMWWL7sdx+eJjBLz1bGuSHYaIsJ9jMrQVS3mCQV3eE9pHW7n5l?= =?us-ascii?Q?XAbDaZ0jK92ixYtTC6p4Hsrx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6393d9f8-441e-4f51-e01a-08d8fdaeb1d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 12:30:02.0978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2hSX0hbgLRqsyHeM2eoL51B8lSff/hKGx/bKsIRrlzvP4hPXJL4ofv1gtGGIeGucro31ErhNrdQITFtDty7I2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4204 Subject: Re: [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, April 12, 2021 3:26 PM > To: Tal Shnaiderman ; Raslan Darawsheh > > Cc: dev@dpdk.org; Matan Azrad ; Asaf Penso > ; Wisam Monther ; > stable@dpdk.org > Subject: Re: [PATCH] common/mlx5: fix missing __rte_internal tags in > exported functions >=20 > 12/04/2021 13:25, Raslan Darawsheh: > > Removed __ from the commit title to fix wrong headline format issue. >=20 > Removing __ makes it wrong: rte_internal does not exist. > The idea of discouraging the use of underscore is to avoid > naming bits and bytes in the title. > Here it should be: "add missing internal tags to some functions" My suggestion was to make it like this: "fix missing rte internal tags in exported functions" But, I find your suggestion even better, so I'd change it to that >=20 > > > Several functions introduced in the addition of the Windows support t= o > > > mlx5 were missing the __rte_internal tag although being exported. >=20 >=20 Kindest regards Raslan Darawsheh