From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94032A04DD for ; Thu, 5 Nov 2020 13:09:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72B3AC325; Thu, 5 Nov 2020 13:09:06 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 6FFF7BE9B; Thu, 5 Nov 2020 13:09:01 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 05 Nov 2020 20:09:00 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 5 Nov 2020 12:08:59 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 5 Nov 2020 12:08:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HgYTpL1qruJBUOZpdhkWdK8curgTlVk3xOJIKP18YN/2vGilK+DdevI8yvZUuLOUtqdwwcIHjBg3oED7KW7Sc2I2lAxEa2rzWrSolim6BcpUdRIm4yLQKs+dSYsJE60bjupBRj26GiomwN1UvOO1WDb6Bif0noeJocOTWfbH95sgj0EpDmRMfF52l7jOF0WsLkgljZKEQTsuRUp+G77Wrmmqdd0vPgUQdf7GP5MCZaMQjGVrA/sB0HHyUvlc6Bnr/qw3GidiZ1PasC6nPybtu4lMnatb129wrUtJh+OqKc+eYQwpLLt98eI2Yt4pP+nxfpvsHqH7tSFE58nM927HFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NogavN3aFTJ2wvWOFJ4r8jxSZN9u7gUe5gsJtOFNXHw=; b=EjT49LrCZX1rNAuetIiBtnk59w6Ujdn5BSGEXg0F6c3XHn8GpH7YCjiYfze2TZpNo5OD1M4mqDSdFQDRt8kukmp8YP9zRU4OwvVkz3m1vlf0zXwYBSCa2Jh6hmywdgYgB9+KhbkU1Hdx6Txh8kl9wTZnZRL0RuwFrTBwkPm+2b5qn7udXNLLk1vYaxM7efXnjydUIImiK2ECoiBNw+oOgZAA7UOnTIOSSJvmcuzrDy+P8WGEtCtglC4bqLnT0Xjqy8xiq6Yg51Al9TuTdgMnnICJjRJ5kS0+8qOxp3i2uo2YfTkGlK6yRruwP1jr0jOtlPMX4z2q2xqTtLGraQWaaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1899.namprd12.prod.outlook.com (2603:10b6:3:113::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19; Thu, 5 Nov 2020 12:08:57 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3541.021; Thu, 5 Nov 2020 12:08:57 +0000 From: Raslan Darawsheh To: Tal Shnaiderman , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] mlx5/net: fix release of SQ resources in error flow Thread-Index: AQHWrU1thQiAyA+TjEiEQXex9hKxXam5fibw Date: Thu, 5 Nov 2020 12:08:56 +0000 Message-ID: References: <20201028171040.6476-1-talshn@nvidia.com> In-Reply-To: <20201028171040.6476-1-talshn@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a830cb24-120f-4f27-0bda-08d881839274 x-ms-traffictypediagnostic: DM5PR12MB1899: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rsA7YpRaybKSPo/xhJB6ZclCqOlr0gzY20JYe4vdW3YuDAF9irs65pdUcL6unaFxlNn94tCj2+WNKIRkI+8DjS8S+pNG/GgYseBEeM3U5ExdaH1eR5LAkIB2jis5RUyt7dLfFZE0YwHhbDC42ldOGghuQYBkh2W8R/evnKt8WgZnOep50Iz/WOcabItNNeGMf8ESMK/ugkhZIdHNbyBnm6qo2ygiewgu86dVJZ56W53bslQJSD1+LzkiqRiorirkYsolEH0peeI+1sez/omPQzPehkSD47fhj7n2ciQiCZr2G+zBpLl1Rk8Yu4hSx4iq/fcAjnY3oZjtOF5Ya196xw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(52536014)(5660300002)(8936002)(66556008)(7696005)(76116006)(66446008)(66476007)(66946007)(33656002)(64756008)(316002)(54906003)(110136005)(6506007)(53546011)(9686003)(478600001)(4326008)(86362001)(71200400001)(2906002)(26005)(55016002)(83380400001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 00PqOBMCZES3xQhay5cKSt0AL915T8OwGYgDs4ucUBpVIqUUwcpUE3xUMOrfUjJOvNnRw4O1RxK8aryLt/IZRyLvmFVnic7Z3GKJnv4qPfImqfifcisyoeZLlquUI6LtAHSzZHeQb78skpHP+JrAb22exOOHaXCvNsLdfl/RMALWM1UZFu6yH/N9iTipekhLIhALA1z2ycuYNWQQ2grmt+JMDBFww8SobDTeR2HnVTjvP3eD3OypijvZ8FJsMMR5rqaDjNulVkKGu1v6Pa94j2Tz0541CgmWS3S/umqEn4mj422S/SXyngl7xU+AXCmvZTcyHeMJhEokltWVixLIyUw1APQI4fQR9UXw/PPNs/q2akbeHp1w8e/L5Nii0nSFWfuNh2ty87V6obtz/ss/FtS10BteHfphvqmyhKc5avaz+HSru8IGTfQGCJCtOREL15AC44b4DB7z3DnP+rHU51jq/jlLhiEx8vACJ3aSYJttujgM18aVHf8N2wyNR7HbLK8OZtEKyKPh1l7cHziww1a4NaDVYD+4zVsDQAFpvGhTCqlnIsbPwlqawYKkz0WM7Y5VfuYGoG3HZ/xzGxQhe24wuyGXohthKPDelOYW8sldgfJ0719z2N6YD3vH988D85AA9Iy9R9FernDDwdoxvQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a830cb24-120f-4f27-0bda-08d881839274 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 12:08:56.9353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JoVdSPltLdGaZi6daf/6VQnDq1BtJN9//1WpZlTuDEmlKJDWIBFP/0Eo4P4MCC0ev2ZWQ5Zh4H0YZTLXSH3nKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1899 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604578140; bh=NogavN3aFTJ2wvWOFJ4r8jxSZN9u7gUe5gsJtOFNXHw=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=U/PF0aj4VWq+36kQ/IdC8q9ebc54ti7ySyZLEvdWOuNORAdOs1nQBmQRCYBzLICvo GxgQH2gGBs40qe/DQ8ZJahI9afAFpuhYnvbhpf/Hmc5jOQLCNOsPbz4MZRUuUSPXF+ kF7ZWw4BmqHKZVwXR0VQa1Y8l9GiSDrtHW5M/k4q8T+a1b9bhCn6t/fipor3YmLe4O Z9cdgFPKLUKaFjS29hN4CakF4Hhwi/R5NrbqY9mVM/Bl+Opswbcg32Y5UqqrqmW0Ps 2OkGzPanybgFJNTc4IPYgqy9xr82mOALtn6+SW71KgmYo6pnJ/B1c8tUH5LcEdNWNl uwQ4tWgN6VQ8g== Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] mlx5/net: fix release of SQ resources in error flow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: dev On Behalf Of Tal Shnaiderman > Sent: Wednesday, October 28, 2020 7:11 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] mlx5/net: fix release of SQ resources in erro= r > flow >=20 > Fix in error flow in which the function mlx5_txq_release_devx_sq_resource= s > is called twice by setting the release object to NULL after the first cal= l >=20 > The incorrect flow was introduced in the work done on generic > object creation. >=20 > Once an error flow inside mlx5_txq_create_devx_sq_resources > occurs the function will call mlx5_txq_release_devx_sq_resources > however the released pointers are not set to NULL after the release > calls and undefined memory is released in the same call in > mlx5_txq_release_devx_resources. >=20 > This results in calls to MLX5_FREE with > an already released memory addresses and assert in mlx5_release_dbr: >=20 > EAL: Error: Invalid memory > EAL: Error: Invalid memory >=20 > PANIC in mlx5_txq_release_devx_sq_resources(): > assert "(mlx5_release_dbr(&txq_obj->txq_ctrl->priv->dbrpgs, > mlx5_os_get_umem_id (txq_obj->sq_dbrec_page->umem), > txq_obj->sq_dbrec_offset)) =3D=3D 0" failed >=20 > The fix is setting the released pointers to NULL after the first release > calls. >=20 > Fixes: 86d259cec852 ("net/mlx5: separate Tx queue object creations") > Cc: stable@dpdk.org >=20 > Signed-off-by: Tal Shnaiderman > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_devx.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh