From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AAE9A04DD for ; Thu, 5 Nov 2020 14:25:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F14AC804; Thu, 5 Nov 2020 14:25:40 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 44083BE89; Thu, 5 Nov 2020 14:25:35 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 05 Nov 2020 05:25:37 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 5 Nov 2020 13:25:33 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 5 Nov 2020 13:25:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NTTDeYxIleH5TN0xsGkexousESmMmjTo73oh6qUSyOdvR5bqF3Z02eoKRvzBpxH/zFWsQV6MRvaxyNc7fP9Ca66B0W33mjPV3jG4Cd6sk3IFvdTO64Tbz0NeFt5eBNcRVCk5IIb4usCV4WcNUcmmxdPq8FUciNurOEi8WCZ8wDZdY1eOJXplN4pJouZNdKft8SihjO5HGX9/HKOMP6x2gSoD3Afg9OA9LaqiQPkYDGORa4lFkK6/9V2MHd05EUM69MrS4cCdEwmdyGMcEGEjBxPBrqamON/ET8PEiza9J9pu094Mj8rCuD7sNUiE9G/hThpKNw99QQjePmJsVGAygg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=muvIOccH0mGzC4TouZoZwUWVqVwo8JsJ9+MGao6IGvU=; b=W1iVQiOo0utvXk0MbRFA3cZThku72D1ObBSoRsevPDkNjfjGVgHzWu6bM8ClFyFTYZdAL2S0/HIeX54dAkr1fkTbG7ha+1VGKwMNIzn6nVb2QMadKM012X/sY1XoHWFMyQVFEDvLwI4VUP0qjXUiGMOKIVX36CjbFo3Ea/N4lJIBqRIS6V4k1mMZdgfmAhMX3mP+meh+86cpouHtT34QcBtwEDml9NCkhPXyd4r1Lqz9RAdqjv88KasTomE6RHc+K0gVL5tlIXgekQYO9UAsBSWGk380roLu0AEgNZFw6LADyKGMs2PTTp0Oqzq0d2wkxF8hmL9aEpUFbQCq/I38/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1196.namprd12.prod.outlook.com (2603:10b6:3:74::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Thu, 5 Nov 2020 13:25:32 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3541.021; Thu, 5 Nov 2020 13:25:32 +0000 From: Raslan Darawsheh To: "Jiawei(Jonny) Wang" , Slava Ovsiienko , Matan Azrad , Shahaf Shuler , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] common/mlx5: free MR resource while device DMA unmap Thread-Index: AQHWsL8e0nCP/E8+tEq1jZtg1JaLfam5jKSQ Date: Thu, 5 Nov 2020 13:25:31 +0000 Message-ID: References: <1603890862-361416-1-git-send-email-jiaweiw@nvidia.com> <1604283748-34904-1-git-send-email-jiaweiw@nvidia.com> In-Reply-To: <1604283748-34904-1-git-send-email-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f31eb40d-9492-44fd-b758-08d8818e4544 x-ms-traffictypediagnostic: DM5PR12MB1196: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:475; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M6Mhzhp9e3DDIH8tEAtVgHvRk0Bx2hwFXVZxF2+xuWaNu5/5IxuzqvzXFOSDsIxG5bm67ptKbcdtx7+vcXYUauQlf2+G6QvZMgM1UBVbrMfe9mJyY5tcvaEkhh+J18/XBqiq14fMA0AUqb3B+KXwpEXtwI7yZkLWYjjJgM0o7SFuZrgXcJ+KfuQ9Wyy1YpBmmXXY7ncPTuE7enOsmGTYarjplzWo98vsl+c0hT+/owZ3is9f/7sP7E6VM4pMHwDoHOfpPEUzaHFVk/u4hwaNj3mtlV2kIQE5kS1gA/xf3yQPoj8c+u1z1XTVygRYPgkK1zvFo7q3cHmP5dGvV+zS0A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(376002)(136003)(396003)(346002)(9686003)(8676002)(55016002)(4326008)(8936002)(54906003)(450100002)(2906002)(52536014)(6506007)(66946007)(53546011)(6636002)(5660300002)(71200400001)(186003)(76116006)(66556008)(66446008)(66476007)(26005)(86362001)(316002)(83380400001)(110136005)(33656002)(64756008)(7696005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: aP5ljAUwnD71s0bRwPk6SD0bAXLZUm2pqSnJ0asGW6E0QZoFcX77QBnIBH0vJDiSdbuZ+gc0+y6z8esdrdUmwZEgeriB98+1pby+SAAqhLerqeB27CNei7ShckknaCelgY335AZxH+QxTRSHXC4gzvnTQEGkEsTaEChOzV6IMuKFHcfS0/IyBNKMxr1qX1ykKdjoXuzJ7HDp1XB5frPPyoyKZmRXxqCiHHMwMf7PnsN+g6QzU23Lt66IXKjErTc11w5RKRPlAGNW7dHWMOCCyfFtUv95BulKe+PuBWh+RQCQ9YyLLBf9c6Srw+uYLJAOhxKVhN5XSaygWHsjVdxkgttalXu0bvf4CZyehdK9u2UmkPXeDkXpTQZfIaxfcNmxLGYcz+48Yej9Dv/Qlh5FFTtJESf74qZ3YCuqHAC3QVE/5VcBOctX0WHRdJcD4tQeKuRoJoeoyI+RRMVp70L17Cs1d8eyntFAB2OmG72nFxS6tkc+a7dPuCULyZqZ55c5VyQQXMCxBIJlTMvbLDablB7WLkvYYmqk4D3ESf8QE8Y7lW/rArXngc7bWz9uuA0W5G/rm3CsO7VVbrAnjs/Ol1hTTMFl0xD476ZqZZsWCVOXJJA0Agaa7W++anBQslnhW2KWKgG5ZS1tlNhOkBvGqA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f31eb40d-9492-44fd-b758-08d8818e4544 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 13:25:31.8826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +4dNDGqovzN44K+/f15niR9S7rYEva7fY50gBOHZWYxOabj2b+PFOT5GbZfP7G38Y5N2XR86CLsTuvimHaik6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1196 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604582737; bh=muvIOccH0mGzC4TouZoZwUWVqVwo8JsJ9+MGao6IGvU=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=WCwBgEQ14PlqydZEtUKCkfu7bVH6DTJp1gdPpeeKvkdbL9w9o2umUq4pK389r/6Do zu5aXYE8vpNtUdRpDLcLcBrJuYv2JG5tF9ka2yyQRKC7Xc42jKEk493yINVQncrm6h ihVZihSiLvDOkKOZWUzuu2GdXFAFlI7QkAwCFyixNPhhw2PR2kvDb/E64/2tWc4lp0 0SA8W8+eVi12ReX9E3QQ1MQgLcoLhn1QQukntMknluslsCf5ZFPUjR7/nvn1baOTlA 2jw8ig13lkYWqI4dB0dQY1413inK/x3hB/bT10+hKYNiQAF3ddH6/JYjuls7yuPzPz /HLIJ7Bt3Jezw== Subject: Re: [dpdk-stable] [PATCH v2] common/mlx5: free MR resource while device DMA unmap X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Jiawei Wang > Sent: Monday, November 2, 2020 4:22 AM > To: Slava Ovsiienko ; Matan Azrad > ; Shahaf Shuler ; Ori Kam > > Cc: dev@dpdk.org; Raslan Darawsheh ; > stable@dpdk.org > Subject: [PATCH v2] common/mlx5: free MR resource while device DMA > unmap >=20 > mlx5 PMD created the MR (Memory Region) resource on the > mlx5_dma_map call to make the memory available for DMA > operations. On the mlx5_dma_unmap call the MR resource > was not freed but inserted to MR Free list for further > garbage collection. > Actual MR resource destroying happened on device stop > call. That caused the runtime out of memory in case of > application performed multiple DMA map/unmap calls. >=20 > The fix immediately frees the MR resource on mlx5_dma_unmap > call not engaging the list. The export for mlx5_mr_free > function from common PMD part is added as well. >=20 > Fixes: 989e999d9305 ("net/mlx5: support PCI device DMA map and unmap") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko > --- > drivers/common/mlx5/mlx5_common_mr.c | 12 ++++++------ > drivers/common/mlx5/mlx5_common_mr.h | 4 ++++ > drivers/common/mlx5/version.map | 1 + > drivers/net/mlx5/mlx5_mr.c | 2 +- > 4 files changed, 12 insertions(+), 7 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh