From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3460A00C5 for ; Mon, 27 Apr 2020 06:10:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7294C1C11F; Mon, 27 Apr 2020 06:10:59 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2046.outbound.protection.outlook.com [40.107.220.46]) by dpdk.org (Postfix) with ESMTP id 1D05F1C0D9; Mon, 27 Apr 2020 06:10:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eFTp+G+8fRxqsi5YannvNVbyUeRRLkJHEBP/EjQIIH0RqsNPFIFQklyOL566L5WpbY/ObsZp+WhPElaoKMtMHGrpJerDPOPcCovJwBV3Fz4Ho9dje2kg/92F5FxNzUM/4USvW2Fk2Qyn6PAVnJdDnPEQSw+62vqHJQZJTeYjoqjm4MIbtPopUOdIjHn/JdTJ5OuXGHg+Blk8M28Ul5T7TOs+RFP/ruUNMyLSqsRuJn0L+juyzz0WoCgs5ThtqncROyE5b0uNpeR6sY2hljCkX8K7InX6SqaRlsrOOji/0N7VWRbonwFDdXukjDV6XC4un/WPsh/wU6nBFWrAHniREg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gM0ULXVeDCdFKH4PSE0HWCapsbcLK2KTUnsHhMN1jmw=; b=XxSpCKDVuDjJGzJzs7KtXa2e/6w1iLyn3sc94K9vptFBFvfy8NNnJs6E6hFtFzyMKrbYWsrzb/99pHk7i5DGL1o27KFGfoL44IHM6mj0lSuiDiGeJGW8lIbXQ3TAR+yifb7of6oxR+Z4hwC2bILg4lk4Q9p4ClFjoKL7wfvmLlVAnPi5GNGkl1Y6KpWxjIHJ93aMSVj765WJ+HialbEz0c8+2+ap4iHiXcLjX/4sQRtxlhwdud0G8Vf00q5NAoe30Rj3pAflPrn4qE0ME12mDUhy1TTWXzLaW00yV/Ar96nui7/Irv0jWbmMojCDxUu2HD6nq5t1EbYTTDi7244QMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gM0ULXVeDCdFKH4PSE0HWCapsbcLK2KTUnsHhMN1jmw=; b=F9Y4VCWCSU40G/lEGOVAu4UaCMuUEb+igEUho/irmFjna0X4GoLdVWWJhubBYgS+rWdyvUKh4zP2rppW+5g8OaapkZqw47UnDJg7cyk9tQFi27H0Me8swYNCm0U6Htd17UQ7LR2jYNN4euELUEdTLelwy6Ny3HXr3nOjYMNmypM= Received: from DM6PR12MB2987.namprd12.prod.outlook.com (2603:10b6:5:3b::25) by DM6PR12MB3722.namprd12.prod.outlook.com (2603:10b6:5:1c3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 04:10:55 +0000 Received: from DM6PR12MB2987.namprd12.prod.outlook.com ([fe80::1500:497a:6cb9:53bd]) by DM6PR12MB2987.namprd12.prod.outlook.com ([fe80::1500:497a:6cb9:53bd%2]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 04:10:55 +0000 From: "Kumar, Ravi1" To: wangyunjian , "dev@dpdk.org" CC: "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto/ccp: fix fd leak on probe failure Thread-Index: AQHWG5UPsxGQ9VXxj0mbwGfJES2j3qiMXCRg Date: Mon, 27 Apr 2020 04:10:54 +0000 Message-ID: References: <1587882975-13960-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1587882975-13960-1-git-send-email-wangyunjian@huawei.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-04-27T04:10:47Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=6055efb3-7d9c-4900-831d-000070123978; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-04-27T04:10:50Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: 07f467ba-e308-4394-b547-0000fad66c7e msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ravi1.Kumar@amd.com; x-originating-ip: [103.117.202.214] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b866d6d9-5a47-4fed-56de-08d7ea60fb5c x-ms-traffictypediagnostic: DM6PR12MB3722: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-forefront-prvs: 0386B406AA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2987.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(186003)(66946007)(66446008)(76116006)(66476007)(4326008)(86362001)(64756008)(66556008)(5660300002)(71200400001)(33656002)(26005)(9686003)(316002)(110136005)(8936002)(54906003)(7696005)(8676002)(2906002)(52536014)(478600001)(55016002)(81156014)(6506007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rwR65Eolt80MvqXwGw6Wl+SfBVhVu2Zm6ENd6W6cfdTPiDMrIWbXWiRKXsKsa65TFVpIg28vSWNHgsFDhbXj9k3xwGrcSKdry0LZKkjF/PO8xCcmwIOo+tQBb+X8R2oCF/sEjhvLa0PLcVHnybCSSR6+lsnGQM+A8oNoXJ0GTIgI6Tb7YxZVWx4/fvTogQoauYTuhdPPfGOqH2nfUKeOa0oDHfF3Yox6OCvivUijVpXCteCEDDw5j37OEggwUK4WH3AdTjQZu9t952DjO2YUPOWG88m7dFxbXj4D3UCuBS/H2KdPqbmxYZ9Timd9/m5oUwFO6cEdO1PYA3eXfpX9GcyVf13aOT5phTuxUvo1N6B5EUbPD3KrScYPWVakn39pzWQpBS4HBXL6AfhxWyGd/GSsHODrdzx10BtxaYAtC+ntj9g9gU2s+ijL6yBIvS9N x-ms-exchange-antispam-messagedata: QAI/bnHcd5Cd+JBscvemrWmzuxRJERYXaevqlpP2D3rCv6kgtHmrYLQgvdSc88cWCE6LBeUb7YoX9W/XrZ0h0m6JnY4fETREBQBFbFIMGXxAyFznBRFb79KRa7fVDfYtjLPhdFBTr9ntnFr8MgIc0LBXlNis8SbzGN2NRoQ9FfZg/6OcL6Uk3ykiTTLCBvaWlt01ioCx/s0FxHIdrAXl8NlAVHNjaDRVbpYS+gPHRYzL+vVx/el+gqNao/zdhVGWTecsG8f1mKvqyEgDzO7R56Ovs1gavXszwuNxyFmFKmdM/wVHJAt8EVTif0zTHzHgZcz+ZTUsvtVvL8mHOwU3BKDZcoCkSSJsyIb1w4AeLgFFWpsjn72LDTMp4yXfUnU3cbfhKQxNqmNopo/v7FU4lTRdvvZrK0l03XKs2Xwlvk2SBQjAViPblTZ0jZ9DS+BKwwbPDXqBRFvMM1NrrU5HYcDvRpI19pFKimENoLcwKMOxHxYlXwzY3oRIvZ9W6d56OG7OY13HLXquY8+9z1ahyVJiNr6IvjjEJT5C94qGk2QhHQI+ZqoUN9HPIOodageSsJku6iO8DyT47X2ha907tcm+vk2fOJyYF2dL27AzkE0KkQ+xnldr00obqmh589vMX5KmAW5Qb/r+ewqhAJ+u9MqCiFp9DQyIGR1vlvAkCDkdmxLZzVqIJQqvwTnDs4KZXM1cW+U5f5G6YvGDwfndH8zDi3Wooqki38hIzxOZFz692PHu/4IGcgRgJhEwseZZSZst1Jf1BluvWwomOWm0svgBAPDa8/U+y4mkE9+hAyikd0Z0qEjR1+lHeRbxCTky x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b866d6d9-5a47-4fed-56de-08d7ea60fb5c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 04:10:54.9748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eyXRUXTIVlgorzlbRRTbt52si3Juv3tRkWwRFobJ71xWDgockD4IsKcYOYYoIKLc49TUeK34XfQBGt6br16v7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3722 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/ccp: fix fd leak on probe failure X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" [AMD Public Use] Acked-by: Ravi Kumar >-----Original Message----- >From: wangyunjian =20 >Sent: Sunday, April 26, 2020 12:06 PM >To: dev@dpdk.org; Kumar, Ravi1 >Cc: jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang ; stable@dpdk.org >Subject: [dpdk-dev] [PATCH] crypto/ccp: fix fd leak on probe failure > > >From: Yunjian Wang > >Zero is a valid fd. When ccp_probe_device() is failed, the uio_fd won't be= closed thus leading fd leak. > >Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") >Cc: stable@dpdk.org > >Signed-off-by: Yunjian Wang >--- > drivers/crypto/ccp/ccp_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c i= ndex 80fe6a453..7d98b2eb2 100644 >--- a/drivers/crypto/ccp/ccp_dev.c >+++ b/drivers/crypto/ccp/ccp_dev.c >@@ -760,7 +760,7 @@ ccp_probe_device(const char *dirname, uint16_t domain, > return 0; > fail: > CCP_LOG_ERR("CCP Device probe failed"); >- if (uio_fd > 0) >+ if (uio_fd >=3D 0) > close(uio_fd); > if (ccp_dev) > rte_free(ccp_dev); >-- >2.19.1 > > >