From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5706DA0093 for ; Tue, 19 May 2020 15:20:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 318CE1D979; Tue, 19 May 2020 15:20:10 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2051.outbound.protection.outlook.com [40.107.94.51]) by dpdk.org (Postfix) with ESMTP id 1B62E1D979 for ; Tue, 19 May 2020 15:20:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/wTFonfaXJ2ygvtsixHNMS+N2I85MqxmgnArMS+7VEPFCAiJ5cfRAVj3I2n48u0yWbbfv657OOR06pfGBrxPzN+mVfaX37wR0EUAgvEdG7zuaY32imCfH4a+ZQbyBQkUi7vZoDwr82slUSIOwxCaRhLKfLWSTlYgG9K0tlF/PSHvpykIA22AlCUjoeBNrA0T7y6JOH04wtprw6cTOZ/Ytgo9GpcglR+vsyFY8IkRKS1KQtXh6d9uYIPVfQ8iZXZONEiAtSKMXd2e8PAQa0041P7GuAgNtbs3sJWGhIRZO/vJE4edFbWURKaY+y/7OacYgtxchkSyn+A3+B5jfQSOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xA3OAR0zoIMi521Acmc/x2ODPjgVHVWb7Or4ZCtG53E=; b=GXQDQ8tzjRHUS7kMEPQKXK+bwbKDBAE6HCBKCD6uxCdrKnOPZr1gPc7JUhp9ukolX5TMEgqlXlYCOu8SI1aovpnAnypH80tCLlshZOua+NIQsnswa4v40JmYwWMCN17h4yhCLFZbFn6d+pYULSRZ5pgDdT5xN2yQs4kq0tQtDdTzU20ZRKjwKnO4nd+hjhcHfgfITf4TWgpJc/0Jo7dcycvQCYFFfRGQiOrPeaU62aGl0O2WZ9BALlyJpk/Y8Fe+EOkn2y7/MXpN9UBnFxFmiqyrlJxUZr7lBhOhpl2Nxv78PxZ/1KFVeMdnHx1XQ3msalv/m8qguYG+jgjU8OCO1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xA3OAR0zoIMi521Acmc/x2ODPjgVHVWb7Or4ZCtG53E=; b=O7t2dhHwJ3Pxr2WB5ojyHziVOQh2NLeWRb44DlQpbhGAxv7Ixt7stbkM5LPdlIx4zuXrEDOOA52ykC/pXlBNoAHjAm7XWcy3qVxYf9dv0hSI2zdk6YIJjzExG6yc/sk8Oz5LuHGBGROMkJ9sDq94hgyjWCbU3GGJhon9tv0Do0Q= Received: from DM6PR12MB2987.namprd12.prod.outlook.com (2603:10b6:5:3b::25) by DM6PR12MB4482.namprd12.prod.outlook.com (2603:10b6:5:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25; Tue, 19 May 2020 13:20:06 +0000 Received: from DM6PR12MB2987.namprd12.prod.outlook.com ([fe80::1500:497a:6cb9:53bd]) by DM6PR12MB2987.namprd12.prod.outlook.com ([fe80::1500:497a:6cb9:53bd%2]) with mapi id 15.20.3000.033; Tue, 19 May 2020 13:20:06 +0000 From: "Kumar, Ravi1" To: "luca.boccassi@gmail.com" , Yunjian Wang CC: dpdk stable , "Somalapuram, Amaranath" Thread-Topic: patch 'crypto/ccp: fix fd leak on probe failure' has been queued to stable release 19.11.3 Thread-Index: AQHWLd+AAkk4PUFa70u3aWmmMwj0uqivZJBQ Date: Tue, 19 May 2020 13:20:06 +0000 Message-ID: References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> <20200519130549.112823-174-luca.boccassi@gmail.com> In-Reply-To: <20200519130549.112823-174-luca.boccassi@gmail.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-05-19T13:19:57Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=a7230338-5d4e-446c-90e6-0000085d4a00; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-05-19T13:20:01Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: a14ee26f-f4fa-4f1f-bb7e-0000eb9ee448 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=amd.com; x-originating-ip: [103.117.203.175] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4ad5d24b-52f4-45c3-8650-08d7fbf75925 x-ms-traffictypediagnostic: DM6PR12MB4482: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +Cw/ArlQa1Oggs8LTzmuZEZM4Xajc98/0VC1Zb7iInc3Qjxaug49yT6Ek7fQDyI+oCJquPrKjNiydsXIoSiNwMUh17TYHPkdMHfgK6XbFpvY0VO1roQDh1I9s8HCT0SwFgoD6i015Nu3B+iNIMoMuKXUuAHq5N+PbThBxuqydwl1hJtvW9TyyPXXF1NzZjXpfiPfJtnQA2RJEEvmqbpoPzElomDnAFi+cj+W7LDt4bpCBaNt5pFh98EQGib7VOF7jCqI73oCwxVm5gdUX0Zrdp+Q2S1rHIXHVIuL4c9C7YPYphlpM3Yul44wf9shH83g8WARkN2szEGycHP83Vjr+12TyFGliurW5uYRhypNX608zt7zrtDt9ITV7H4ApKIX48oXevWj1U1f3Tr2b4kHJU2yMRx3HuCO3hbqQAfk+QZNDD9dp/y4vwXPIs6eQfg+FBlOHD551BNInzJTL/QOR6p+ynJXnpumzEdW8Cptq0gjGu1XEulQxo5gWSXrtuuqGtYTOSpBXnJq88TfuaY8EQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2987.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(186003)(5660300002)(33656002)(26005)(54906003)(110136005)(8936002)(2906002)(8676002)(53546011)(7696005)(316002)(6506007)(9686003)(76116006)(66446008)(64756008)(66556008)(66476007)(66946007)(4326008)(52536014)(86362001)(45080400002)(966005)(71200400001)(478600001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: lTcmSo+5bpD1p/7QwcD6zWca7Un3gpWnzX8vL05fEU3kw5XR0y5034+B8CL1hVzfGBttLIGcoaV/QL//pN7x2/qLG0FthiHuNGL5s78x5k3X5+a3gWXydkyuGr7vRGZCoEtcB1orqPCCsJFoiDQDSRlv7frkots3ewi/1oAj/MwxZA8Y26JetLNENvmhTM1qsK5GXH3ZDwcd3s2q0uKNyp9H7VqAi85UBe1j5dzaperjG/xv3xUYqQD5WfbIUOezsz8XSVES7pTZDXjCAD5WTmM5imHGylYW70bBNKZzyD1kPLKWwAIdTQ76Z0jzWpXsaE3+Hvr3P+HQ6mk9PmIQkT33IpSehyUjLoqCG/qDNF/BKUgqikvKbZD4OU0LgF+XL7yeP6Xus1dEa323QkcIdltdATrMmaKV6w8BEMOj4LvArjQuNx1wCbm/cuyladn2UH7kBEUTmjfA6UDnbSDBu0HuQSrnEu0BB2LKfeGhsi5M65KTn6UnODYMJzE/BmVE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad5d24b-52f4-45c3-8650-08d7fbf75925 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 13:20:06.5510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eFpGSplDSapPokpVvgCMsYDGcpF25nFv/YGjT+6cevKRqmdYQWHNj5yVePIpK78MIitVKKRWol28DXdHACFxgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4482 Subject: Re: [dpdk-stable] patch 'crypto/ccp: fix fd leak on probe failure' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" [AMD Public Use] +Amar=20 -----Original Message----- From: luca.boccassi@gmail.com =20 Sent: Tuesday, May 19, 2020 6:35 PM To: Yunjian Wang Cc: Kumar, Ravi1 ; dpdk stable Subject: patch 'crypto/ccp: fix fd leak on probe failure' has been queued t= o stable release 19.11.3 [CAUTION: External Email] Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to https://nam11.safelinks.protection.outlook.co= m/?url=3Dhttp%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable&data=3D02%7C01%7C= ravi1.kumar%40amd.com%7C7d732966a80441d4cb2608d7fbf6a1f0%7C3dd8961fe4884e60= 8e11a82d994e183d%7C0%7C0%7C637254909006890050&sdata=3DBQ8zWW2d9itJUf%2F= BGPHtXaNLiskAJ1ks1vfSdZ%2BeNlo%3D&reserved=3D0 yet. It will be pushed if I get no objections before 05/21/20. So please shout i= f anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the= patch applied to the branch. This will indicate if there was any rebasing = needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was corr= ectly done. Thanks. Luca Boccassi --- >From 9b91b991b69c8f44c194259e42a4197261c06593 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Sun, 26 Apr 2020 14:36:15 +0800 Subject: [PATCH] crypto/ccp: fix fd leak on probe failure [ upstream commit 4f429be4c09a00ccc5cd13cfb14a11f90958ac74 ] Zero is a valid fd. When ccp_probe_device() is failed, the uio_fd won't be = closed thus leading fd leak. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Yunjian Wang Acked-by: Ravi Kumar --- drivers/crypto/ccp/ccp_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c in= dex 80fe6a4533..7d98b2eb25 100644 --- a/drivers/crypto/ccp/ccp_dev.c +++ b/drivers/crypto/ccp/ccp_dev.c @@ -760,7 +760,7 @@ ccp_probe_device(const char *dirname, uint16_t domain, return 0; fail: CCP_LOG_ERR("CCP Device probe failed"); - if (uio_fd > 0) + if (uio_fd >=3D 0) close(uio_fd); if (ccp_dev) rte_free(ccp_dev); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- - 2020-05-19 14:04:51.623305330 +0100 +++ 0174-crypto-ccp-fix-fd-leak-on-probe-failure.patch 2020-05-19=20 +++ 14:04:44.516653810 +0100 @@ -1,13 +1,14 @@ -From 4f429be4c09a00ccc5cd13cfb14a11f90958ac74 Mon Sep 17 00:00:00 2001 +From 9b91b991b69c8f44c194259e42a4197261c06593 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Sun, 26 Apr 2020 14:36:15 +0800 Subject: [PATCH] crypto/ccp: fix fd leak on probe failure +[ upstream commit 4f429be4c09a00ccc5cd13cfb14a11f90958ac74 ] + Zero is a valid fd. When ccp_probe_device() is failed, the uio_fd won't be= closed thus leading fd leak. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Ravi Kumar