From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B588BA0A05 for ; Tue, 19 Jan 2021 15:04:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A112F140E8F; Tue, 19 Jan 2021 15:04:52 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 1789B140E73; Tue, 19 Jan 2021 15:04:46 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 19 Jan 2021 06:04:46 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 19 Jan 2021 06:04:46 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 19 Jan 2021 06:04:46 -0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 19 Jan 2021 14:04:45 +0000 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 19 Jan 2021 14:04:37 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 19 Jan 2021 14:04:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUUmTgcIPRHW6bfb4H69XQkVPFbNpgaIKYkiB82GnvNDVtCamWvCsm+K3oycrgrgQIi73uvlGUsmNqiszREiQIKsE/V2erOd7MQgdBPKh8I8ENYABrnuQn4cmqiKOL7igGtYNSBWTjVhuQF1+7Nmg2t3L4LInc/d487cnu6MtzAG8wDkoSspaIzSot0miaiHquOdt3LsoyTy0oSa/DISpRZXws+8EfBOTIgNAWQwnj/VnBwgDKJJyTLYS/GyH0yuh1m7cB06Jma6ENRVuxpI6Y+r1WxgKyGJGyiIOMsmAW+AFY9HMlorr+GHRU34swekMWlL0bqiJdYrmCJXk84yrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NPeYvlpeAi0iryBcCNbkIwEBXcQu8ychVn14ZhYNwzA=; b=m0vuHictDyVsICPEuLSqA1atmarFMchTPiPdhi26/X0nvtuSjZeVWbVHa+hwwUr2+AcbuE0sM1GCS9nB/enYxMl25bFYDPK0RRaPAJ5SCGdSlGteynvlrI0NFXARHnTzs/53fic2AuDJfkGgyLp9S12zjTYYRIx0SZHhP7K0q/iQSRM5rKpUwAme1Tm4fHLmQpJQ8pJCrnAX6+rB1pf1wYGvaJ88AKaMVgtAFJE8id5L10kb972zwCPhxope5Fxr62CTbljI6gLCmcC/TqhI17GVLrL3FA0QE6wJhZFEuGDwvNUrKHv106Jj+w1sDvh1bw4lQ+K3wXAb6mFozYVsSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM5PR12MB2568.namprd12.prod.outlook.com (2603:10b6:4:b5::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Tue, 19 Jan 2021 14:04:34 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a%5]) with mapi id 15.20.3763.014; Tue, 19 Jan 2021 14:04:34 +0000 From: Slava Ovsiienko To: Olivier Matz , Ali Alnubani CC: David Marchand , Ferruh Yigit , "zhaoyan.chen@intel.com" , dev , Andrew Rybchenko , "Ananyev, Konstantin" , =?iso-8859-1?Q?Morten_Br=F8rup?= , "ajitkhaparde@gmail.com" , dpdk stable , Ajit Khaparde , "Alexander Kozyrev" Thread-Topic: [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free Thread-Index: AQHW623VmsTXVlWnIEigt6XNenzAZ6otrogAgAD11wCAAFyesA== Date: Tue, 19 Jan 2021 14:04:34 +0000 Message-ID: References: <20201104170007.8026-1-olivier.matz@6wind.com> <20210113132734.1636-1-olivier.matz@6wind.com> <20210119083226.GA2855@platinum> In-Reply-To: <20210119083226.GA2855@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.163.75.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d655f1b0-b90b-438d-d5b6-08d8bc832657 x-ms-traffictypediagnostic: DM5PR12MB2568: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AhoNGsNIlTx7JCvmKjWEnysRXjlyOv1thy2dzJmhw6oHY7iwuv1yePcyzjnRzu2PTByMYYJVQLTK6LOlb533f7xzRgGgjAWwxN6Z6yKnN2BCODN3jRJPY+zcPxkFBq4+7uPzX8Clc/cP3J5Yr0C1tiMeFqzp0/ePojidEsdcnsLn2Vwq7RoWGZKWG/t2gVZaEgaURXwc2Dfnfn6bDt2V8wK/2t7p5mKwyZa2be0k3bGW46K53oeZ+MqdzaY41TLCdJzyQYE8NN4shOAfQq1zdzFIlkXxlHG4SnYUVDQfccG0PO0xW+N+j2Qniqb3+bYkFmEiXRLv9mxX5z0I5XNxOp0lyzQyxeTH/SZAcYFzL2zWN2F3QYH+QGAHoCtxgwmm8bPpJW2hhysOW5nGEXdxy4cSrMe1my4DUCXzojRI4a8YK/bqCDDqQHSvJt/HHS9MYlDxadQNwQ5zEETsV3nSFw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(55236004)(86362001)(45080400002)(2906002)(6636002)(110136005)(54906003)(316002)(53546011)(478600001)(7696005)(6506007)(966005)(107886003)(76116006)(66574015)(66556008)(7416002)(26005)(186003)(83380400001)(5660300002)(33656002)(8676002)(66446008)(66946007)(71200400001)(64756008)(66476007)(55016002)(4326008)(8936002)(52536014)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?KNLs1zKlnLzzNyaE4N49CErXUVTjZ2NjVPeT/HBI5hSWPZNiCJD965CCe9?= =?iso-8859-1?Q?6L27mYJrGTSVmH1j4DQ4y3608Mwb866F1REod1tsTIJazl1KERUoH2Go6y?= =?iso-8859-1?Q?5WTPE4HycVD3+XFxzXsbZBfJj1ZIY3MSK+7FrFLNVwE+YZ+W7iZhc08BxU?= =?iso-8859-1?Q?qN7N9RMUU0OzYdDo4zTLz2+LxEwdYpfMUoG3kBMSTyeoFmpNuKFcHpZ4lx?= =?iso-8859-1?Q?g7Y58lVQ+mcpIU5L3x5VcI9d5OM68olVM4xjA6LaCkCKILhflJ36OSsMxy?= =?iso-8859-1?Q?tmll22+pXxVx0slmJwr8qB4CZo8Db8Ay4Ou4hoBZwnmGUVmsKubn5QRRTQ?= =?iso-8859-1?Q?tBst1Hz363clHklPG7B+A3i52S6XPh9opaUZ8w7uxLz5c5I2O8E1aZoNmy?= =?iso-8859-1?Q?3UOOhR5SoJIVIfK7uDgybwwiiMxQ543iXQRhWadWbyf54mHYV5xN62k0m2?= =?iso-8859-1?Q?0Wl+NSQfc9dyRg9CO5/tpq16ksSdDlHxnIC/T+bWCpGFtIs5k6R2ii8CZE?= =?iso-8859-1?Q?TOs5mufvhtRFRoXUF4Ee+IVEvphcmA23+McHfJDD4LyQnSrXeC6IBwU01a?= =?iso-8859-1?Q?7EueO0vv25B3Cnm2VLra6gVT2AqFEEsHOIl1T/977qT6nzGKPqqr/vkfaa?= =?iso-8859-1?Q?ns6cxiDPa6UtGYXw24mUn0O++MTIJHtm3pFZGxF9+KDOWI7mZS/H59lKw4?= =?iso-8859-1?Q?PHjxRPjnOVWpEd69k70VsfxtKLXLigzZnQ7DFEa+kzqTH34qmfX7LaDKni?= =?iso-8859-1?Q?FZsTJG2XnxDFkcvwIJPnn74O2sMPiYjKquL7iebzKQ9dayrp5jfo6Bg+F4?= =?iso-8859-1?Q?dWJVnpvJopMiieeBG+X5bL+xTsTWfdEuwWruwffjFjLtUI81FT1h3LLRIi?= =?iso-8859-1?Q?VWlznZ2ih9YxqoB/FKNLJx6QzL7PxFewCITSaprQRG4ccTKTbhEFFQo6CL?= =?iso-8859-1?Q?dAHWM9STbswzt+HIhiCmNcD2z4eJnOAdqZK70wXiTx2RgKNnklHi6L4aBQ?= =?iso-8859-1?Q?TtiszH4aydlma9cnM=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d655f1b0-b90b-438d-d5b6-08d8bc832657 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2021 14:04:34.2373 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZZCvpzfJPUZvJx6/gpZbgiy2CfcEtPrTNYI9WtEtCDMVHvqY1R1fP5cBvU9aSGxiiqN2nVykwWPDxRUeEH1WHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2568 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611065086; bh=NPeYvlpeAi0iryBcCNbkIwEBXcQu8ychVn14ZhYNwzA=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=GjT0YpzH1k01shFRfin85xXJEfRDltmn6tTK6B6mfFufO1PcQi9Taq9Fz58Z2NefA Z4fWKViYykDV8S+ZTJqdwKlIxa7lUzGNLb7JZBKZhh3mpPJsxPkZShIBcQV7I+XZ/k WNMjDXV7lHPnIi2sRhVTZtB4/2ogXV2AVbeBVBfbJJ//3aj79c2WzQtY/fLAGUtYxT Q6RU13yzx5+m5rLB9FiSyzgva+yLkZEWG30nFouPOU3mCNefHmPsZGI6rQ7etd4ynO 4HqCB1kghfOx3L0w/ae1DPfEAiafHNNIvdhJ+R7SFjQevun/UJJlCw1pgSa5yi4iWm 3YayLaGsv/AYg== Subject: Re: [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, All Could we postpose this patch at least to rc2? We would like to conduct more= investigations? With best regards, Slava > -----Original Message----- > From: Olivier Matz > Sent: Tuesday, January 19, 2021 10:32 > To: Ali Alnubani > Cc: David Marchand ; Ferruh Yigit > ; zhaoyan.chen@intel.com; dev ; > Andrew Rybchenko ; Ananyev, Konstantin > ; Morten Br=F8rup > ; ajitkhaparde@gmail.com; dpdk stable > ; Ajit Khaparde ; Slava > Ovsiienko ; Alexander Kozyrev > > Subject: Re: [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free >=20 > Hi Ali, >=20 >=20 > On Mon, Jan 18, 2021 at 05:52:32PM +0000, Ali Alnubani wrote: > > Hi, > > (Sorry had to resend this to some recipients due to mail server problem= s). > > > > Just confirming that I can still reproduce the regression with single c= ore and > 64B frames on other servers. >=20 > Many thanks for the feedback. Can you please detail what is the amount of > performance loss in percent, and confirm the test case? (I suppose it is > testpmd io forward). >=20 > Unfortunatly, I won't be able to spend a lot of time on this soon (sorry = for > that). So I see at least these 2 options: >=20 > - postpone the patch again, until I can find more time to analyze > and optimize > - apply the patch if the performance loss is acceptable compared to > the added value of fixing a bug >=20 > Regards, > Olivier >=20 >=20 > > > > - Ali > > > > > -----Original Message----- > > > From: Ali Alnubani > > > Sent: Friday, January 15, 2021 8:39 PM > > > To: David Marchand ; Olivier Matz > > > ; Ferruh Yigit ; > > > zhaoyan.chen@intel.com > > > Cc: dev ; Andrew Rybchenko > > > ; Ananyev, Konstantin > > > ; Morten Br=F8rup > > > ; ajitkhaparde@gmail.com; dpdk stable > > > ; Ajit Khaparde > > > Subject: Re: [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free > > > > > > Hi, > > > Adding Ferruh and Zhaoyan, > > > > > > > Ali, > > > > > > > > You reported some performance regression, did you confirm it? > > > > If I get no reply by monday, I'll proceed with this patch. > > > > > > Sure I'll confirm by Monday. > > > > > > Doesn't the regression also reproduce on the Lab's Intel servers? > > > Even though the check iol-intel-Performance isn't failing, I can see > > > that the throughput differences from expected for this patch are > > > less than those of another patch that was tested only 20 minutes > > > earlier. Both patches were applied to the same tree: > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fm= a > > > ils.dpdk.org%2Farchives%2Ftest-report%2F2021- > January%2F173927.html&a > > > > mp;data=3D04%7C01%7Cviacheslavo%40nvidia.com%7Ce2d18a8563fb42dfaba40 > 8d > > > > 8bc54c83b%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63746641 > 96385 > > > > 80374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu > MzIiLC > > > > JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DVGvj%2F5GcAOxof6C > mlZkq > > > KXKOL52GctXcuL5RJXr1y8g%3D&reserved=3D0 > > > > | 64 | 512 | 1.571 | > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fm= a > > > ils.dpdk.org%2Farchives%2Ftest-report%2F2021- > January%2F173919.html&a > > > > mp;data=3D04%7C01%7Cviacheslavo%40nvidia.com%7Ce2d18a8563fb42dfaba40 > 8d > > > > 8bc54c83b%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63746641 > 96385 > > > > 80374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu > MzIiLC > > > > JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DXSirRbm5G0WwfxySe > b0ALp > > > owVosqoY6Nlv4UZCd1CZM%3D&reserved=3D0 > > > > | 64 | 512 | 2.698 | > > > > > > Assuming that pw86457 doesn't have an effect on this test, it looks > > > to me that this patch caused a regression in Intel hardware as well. > > > > > > Can someone update the baseline's expected values for the Intel NICs > > > and rerun the test on this patch? > > > > > > Thanks, > > > Ali