patches for DPDK stable branches
 help / color / mirror / Atom feed
* Re: [dpdk-stable] [PATCH] net/mlx5: fix the size of tcp flags for modify actions
       [not found] <20210428091259.23278-1-wisamm@nvidia.com>
@ 2021-04-28 11:23 ` Slava Ovsiienko
  0 siblings, 0 replies; 4+ messages in thread
From: Slava Ovsiienko @ 2021-04-28 11:23 UTC (permalink / raw)
  To: Wisam Monther, Matan Azrad, Ori Kam, Alexander Kozyrev,
	Raslan Darawsheh, dev
  Cc: NBU-Contact-Thomas Monjalon, Wisam Monther, stable

> -----Original Message-----
> From: Wisam Jaddo <wisamm@nvidia.com>
> Sent: Wednesday, April 28, 2021 12:13
> To: Matan Azrad <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Wisam
> Monther <wisamm@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the size of tcp flags for modify actions
> 
> From RFC the size of the TCP flags is 9, while the defined current size is 6.
> 
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: akozyrev@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
> Reviewed-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] net/mlx5: fix the size of tcp flags for modify actions
  2021-04-28 10:29 Wisam Jaddo
  2021-04-28 11:28 ` Slava Ovsiienko
@ 2021-05-03 12:23 ` Raslan Darawsheh
  1 sibling, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2021-05-03 12:23 UTC (permalink / raw)
  To: Wisam Monther, Matan Azrad, Ori Kam, Slava Ovsiienko,
	Alexander Kozyrev, dev
  Cc: NBU-Contact-Thomas Monjalon, stable

Hi,

> -----Original Message-----
> From: Wisam Monther <wisamm@nvidia.com>
> Sent: Wednesday, April 28, 2021 1:29 PM
> To: Matan Azrad <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the size of tcp flags for modify actions
> 
> From RFC the size of the TCP flags is 9, while the defined current size is 6.
> 
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: akozyrev@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
> Reviewed-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] net/mlx5: fix the size of tcp flags for modify actions
  2021-04-28 10:29 Wisam Jaddo
@ 2021-04-28 11:28 ` Slava Ovsiienko
  2021-05-03 12:23 ` Raslan Darawsheh
  1 sibling, 0 replies; 4+ messages in thread
From: Slava Ovsiienko @ 2021-04-28 11:28 UTC (permalink / raw)
  To: Wisam Monther, Matan Azrad, Ori Kam, Alexander Kozyrev,
	Raslan Darawsheh, dev
  Cc: NBU-Contact-Thomas Monjalon, stable

> -----Original Message-----
> From: Wisam Monther <wisamm@nvidia.com>
> Sent: Wednesday, April 28, 2021 13:29
> To: Matan Azrad <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the size of tcp flags for modify actions
> 
> From RFC the size of the TCP flags is 9, while the defined current size is 6.
> 
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: akozyrev@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
> Reviewed-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-stable] [PATCH] net/mlx5: fix the size of tcp flags for modify actions
@ 2021-04-28 10:29 Wisam Jaddo
  2021-04-28 11:28 ` Slava Ovsiienko
  2021-05-03 12:23 ` Raslan Darawsheh
  0 siblings, 2 replies; 4+ messages in thread
From: Wisam Jaddo @ 2021-04-28 10:29 UTC (permalink / raw)
  To: matan, orika, viacheslavo, akozyrev, rasland, dev; +Cc: thomas, stable

From RFC the size of the TCP flags is 9, while the defined
current size is 6.

Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
Cc: akozyrev@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
Reviewed-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index d810466242..43e929b892 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -1366,7 +1366,7 @@ mlx5_flow_item_field_width(enum rte_flow_field_id field)
 	case RTE_FLOW_FIELD_TCP_ACK_NUM:
 		return 32;
 	case RTE_FLOW_FIELD_TCP_FLAGS:
-		return 6;
+		return 9;
 	case RTE_FLOW_FIELD_UDP_PORT_SRC:
 	case RTE_FLOW_FIELD_UDP_PORT_DST:
 		return 16;
@@ -1688,10 +1688,10 @@ mlx5_flow_field_id_to_modify_info
 						     (32 - width));
 		break;
 	case RTE_FLOW_FIELD_TCP_FLAGS:
-		info[idx] = (struct field_modify_info){1, 0,
+		info[idx] = (struct field_modify_info){2, 0,
 					MLX5_MODI_OUT_TCP_FLAGS};
 		if (mask)
-			mask[idx] = 0x3f >> (6 - width);
+			mask[idx] = rte_cpu_to_be_16(0x1ff >> (9 - width));
 		break;
 	case RTE_FLOW_FIELD_UDP_PORT_SRC:
 		info[idx] = (struct field_modify_info){2, 0,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-03 12:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210428091259.23278-1-wisamm@nvidia.com>
2021-04-28 11:23 ` [dpdk-stable] [PATCH] net/mlx5: fix the size of tcp flags for modify actions Slava Ovsiienko
2021-04-28 10:29 Wisam Jaddo
2021-04-28 11:28 ` Slava Ovsiienko
2021-05-03 12:23 ` Raslan Darawsheh

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git