From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED5DFA0C47 for ; Mon, 12 Apr 2021 08:37:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D76BD141551; Mon, 12 Apr 2021 08:37:02 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2082.outbound.protection.outlook.com [40.107.237.82]) by mails.dpdk.org (Postfix) with ESMTP id 27938141523 for ; Mon, 12 Apr 2021 08:37:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KSarbAtOu6PBMtrg3ZwtP8e2TI8aP89+tGDamhk59pdG7mvLUivyYUuqO/2Frx1YqLTaR8KYA9HXxYerupXewdyACQrZgWyukmH9VqSnSY/p3LNrae81URhv25a3dKgJoPiRvMFyTJSp9qAMpIV692xP6TBTJ1d1TCeCO18wlRVyJfkMLllxGviXUt7u3E2i9aGSs+ix33yvFiCE6J3Tu7aPlGlWCb68UC5lNa7hMrQI93rU1HHDo6957ZpRBR0eEvcpryHc7cbR9VQi66bfe0TDaYhlPhM9UCZLHzPQdzdOS5+1eTcBa7o7RQ3y+fUUZFVYC7M5C7I48wpm1Fua+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qYklspwZcu9jxa15K92fgV+qDJ+fNiA5DxpMeqHdSC4=; b=h6/AuwoyaqsVTbreQxUyqOlChjVmexfSLAf/+fzmbhjCS5mgKYcKHodn8oj2XSr9m9R7YafAGmcF/S8d2/yjt5F0ReDdyhXvWTOGNTSsRIkf86dKgNgJnwowwEBolQ17UNFFEtPnF31vTkBwY/118IejiKcB3tIPf/i3+4mR/luZhRpkvBaYcMuAdhnR0MliknuvlnyKfkVxLBqTmqWbGFd/PiPHRTOpOZBztn7kgdSk0taRmg9g1qV+mXyknwmTxuhCBDlaytl7LxPFjUjyBH9YfgrG8w2yRjNyLGrcLeIbaYMbByb2/7RdltGBEtg14YbTDF16Q8JlX8oKM34N5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qYklspwZcu9jxa15K92fgV+qDJ+fNiA5DxpMeqHdSC4=; b=SaIZ+p/z4WcugH6JEH2lg7+a2ymyuTKAaFbyvXcbIMdgQdEaQqm9jAfobxM/3BhbZ4/AzJIS6LokGCJdXo+Wy99KJDB4a9bEJ+MvOQMIfNEkzFK7ZP8hwhem0s7I6zgWJdS3jiScieYhyLsLqsUZCWwd+j6tKq77VJqMNxsJr9MJhV94hJ6fFjwLcayxS6KA1BTjODYPFMH8EPR/yt8dsNQkBV4ekokyhZ65bALOGNUisc8LhVyF91tXFLDV5eiyHteLIAX+Wwb3XR3k12R6Q0pnyIICj4ig9FnInISsojKM5cLZ4SqMoMNR00wwBUw+wmVQR1xm8RLtFyyIs8Ce2w== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB3036.namprd12.prod.outlook.com (2603:10b6:5:119::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Mon, 12 Apr 2021 06:36:59 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::20f7:11fc:9d46:9258]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::20f7:11fc:9d46:9258%6]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 06:36:59 +0000 From: Slava Ovsiienko To: "Jiawei(Jonny) Wang" , Matan Azrad , Shahaf Shuler , "Jiawei(Jonny) Wang" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix resource release issue for mirror flow Thread-Index: AQHXLTyOiY3ldHGMyEO0ycstC3Ety6qwceDw Date: Mon, 12 Apr 2021 06:36:59 +0000 Message-ID: References: <1617971608-89460-1-git-send-email-jiaweiw@nvidia.com> In-Reply-To: <1617971608-89460-1-git-send-email-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0d2c0a7-9aad-45f7-b040-08d8fd7d601f x-ms-traffictypediagnostic: DM6PR12MB3036: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uAxmg5hun/OMzj4T5jUIIbly2gzW+OE7lroPx3NMGxJQ1rKYPFkofuO3cccpmsyTjQComxmqBa0MOJf2LCV23wU+BoeC+yCQkY6au4C/G3lgku7vqJsumP9jaDcarIxV+dr4oBaKodDR5w789EMFUNchtB7Vl5OdAefNx6e2NnVUPJl+SW8B4ElVgkh1CLI01kuPFiDxuKbdFjWEXYnAnyL5Q9/Gg5qPCPYSFNPKV5Uji6sFYCFld/G9NOFeJR1SkdzJkwLwhCUkwfNGargh8BirMIw1ZJcVORh1TM8xFnlvelCnI0NDRrEjb3FfucL/QKSxrS0BZdtU4GPGFcWrGgIhW+6viX8wCCmugpxdhqRusp55Awisod8q0vTsHy5UCu7L8zkADABLg3Fl5HO05MVDU1CsG0NLsJmgVCGH4P/unJh3jlYhg4SOdMnWGcKFwytSHcEQt0kX+K8Sqnbd++Sp+CjNFtm/L4HrPpNy0PneT2xDZ9PJO/b51j/ec2m0vZmrffG9T4BCJ6orTOULcbwfn20h2eNGKUYoCFMWuDjQldk4mIhcLe4PaGWFFnpB2Gq1oiNQGe/RzQhy5YaDNi+Lqc7cQ6DjBOdLBzEb0JA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(4744005)(38100700002)(33656002)(8676002)(2906002)(9686003)(26005)(7696005)(6636002)(53546011)(6506007)(86362001)(55016002)(8936002)(316002)(64756008)(71200400001)(66556008)(66446008)(4326008)(52536014)(110136005)(5660300002)(54906003)(450100002)(76116006)(83380400001)(478600001)(186003)(66946007)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8ShrKVqb+v/5y3QqiTl4HQZ4ghdU6rjV6ED3PYkzKxBIaSZdLhO/wty7GTaE?= =?us-ascii?Q?GoiGAAPIVSedOtfW2kF4T/NmcrEiw1COBS2yaDz3C3BIJyHNxAdg7otK2Op6?= =?us-ascii?Q?T7rNxxJ6QUyo1e8+8g+BrXmlLpYgBqeArP9mF9zQ5bce/5j8jSzPS1jcRIQb?= =?us-ascii?Q?Lc9wbT2Dz1ChDiOmnx2FCUZAWa6l8zH4m4lNOCPakoEayK1WialR7h3UgP7V?= =?us-ascii?Q?/UvmCkoByl+lFtPlHF4eDuGaSjhsb9FK/2B/XszV6UjCgElUjvvhr8Cu4wOT?= =?us-ascii?Q?ojCkSBOdiRnmrN36eMscD95N3GcL1aD06MCq9bT9pqqJKc63kOZgiawJhSBS?= =?us-ascii?Q?UuD4tssxIsS44HzNBzNhLxDT2Ne11E5tFEgRwzZ3yPhJrOc2Iks/yrzfZ9cj?= =?us-ascii?Q?ata09LGqs7OIiy1kxCGUFIbUg2qtZY0/UjJH5UyO9GZ5sDhwmXABIllwAVdd?= =?us-ascii?Q?DdwyJkjpGIcGk3bUG/p7dTuDjCbRothSOesO5rvJg8ba3A4veHn23MHXtKlC?= =?us-ascii?Q?aFd4is6FvfO14NnMD24kZXPpb5B3e+Y5N1LVXW4WIBGaKfDN12xJwli30A/T?= =?us-ascii?Q?3PvSryjAozZmBn8tu5PhebwVqv8DCEL8URMtsfGjaUkGRKPz7yazHWMJYHr+?= =?us-ascii?Q?daRbE/v9A7QLvMh13Af3AK/Hr/gM0MBTNvArAtdZn4Bg2ntbTE23YUq+FN+9?= =?us-ascii?Q?wxStHuHzTP4HVh0fpK28dJ8MErFovsnJuyMpNutxgOX5k1OCma3yu2f4a4hy?= =?us-ascii?Q?rndks3VwO91WhdvKhrZRnbWqbypgHvPAgq2AbVO2Nrqywa5D+Jk5TPhNY/Hu?= =?us-ascii?Q?sl93NIXxty2BdhKe82f3Wn26Mg0Mf7vZSequifNxvzIH51EgCYOavx7UYU8Y?= =?us-ascii?Q?G2wa8FCq/A35e4zidqXX6mfg74XKccL7knajYLEJugrlgeQlX3+ZRL8YzhdY?= =?us-ascii?Q?BYkHBOKNgbcqWqx9bayu2V6vyUHMzwGy8lUBav5F4My4ogPajCPfpeW6ePz5?= =?us-ascii?Q?45VmAqPamCM+Eyatq1TGupe3APv5K7HTptFPJR0zH8Q1JjWVBC1tYxIl0rC+?= =?us-ascii?Q?bxka9UO+aQ6wJCyg5pdOLwoL8D31xRbkGIsZivljqcSezz4CQOMY9FkLOHXZ?= =?us-ascii?Q?Dz6e/n3oepCnMVr5snIV7s6W3R7Hi+zX/PVuzJk0+2PbeWVRBX+KHzOF24mZ?= =?us-ascii?Q?YSL4ocOVfaBzyJt1XnPjLcfGlshTFa132s0QRc51B8a4Y+fQ7y6hJQkCUh9A?= =?us-ascii?Q?DAdscvB6u1XzRRzoL53+KUrlpJdU15pYxSDo/u5Hae7yiV7HiFC3p+GST8C9?= =?us-ascii?Q?kaU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0d2c0a7-9aad-45f7-b040-08d8fd7d601f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 06:36:59.7104 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7RHxwsOZoB7b0UWJU6LbWUYcSCBPStc9RuKpLr/12rcrKIZa5mIxrjLa4qcLhy+OU64CJHZY82SvTYzzjbqOSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3036 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix resource release issue for mirror flow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Jiawei Wang > Sent: Friday, April 9, 2021 15:33 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Jiawei(Jonny) Wang > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix resource release issue for mirror flow >=20 > The mlx5 PMD allocated the resources of the sample actions, and then > moved these ones to the destination actions array. The original indices w= ere > not cleared and the resources were referenced twice in the flow object - = as > the fate actions and in the destination actions array. >=20 > This causes the failure on flow destroy because PMD tried to release the > same objects twice. >=20 > The patch clears the original indices, add the missed checking for zero a= nd > eliminates multiple object releasing. >=20 > Fixes: 00c10c22118a ("net/mlx5: update translate function for mirroring") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jiawei Wang > Reviewed-by: Suanming Mou Acked-by: Viacheslav Ovsiienko