From: Tal Shnaiderman <talshn@nvidia.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
"dmitrym@microsoft.com" <dmitrym@microsoft.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"lucp.at.work@gmail.com" <lucp.at.work@gmail.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] eal/windows: fix pthreads macros return values
Date: Mon, 12 Apr 2021 07:59:09 +0000 [thread overview]
Message-ID: <DM6PR12MB3945DF27B2FB8A2D2A0CD604A4709@DM6PR12MB3945.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210412000035.77a1f0f6@sovereign>
> Subject: Re: [PATCH] eal/windows: fix pthreads macros return values
>
> External email: Use caution opening links or attachments
>
>
> Hi Tal,
>
> Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0:
>
> ../../../lib/librte_eal/common/eal_common_thread.c: In function
> ‘ctrl_params_free’:
> ../../../lib/librte_eal/windows/include/pthread.h:42:2: warning: value
> computed is not used [-Wunused-value]
> 42 | !DeleteSynchronizationBarrier(barrier)
>
> Probably applies to other functions and may fire in combination with future
> backported patches. Hopefully since 21.05 there will be new threading API.
Thanks Dmitry, it's odd that the compiler complains only now, I'd expect to see this warning even before the change.
Do we know if the new threading API will be in 21.05? API changes close in 3 days and I didn't see it get reviewed/acked.
I can change only pthread_barrier_init for now, since currently without this change Windows runtime is broken, what do you think?
next prev parent reply other threads:[~2021-04-12 7:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 19:54 Tal Shnaiderman
2021-04-11 21:00 ` Dmitry Kozlyuk
2021-04-12 7:59 ` Tal Shnaiderman [this message]
2021-04-12 8:25 ` Thomas Monjalon
2021-04-12 10:03 ` Dmitry Kozlyuk
2021-04-12 10:07 ` David Marchand
2021-04-12 10:26 ` Tal Shnaiderman
2021-04-12 10:37 ` [dpdk-stable] [PATCH v2] " Tal Shnaiderman
2021-04-12 20:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3945DF27B2FB8A2D2A0CD604A4709@DM6PR12MB3945.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=lucp.at.work@gmail.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).