From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF1BBA034F for ; Wed, 10 Nov 2021 08:28:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B68C540142; Wed, 10 Nov 2021 08:28:04 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6F1D040142 for ; Wed, 10 Nov 2021 08:28:03 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="232862344" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="232862344" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 23:28:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="545903510" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 09 Nov 2021 23:28:01 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 9 Nov 2021 23:28:00 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 9 Nov 2021 23:28:00 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 9 Nov 2021 23:28:00 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 9 Nov 2021 23:28:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUO4gKCEiterNKHCEzkKAwfAXoAoaiXvAP6L+NPQF1ndXnYMlpAbY0Q8zK6qlyVRNFVvp3PBborzMvVLih4BF/fLLJbfIx5kQwBreWjPUQ6LwS+VsePNOd+E4VApzejuD246WMFLgdwi2FBdlcL8QSVyAXYYm1CbDYbw15HhcUWdjL7pmRe/6SbM2mepxqp0ErbpNByW34eYTnSiwCU2qOsDFftc5fhgPhXHzeqnbKAgddT5pJdjod1/HlSdqSGkfw2/4esMtCy/iv9feTmIBket7iZDRV2/on3Qv+ZQ1Is3WIzSFSEB84Fd5hEIhUq4N8zs5NHJlNTnqp2Qfyq9yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t8jxFdmGFN8sC5L1OVM+G2L3hkTgLLliyaQQvDQcI9k=; b=oKib01tbCYuJwb2p4wfoPTbEzrycpRbW97lkuc00HrEql1zxT2qBlTH/neoaa0xRH617ehuEls4R/TxssLYaVuN8vf3j7MFNKgPZyQe3dfPmsRGvrbLrVXapbZhhG8G/Z48R5LX3ybM3RVMOZOT8SApWJJHVbgrKztIvHy8o05G32SoDC6Od4ChQGz+FvaogikzqkJlFCHiQWvoAZE2SEsKsVKGVl4fmY9ieq8MQTg3P91c98CseYldY93F1aN3fkx9sQ3OXkfp1rH2MvVPjdjXSThdYeIrD9TNgElvyQRKzS9Vb95CkNJWP/UGAY0ww1vRf/IC7WJt2YmLjkvr1SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8jxFdmGFN8sC5L1OVM+G2L3hkTgLLliyaQQvDQcI9k=; b=vRxLAs9Ogwp69qGs4FvCIuWh/5QHU54tOcC2DxT7Mtu0DLxXa1GgRM05AbR+YRV1qfuj5bo0v4guXgXkD1axvAbN4LyQxgE754mzpJIZAC11MTfYIdWX1wb++6bD85LKzi2IokSR7SJbrUtXfJz471j6sOmXDfYUHT4VuDWXbwQ= Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM8PR11MB5654.namprd11.prod.outlook.com (2603:10b6:8:33::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13; Wed, 10 Nov 2021 07:27:55 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc%9]) with mapi id 15.20.4669.010; Wed, 10 Nov 2021 07:27:55 +0000 From: "Peng, ZhihongX" To: Xueming Li CC: Luca Boccassi , "Lin, Xueqin" , "Richardson, Bruce" , dpdk stable Thread-Topic: patch 'examples/performance-thread: fix build with ASan' has been queued to stable release 20.11.4 Thread-Index: AQHX1f/n4SWu7JiuSEaYITKvpz3Qt6v8XOhQ Date: Wed, 10 Nov 2021 07:27:55 +0000 Message-ID: References: <20211110063216.2744012-1-xuemingl@nvidia.com> <20211110063216.2744012-203-xuemingl@nvidia.com> In-Reply-To: <20211110063216.2744012-203-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41bbaa97-071d-47c6-b388-08d9a41b9d3f x-ms-traffictypediagnostic: DM8PR11MB5654: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bgsyIEqC9Gt/xqipIwgTPSNlCj/BSV4XJA0D6vhcg5n8QcotUahSMZg/8zXAqQ1EXqKGijzqWmWB06W5DQ3DPqUajrMal2gMs0cEGPnAdRQF3P2lsnM2dT7HW8q2LynkafCGMznixkhfU8hLmhlj/fuQ+WLEQIu2YDwYa7OdsKyqFEqq8eKdVdidsmP/iXnUPwGgsntLyweHPmzE/1Wk4VlnhcshKFl+SPQTKZkuuxUPnJgPYJXwzkNHB7b4nX3N3LYDrxZY5hdKk6PNeiAnYXnT65MuzB/9LUAIbFDgPQzG7deXQCCNtadjim/xUHO2Oeq8zdaBAtxwL6/0Hyu+PiYhTnG0odLkGC5TDYJA4YEoLyLt4fnGwML7OsxyYr50Fw+wx07lOBNbbJKn5WR+XUq8fq+CaEJATGSUJMkpd7alSyCHH8WtITN/IKyqCaC9GAJdKycynzmoRSfAhlwID3crPFdGn1yQEsOB2nskKpC9MCETZdD3q/MSMy2uOffY4WPYzcQNsi7ukV2Bq4Tu4t9MmbayleT/WTYzOawAJ/eLxHEEfSUmENM0pGqSbAOwCZe40KRvLZmT3ilsZCKLEEQ+NExcr6JxbP4EhWHpWblKtJbfEqDFGZbuR7HNyviI6gFK7jhrgtkoB13xw477akJ8PiuafUs5B4KZBRo8VqT51ZLcSz1fDt8dlC3PpASO2PMg1F9QwG0hUkpULPxNfhtDaFDViiv+VUkn9AVgplvpy2qTorg2FYjyPkDqugmdrbVmNWX1USAoWu0kUX2khY49L2wqV0NadVvq0I2Svr0ALyAo8OQseYK3tIKpIlFdUAzUlipgzBLQny0LL4/Q7A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(33656002)(82960400001)(26005)(966005)(53546011)(8936002)(8676002)(316002)(52536014)(508600001)(55016002)(7696005)(6506007)(71200400001)(5660300002)(122000001)(66946007)(86362001)(38100700002)(4001150100001)(186003)(9686003)(66556008)(64756008)(54906003)(66476007)(6916009)(2906002)(66446008)(4326008)(76116006)(83380400001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kdofPD+IFuxXBmuVkIxj9gK4x3wV/vo34knQThgLAk6PKBhWUETMl0jhFJjz?= =?us-ascii?Q?+sijzEG69jCohDGTz4UiUUAc7xQoYFdzdp4LkQZTgZyxTroEE1PQKg3AE5Ej?= =?us-ascii?Q?nbezMS+M0kxpQCHn7KjE0zESa7cM86VoB/ps5JmyodFXssnet3GwkSE0EvXv?= =?us-ascii?Q?kSozlElJCRCZcA+i4wSo6VshNHG7lLjjgRDMDH41ymRutJtPgqUx9y9Dt2dD?= =?us-ascii?Q?dgQq4C9jXbgHM6Ucia4fJmHUr4YSRRlrApkuvNohG1C0zklVRUqiRjQXvRdv?= =?us-ascii?Q?Ri12Tp6B/I8VCprX6Nqmz+YP0uxo4SNbtYRMpCqt3vS5NHSNfSvihBR/tOPT?= =?us-ascii?Q?2wxiOOe8lhkFeqh3AgIeXtVwNqA4CcbEME4Ktz2Lk0NQ8FxmVCZqINMLQIV0?= =?us-ascii?Q?Hms1wp41+uLia8s5Xr0xcoqP6goNv4olHuQRiG323B8pTlDIbmdwOLIRWrWG?= =?us-ascii?Q?SajJdgEF5tGQq4KvPcwjq2Qwv4XOd5dxtAZ7QJDSyczs7cSoemc68LS4j4jn?= =?us-ascii?Q?bCMndcGIDpRWDynklRJo/1lSVLpbohLSzK1ZbbX4Z8e+YVV5eIzIFmTsvbV0?= =?us-ascii?Q?dROI0fzKwsiEmQ7Ws4b2jPtvgXnFBzevzup/5OagjLmj1iGlqOsY025WxwV/?= =?us-ascii?Q?+uxVuDA8WV6XsAGpKs5/CDBzuS2lbu95hUYOcjzJdjgyP9EHoBw8j9UHY1K+?= =?us-ascii?Q?cyV0E5rB2YJGLIBmRQcxp2p2EJ4ByheCP9qyLBqCBUG6Rp59JB9Mj7w1BBhD?= =?us-ascii?Q?gWkd/alqavb+EjzNtWYn/XzNztSSs+58weBBUBx8ap6BqqzR851kYmxLF1Bp?= =?us-ascii?Q?2y3M6ZoUpgr1eHwm0Rn6mwzoj978dVcsPqU5QzFFEguqA1eEyrUJoxA4Ivip?= =?us-ascii?Q?6D2gxRLVzN1LnyBYusG1jPoC1gNaG2G1GACx6fRHoKVOJo82FluHla0Ow71s?= =?us-ascii?Q?W/whdQ3wJV5tnRJxSJuFwgWhHOIhps4HaAzmGpCt3TYXI+6NA8OcMHIhkqON?= =?us-ascii?Q?Q+K44fPssPQYmVJ1v0/SeUdZUzMG0gb6YIlNVkwNlqXzjoWEYliiYX6bUDs1?= =?us-ascii?Q?gJsRsI+ChJobMl7lk739PcNbGVwbXumtvKW+HMgZosXH+aBM+RYoTL2WN97b?= =?us-ascii?Q?IxXclQ4k6vgnLUyyuq5KgE+V2Rw1qWqTgLrebiRYpLMgVprDj6KLA2FTXgCb?= =?us-ascii?Q?9e3oLfVMAWWs/oujWITsi3YbQUWwlGTZ2Sg/Q93glctMBIWP57jFrOo3QDaq?= =?us-ascii?Q?r0/6G60fJA8hrZAK3QGLTKJ7KuyxM/1NKau8UtnFSn4SmdvRX7dfo5nfQQL1?= =?us-ascii?Q?YVdqOfZL0kaBN6rZ+maB0ONA1kZoD635fYeNln03nluAL1yvoYQzDgOllR1V?= =?us-ascii?Q?Dne7WzfUQ3Qmt4JUOolFjjf6C7LIaRp/jy3QuHR683uWbWdvydZTp45GmQna?= =?us-ascii?Q?WG4bOsUs/Vrb662B/xRY9BZuMKs1AekshpfYQRaH/vsyvAmuLA71xAjcGCq3?= =?us-ascii?Q?KXhAqSk758WzdGcjBS8nRW14Ja60vO2i+9jBsROGpLHBj/Wl6hWxF/62ZYLx?= =?us-ascii?Q?6itzVJoGAwjZXqPmLpCK37/7WxZwikEbvJAnYd6xPkmmufyMbWNfF5SOVQfA?= =?us-ascii?Q?K8HqWXXjKkwLGkP8xHvBKKo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41bbaa97-071d-47c6-b388-08d9a41b9d3f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 07:27:55.7930 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AhkeKy0icfB49EQBVHdEXHj53E7YzY7qa3lqeQKS3+y6MPC0XsVpCcZ0i8mp4VUVKh8cUtISI/BvGE91VqQWyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5654 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] patch 'examples/performance-thread: fix build with ASan' has been queued to stable release 20.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi , Xueming This patch is not backward compatible.=20 Regards, Peng,Zhihong > -----Original Message----- > From: Xueming Li > Sent: Wednesday, November 10, 2021 2:31 PM > To: Peng, ZhihongX > Cc: Luca Boccassi ; Lin, Xueqin ; > Richardson, Bruce ; dpdk stable > > Subject: patch 'examples/performance-thread: fix build with ASan' has bee= n > queued to stable release 20.11.4 >=20 > Hi, >=20 > FYI, your patch has been queued to stable release 20.11.4 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 11/12/21. So please shout= if > anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://github.com/steevenlee/dpdk >=20 > This queued commit can be viewed at: > https://github.com/steevenlee/dpdk/commit/4b98552d4d3ca54ebc58014b4 > 163e1164e2e4342 >=20 > Thanks. >=20 > Xueming Li >=20 > --- > From 4b98552d4d3ca54ebc58014b4163e1164e2e4342 Mon Sep 17 00:00:00 > 2001 > From: Zhihong Peng > Date: Wed, 20 Oct 2021 15:46:43 +0800 > Subject: [PATCH] examples/performance-thread: fix build with ASan > Cc: Xueming Li >=20 > [ upstream commit 4d2d1258151657d69b0be5d118956b7e809f9d47 ] >=20 > Code changes to avoid the following build error: > "strncpy specified bound XX equals destination size". >=20 > Signed-off-by: Xueqin Lin > Signed-off-by: Zhihong Peng > Acked-by: Bruce Richardson > --- > examples/performance-thread/common/lthread.c | 4 ++-- > examples/performance-thread/common/lthread_cond.c | 6 +++--- > examples/performance-thread/common/lthread_mutex.c | 6 +++--- > 3 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/examples/performance-thread/common/lthread.c > b/examples/performance-thread/common/lthread.c > index 3f1f48db43..190e5874b1 100644 > --- a/examples/performance-thread/common/lthread.c > +++ b/examples/performance-thread/common/lthread.c > @@ -20,6 +20,7 @@ > #include >=20 > #include > +#include > #include > #include >=20 > @@ -463,6 +464,5 @@ void lthread_set_funcname(const char *f) { > struct lthread *lt =3D THIS_LTHREAD; >=20 > - strncpy(lt->funcname, f, sizeof(lt->funcname)); > - lt->funcname[sizeof(lt->funcname)-1] =3D 0; > + strlcpy(lt->funcname, f, sizeof(lt->funcname)); > } > diff --git a/examples/performance-thread/common/lthread_cond.c > b/examples/performance-thread/common/lthread_cond.c > index cdcc7a7b5a..e7be17089a 100644 > --- a/examples/performance-thread/common/lthread_cond.c > +++ b/examples/performance-thread/common/lthread_cond.c > @@ -20,6 +20,7 @@ >=20 > #include > #include > +#include >=20 > #include "lthread_api.h" > #include "lthread_diag_api.h" > @@ -57,10 +58,9 @@ lthread_cond_init(char *name, struct lthread_cond > **cond, > } >=20 > if (name =3D=3D NULL) > - strncpy(c->name, "no name", sizeof(c->name)); > + strlcpy(c->name, "no name", sizeof(c->name)); > else > - strncpy(c->name, name, sizeof(c->name)); > - c->name[sizeof(c->name)-1] =3D 0; > + strlcpy(c->name, name, sizeof(c->name)); >=20 > c->root_sched =3D THIS_SCHED; >=20 > diff --git a/examples/performance-thread/common/lthread_mutex.c > b/examples/performance-thread/common/lthread_mutex.c > index 01da6cad4f..709ab9f553 100644 > --- a/examples/performance-thread/common/lthread_mutex.c > +++ b/examples/performance-thread/common/lthread_mutex.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include >=20 > #include "lthread_api.h" > #include "lthread_int.h" > @@ -52,10 +53,9 @@ lthread_mutex_init(char *name, struct lthread_mutex > **mutex, > } >=20 > if (name =3D=3D NULL) > - strncpy(m->name, "no name", sizeof(m->name)); > + strlcpy(m->name, "no name", sizeof(m->name)); > else > - strncpy(m->name, name, sizeof(m->name)); > - m->name[sizeof(m->name)-1] =3D 0; > + strlcpy(m->name, name, sizeof(m->name)); >=20 > m->root_sched =3D THIS_SCHED; > m->owner =3D NULL; > -- > 2.33.0 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2021-11-10 14:17:10.858279926 +0800 > +++ 0202-examples-performance-thread-fix-build-with-ASan.patch 2021- > 11-10 14:17:02.014078251 +0800 > @@ -1 +1 @@ > -From 4d2d1258151657d69b0be5d118956b7e809f9d47 Mon Sep 17 00:00:00 > 2001 > +From 4b98552d4d3ca54ebc58014b4163e1164e2e4342 Mon Sep 17 00:00:00 > 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > + > +[ upstream commit 4d2d1258151657d69b0be5d118956b7e809f9d47 ] > @@ -19 +22 @@ > -index 98123f34f8..009374a8c3 100644 > +index 3f1f48db43..190e5874b1 100644 > @@ -30 +33 @@ > -@@ -465,6 +466,5 @@ void lthread_set_funcname(const char *f) > +@@ -463,6 +464,5 @@ void lthread_set_funcname(const char *f) > @@ -64 +67 @@ > -index 061fc5c19a..f3ec7c1c60 100644 > +index 01da6cad4f..709ab9f553 100644