From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keith.wiles@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 5A0421B47B;
 Thu,  2 Aug 2018 14:04:12 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 02 Aug 2018 05:04:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,435,1526367600"; d="scan'208";a="61807102"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga008.jf.intel.com with ESMTP; 02 Aug 2018 05:03:25 -0700
Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 2 Aug 2018 05:03:24 -0700
Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.99]) by
 fmsmsx101.amr.corp.intel.com ([169.254.1.223]) with mapi id 14.03.0319.002;
 Thu, 2 Aug 2018 05:03:24 -0700
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Matan Azrad <matan@mellanox.com>
CC: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH] net/tap: fix zeroed flow mask configurations
Thread-Index: AQHUKkxCY4cQyunhbk2KmeGYwX2aLaSs0l+A
Date: Thu, 2 Aug 2018 12:03:23 +0000
Message-ID: <E0CB2630-6BAF-46DF-82F1-769F0902A172@intel.com>
References: <1533205980-7874-1-git-send-email-matan@mellanox.com>
In-Reply-To: <1533205980-7874-1-git-send-email-matan@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.255.230.74]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B7258F9D2CEB17409B367BC214D75665@intel.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [PATCH] net/tap: fix zeroed flow mask
	configurations
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 12:04:13 -0000



> On Aug 2, 2018, at 5:33 AM, Matan Azrad <matan@mellanox.com> wrote:
>=20
> The rte_flow meaning of zero flow mask configuration is to match all
> the range of the item value.
> For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0
> should much all the ipv4 traffic from the rte_flow API perspective.
>=20
> From some kernel perspectives the above rule means to ignore all the
> ipv4 traffic (e.g. Ubuntu 16.04, 4.15.10).
>=20
> Due to the fact that the tap PMD should provide the rte_flow meaning,
> it is necessary to ignore the spec in case the mask is zero when it
> forwards such like flows to the kernel.
> So, the above rule should be translated to eth / ipv4 to get the
> correct meaning.
>=20
> Ignore spec configurations when the mask is zero.
>=20
> Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Matan Azrad <matan@mellanox.com>

Acked-by: Keith Wiles<keith.wiles@intel.com>

Regards,
Keith