From: Yongseok Koh <yskoh@mellanox.com>
To: Mordechay Haimovsky <motih@mellanox.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx4: fix minor resource leak during init
Date: Thu, 16 Aug 2018 17:56:15 +0000 [thread overview]
Message-ID: <E78D34D3-9DD2-447A-ADB7-D4CC5F14A841@mellanox.com> (raw)
In-Reply-To: <1534352643-13073-1-git-send-email-motih@mellanox.com>
> On Aug 15, 2018, at 10:04 AM, Mordechay Haimovsky <motih@mellanox.com> wrote:
>
> From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> Temporary IB device context and list are not freed in case of a successful
> initialization of the device.
>
> This issue is caused by the two following commits, the first of which
> causes initialization to return early, while the second one goes a bit
> overboard while switching to negative errno values; an internal variable
> (err) is needed to tell success from failure at the end of the function
> since rte_errno is not reliable enough.
>
> Fixes: f2318196c71a ("net/mlx4: remove limitation on number of instances")
> Fixes: 9d14b27308a0 ("net/mlx4: standardize on negative errno values")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
Applied to stable/17.11
Thanks,
Yongseok
prev parent reply other threads:[~2018-08-16 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 17:04 Moti Haimovsky
2018-08-15 17:27 ` Yongseok Koh
2018-08-16 17:56 ` Yongseok Koh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E78D34D3-9DD2-447A-ADB7-D4CC5F14A841@mellanox.com \
--to=yskoh@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=motih@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).