From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30065.outbound.protection.outlook.com [40.107.3.65]) by dpdk.org (Postfix) with ESMTP id 0C576235 for ; Thu, 16 Aug 2018 19:56:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K+PYdP5LLEFS3wBI9Z0PD7ptmvfu8VmK3L3jtXHIFOg=; b=vl2S1t1udoIL5HggONcWpADkAs6YvWJC96WQpyPNXh1yJtS3GogH2yfa514/TCh5/YPgU7ps+Vc1YXD29LbM+NX1HGnIdeA/CBRBAOCtsQqv3Su2kGp6Z2ax6Jqi/lqVM+XoOGjvSnsoi85bBp2k45ezxFqJtVa6v8g7p8zz+WE= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4010.eurprd05.prod.outlook.com (52.134.72.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Thu, 16 Aug 2018 17:56:15 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1059.017; Thu, 16 Aug 2018 17:56:15 +0000 From: Yongseok Koh To: Mordechay Haimovsky CC: Adrien Mazarguil , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx4: fix minor resource leak during init Thread-Index: AQHUNLoDgUxBy+ZQU0GlcPNrzsbPVaTCq2QA Date: Thu, 16 Aug 2018 17:56:15 +0000 Message-ID: References: <1534352643-13073-1-git-send-email-motih@mellanox.com> In-Reply-To: <1534352643-13073-1-git-send-email-motih@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4010; 6:xfWQBxv+LhEg+0XYBgSIeWtvtPjAcsBworwwWtrL1fdMXc3hD5eN292KO1GHrMlRYikyZNuSxqUdspEg6JAmvR2rWR5L4evX+Ikn4S85A4A989yvQ7PySFqiqXPljFni5Zau3yRaNSS+Ztcp2UZ4r563AyXKFzL9m3sg5Rn3n0TBm0OibV3DVP8h2027JLj1yk2sR7zAFL6o+Q/Ad8Hnovr1JJKzHTULfCLIxUWUxy1ruDO0Jiziy6k9jmD7cpCU+hsL/8qZ1hXTkDqPRc4On5fFyy9B3PFm6rCuNzZzdmMk/SFzgpWxXsFnW5t4W/xNWoCMC4rLr1OdCXsy5aXlyM3zq7/Ib8ec2OWeAj4awXfblo5a2D9h1QAGMMIMy5gc7zsPEUwPPpoKqR76Q3bI13V2DC6O8Z0xdG5pgJoJczI5/jeCCocReYkzNMXl4YO4FyKDF7EjEr6EKyX2WGdAsg==; 5:nRgC4wbF2vYZS8kSU2i+HLQGzr/ReNN9eg3irL6YDOChAwqSyDUP0jpY4HdLQQsg050z0RfL5/FT7xfALTQZ/mUawoihWms9/glVc/FANji4kx4AyYRfph0hTIISDxYdXDR5nh6Eqsgm4+DjN3iXZvd1B3LH7JrJ34pjSUauLNg=; 7:6CW1oRLyOpaSo42oD5s4BeEQAo1gYbXkC7C/R6xQiPZfxtFCp3+WPzb2gu6WK73uwCLIDUrozu7y322giiX4Ldy/WkCXeWgS2Y3P7qAbhw/mqbMs6STJt5EOsj1jCxC8uHi+k1UQKZuT2Onyyc7vpRCrKmr2qzf7f7zDCJP/SzQTHfCkhYfwnm7CBJGwGAIhF99yIQaAiBBrAZmqFtHPcPoYVbvaWAzFt8d1Tw/j3aalw7KKFRy551jHuFo3ayXZ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 47c83e57-2bd5-4fc4-c522-08d603a18f8d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4010; x-ms-traffictypediagnostic: DB3PR0502MB4010: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(201708071742011)(7699016); SRVR:DB3PR0502MB4010; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4010; x-forefront-prvs: 07665BE9D1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(39860400002)(346002)(376002)(189003)(199004)(316002)(3846002)(6116002)(6512007)(54906003)(33656002)(105586002)(446003)(106356001)(5660300001)(68736007)(76176011)(6246003)(83716003)(99286004)(97736004)(36756003)(6636002)(14454004)(2900100001)(7736002)(2906002)(305945005)(4326008)(486006)(8936002)(256004)(14444005)(476003)(8676002)(53936002)(81166006)(82746002)(26005)(53546011)(6506007)(102836004)(37006003)(25786009)(6486002)(229853002)(5250100002)(6862004)(6436002)(81156014)(11346002)(2616005)(86362001)(66066001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4010; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4Cc60BFaGw7wDi0nRDzIRNPgXMLEkHlLmY0mm0J1IeFXSPhzz0uUOFQLAGV8g/kptrfObz6/qNxIZgQKNaZxW1CKIYzvvFwj6bMZa4GGKt4NujcVFkOXKAivLIvRnil+F+ZAlX+vreBUUuQIpBu61c/kaEzcMzG1DB9kPWq12meruCVzDtCTpTj3NTEKQFIXcRsAVYjgAwmrMYqC3vLLxG7FUFEMXjMseRWteGqFyQeT0GoXLP6JHmHmuQ1euhC8B8LEiiKSG0itA0hHZdfKEhUGuFo63rvPy6Ov2punFWTiTL7CQKxTKSYvuuGKXLa447icrUERFLLpg8+2gg+D1YxrdZEZXBC8NTEDdxv/7gw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47c83e57-2bd5-4fc4-c522-08d603a18f8d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2018 17:56:15.1460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4010 Subject: Re: [dpdk-stable] [PATCH] net/mlx4: fix minor resource leak during init X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 17:56:16 -0000 > On Aug 15, 2018, at 10:04 AM, Mordechay Haimovsky wr= ote: >=20 > From: Adrien Mazarguil >=20 > Temporary IB device context and list are not freed in case of a successfu= l > initialization of the device. >=20 > This issue is caused by the two following commits, the first of which > causes initialization to return early, while the second one goes a bit > overboard while switching to negative errno values; an internal variable > (err) is needed to tell success from failure at the end of the function > since rte_errno is not reliable enough. >=20 > Fixes: f2318196c71a ("net/mlx4: remove limitation on number of instances"= ) > Fixes: 9d14b27308a0 ("net/mlx4: standardize on negative errno values") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adrien Mazarguil > Signed-off-by: Moti Haimovsky > --- Applied to stable/17.11 Thanks, Yongseok=