patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets
Date: Mon, 14 Jan 2019 04:23:48 +0000	[thread overview]
Message-ID: <E95956FD-35DF-4242-9784-1D0AFF0C267D@mellanox.com> (raw)
In-Reply-To: <1547368916-22381-1-git-send-email-rasland@mellanox.com>


> On Jan 13, 2019, at 12:42 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> 
> When writev fails to send packets it doesn't update the
> number of Tx packets, but it still num_tx is updated.
> 
> The value that should be returned is the actual number
> of sent packets which is num_packets.
> 
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> CC: stable@dpdk.org
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Acked-by: Keith Wiles <keith.wiles@intel.com>
> ---

Raslan, it doesn't get compiled on stable/17.11

Thanks,
Yongseok

> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 466624a..50757ef 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> 	txq->stats.errs += nb_pkts - num_tx;
> 	txq->stats.obytes += num_tx_bytes;
> 
> -	return num_tx;
> +	return num_packets;
> }
> 
> static const char *
> -- 
> 2.7.4
> 

  reply	other threads:[~2019-01-14  4:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13  8:42 Raslan Darawsheh
2019-01-14  4:23 ` Yongseok Koh [this message]
2019-01-14  7:46   ` Raslan Darawsheh
2019-01-14  9:08     ` Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E95956FD-35DF-4242-9784-1D0AFF0C267D@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).