From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10078.outbound.protection.outlook.com [40.107.1.78]) by dpdk.org (Postfix) with ESMTP id 0E1D31B296 for ; Mon, 14 Jan 2019 05:23:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oC3L7RE75fK6NjAGcmP4Gz3TwTTNiEPelr3Zz+hjXrA=; b=N6EdsjHDfUmV7XY5JWh1BVdE+Zufv9Mcg7100FVHuGsTe/bV1BCVT8mRbHvG9QYYvPuihIYwdvnjo7VHWa9M6vyVYsqayZQ6HZMcd3Qa9oXkw9ceGyJAugdAvTtClcfwuWPAk5kg8QOTG6E9Dr0vwO8Ldf4Vxo5PLb1CynOsvGE= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4073.eurprd05.prod.outlook.com (52.134.68.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Mon, 14 Jan 2019 04:23:48 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c%2]) with mapi id 15.20.1516.019; Mon, 14 Jan 2019 04:23:48 +0000 From: Yongseok Koh To: Raslan Darawsheh CC: "stable@dpdk.org" Thread-Topic: [17.11] net/tap: fix reported number of Tx packets Thread-Index: AQHUqxveirlyhoE8LEqDZrXnL6n2OqWuK6qA Date: Mon, 14 Jan 2019 04:23:48 +0000 Message-ID: References: <1547368916-22381-1-git-send-email-rasland@mellanox.com> In-Reply-To: <1547368916-22381-1-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4073; 6:qxX1ZEvolrFtreBH1bPHbg8pMCVh169f3+Y9gk0/IDe1S+5GNws13l3mHz4YStGn9NCEYQSBrSVIoMTTueaM1nL9tzYzISoBHxp1PU6WwjfTo2R3IEfUcv8murl4c6V6aFlSrtDha/aBFZCDX3mYkunHsyfNtClFaM8trK5/nm+ZJrJqAsfDNCD4bZstb0Tep3xv1SJHSdC7PTUUhORWSFKmcp+QM+K+104heqW4SGmFaQgMZnnzRH80RoRWijkVWFhZftRwY0YX2aqBhiaLQmyQywdmZ9jPHsfIbotsGrtnEPxF32eqwi8Zj/SMI3khKR7ifGLB3zsYfKFxm94QLn3szSLjZl4sPGTGA9SXFszDm45Tdf5FNWCu0lFA12r1uAecY8rWr02j2uvoK3oso9M8976BmzEN0TksVzyX9VrICOhpjwz65Nkf1susE1DiIJcvcRP95AH/E7vOVXgHgw==; 5:rqpVMXdxB48OmV3uz0vDascca72p5RetCBzMViUTExWXGORxAvM8eqnp7DN8H3Vf3SEISUnLe6WM4bWrWDY79bXRcxgnh9ncwVkImol8okcJs+cX5YNVdpkMVOCcSbUx3dGh2Ce1SvEqXur+FKvq+/laTnNKueo/kxj9bBnwwL3d/Gc359/oWidogZFG/rQ6ubCP+Zx2P38h/1Z5nV0UNg==; 7:Zet2wZp9SilmVR5amJF9tyPT8FLzdF/VQhaXoDx721MR7iIPMwYxwvfUq+yLcZM1avJztEeYAlYnCN0qQjJQlMMRGbT6TdTqsjGRP2KwpK03KdG0hEJhAwxfcuffXRm7AJl7tkv0uz8NkfEkstUAEw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 82741005-0355-4e8a-c398-08d679d814b4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4073; x-ms-traffictypediagnostic: DB3PR0502MB4073: x-microsoft-antispam-prvs: x-forefront-prvs: 0917DFAC67 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(376002)(396003)(346002)(39860400002)(199004)(189003)(86362001)(575784001)(25786009)(8936002)(81156014)(81166006)(106356001)(71190400001)(71200400001)(83716004)(105586002)(3846002)(97736004)(6116002)(33656002)(82746002)(486006)(26005)(68736007)(186003)(6246003)(99286004)(53936002)(316002)(37006003)(76176011)(6506007)(5660300001)(102836004)(36756003)(53546011)(14454004)(4326008)(478600001)(7736002)(8676002)(6636002)(256004)(11346002)(476003)(6436002)(229853002)(6486002)(305945005)(2616005)(446003)(14444005)(2906002)(6512007)(66066001)(6862004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4073; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pCYbFo50xyv6UxqAWxN+VBFdrOkONhtBAPxGrDrGVTFmHTXxusCnNtk5g80uvfQRCBYuaq9QKs48fygr+pfDNysdlESjONSIj5kGceDBTWlK6Gq5k8FOSXQfWrh5dPzJFTk/p+YImCV59hOMKanPY53BOudk6NqA/t3JvaOpC0YZ3wSAUn1u+XHqbtHGQ3vbAzLB6aGxxovEtP3PsqCLhlbV4LrUpCB5nGp7/aGwp6tqruPJVdPaN3u557Auk92L4esrTbWOKh9b+O5DFQw5NaR/v64XQzH5JqVHWDRhWp9yqM/EbfeFnP4dC+2l986FRxK6B/0tX0r+wSZZQpBIjm0DOkHjz0ZDHuNciDMAGJH7RXOEWAozYXLywZinmxyk24Rr181K/JTh3w1IzD70UoKImscYqk/nQsL7t8KwTDo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <35BFABEB5F5C594EB8C1CD10571AF4AA@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82741005-0355-4e8a-c398-08d679d814b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2019 04:23:48.5072 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4073 Subject: Re: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 04:23:51 -0000 > On Jan 13, 2019, at 12:42 AM, Raslan Darawsheh wro= te: >=20 > When writev fails to send packets it doesn't update the > number of Tx packets, but it still num_tx is updated. >=20 > The value that should be returned is the actual number > of sent packets which is num_packets. >=20 > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > CC: stable@dpdk.org >=20 > Signed-off-by: Raslan Darawsheh > Acked-by: Keith Wiles > --- Raslan, it doesn't get compiled on stable/17.11 Thanks, Yongseok > drivers/net/tap/rte_eth_tap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 466624a..50757ef 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uin= t16_t nb_pkts) > txq->stats.errs +=3D nb_pkts - num_tx; > txq->stats.obytes +=3D num_tx_bytes; >=20 > - return num_tx; > + return num_packets; > } >=20 > static const char * > --=20 > 2.7.4 >=20