From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jiayu.hu@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 947EF1B17F;
Wed, 9 Jan 2019 06:18:23 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
08 Jan 2019 21:18:22 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,456,1539673200"; d="scan'208";a="132907476"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
by fmsmga002.fm.intel.com with ESMTP; 08 Jan 2019 21:18:22 -0800
Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by
FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Tue, 8 Jan 2019 21:18:22 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Tue, 8 Jan 2019 21:18:21 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.63]) by
SHSMSX103.ccr.corp.intel.com ([169.254.4.150]) with mapi id 14.03.0415.000;
Wed, 9 Jan 2019 13:18:20 +0800
From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "stephen@networkplumber.org" <stephen@networkplumber.org>, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>, "mb@smartsharesystems.com"
<mb@smartsharesystems.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH V4] doc: add GRO API limitations in prog_guide
Thread-Index: AQHUp8eFICE826ABL0WSx3Qn06APW6Wl0QAAgAAAhQCAAIbtQA==
Date: Wed, 9 Jan 2019 05:18:18 +0000
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B3CF40113@shsmsx102.ccr.corp.intel.com>
References: <1546586200-38148-1-git-send-email-jiayu.hu@intel.com>
<1547002811-6989-1-git-send-email-jiayu.hu@intel.com>
<4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EBD96@BGSMSX101.gar.corp.intel.com>
<4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EBDB2@BGSMSX101.gar.corp.intel.com>
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EBDB2@BGSMSX101.gar.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWE3OTM4YzEtYmFhMy00MjcwLWE3OTItZTJjMzlmOTU1OGVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV1Q2ZW1xbVR2TWZmcDQyVEJwajZtQ1VuWGhyWkNjU1RCbktuYXludUlTWSs2ZElSN1wvMmdiaDJPZnRmQjBBS1cifQ==
x-ctpclassification: CTP_NT
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH V4] doc: add GRO API
limitations in prog_guide
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 05:18:24 -0000
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Wednesday, January 9, 2019 12:27 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; Hu, Jiayu
> <jiayu.hu@intel.com>; dev@dpdk.org
> Cc: stephen@networkplumber.org; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; mb@smartsharesystems.com; Hu, Jiayu
> <jiayu.hu@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH V4] doc: add GRO API limitations in
> prog_guide
>=20
> Typo in previous email
>=20
> why there is document update patch with no code update patch shared?
I think I need to remove the fix commit 9e0b9d2ec0f4 from this patch, since
the GRO programmer doc is introduced in 2c900d09055e.
Thanks,
Jiayu
>=20
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Varghese, Vipin
> > Sent: Wednesday, January 9, 2019 9:55 AM
> > To: Hu, Jiayu <jiayu.hu@intel.com>; dev@dpdk.org
> > Cc: stephen@networkplumber.org; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; mb@smartsharesystems.com; Hu,
> Jiayu
> > <jiayu.hu@intel.com>; stable@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH V4] doc: add GRO API limitations in
> prog_guide
> >
> > Hi Jiayu Hu,
> >
> > A request to information, why there is document update patch with code
> > update patch shared?
> >
> > As per DPDK 19.02-rc1 both code and document should be one patch. Can
> you
> > share the code patch reference if it was applied before 19.02-rc1?
> >
> > Thanks
> > Vipin Varghese
> >
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Jiayu Hu
> > > Sent: Wednesday, January 9, 2019 8:30 AM
> > > To: dev@dpdk.org
> > > Cc: stephen@networkplumber.org; Ananyev, Konstantin
> > > <konstantin.ananyev@intel.com>; mb@smartsharesystems.com; Hu,
> Jiayu
> > > <jiayu.hu@intel.com>; stable@dpdk.org
> > > Subject: [dpdk-dev] [PATCH V4] doc: add GRO API limitations in
> > > prog_guide
> > >
> > > This patch adds GRO API limitations in the programmer guide.
> > >
> > > Fixes: 2c900d09055e ("doc: add GRO guide")
> > > Fixes: 9e0b9d2ec0f4 ("gro: support VxLAN GRO")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > > ---
> > > changes in v4:
> > > - update MBUF->l2_len/... requirement
> > > changes in v3:
> > > - add MBUF limitation
> > > changes in v2:
> > > - add fix versions
> > > - add more limitations
> > >
> > > doc/guides/prog_guide/generic_receive_offload_lib.rst | 17
> > > +++++++++++++++++
> > > 1 file changed, 17 insertions(+)
> > >
> > > diff --git a/doc/guides/prog_guide/generic_receive_offload_lib.rst
> > > b/doc/guides/prog_guide/generic_receive_offload_lib.rst
> > > index 9c6a4d0..53c9d5c 100644
> > > --- a/doc/guides/prog_guide/generic_receive_offload_lib.rst
> > > +++ b/doc/guides/prog_guide/generic_receive_offload_lib.rst
> > > @@ -191,3 +191,20 @@ Header fields deciding if packets are neighbors
> > > include:
> > > ignore IPv4 ID fields for the packets whose DF bit is 1.
> > > Additionally, packets which have different value of DF bit c=
an't
> > > be merged.
> > > +
> > > +GRO Library Limitations
> > > +-----------------------
> > > +
> > > +- GRO library uses the values of MBUF->l2_len/l3_len/l4_len/
> > > + outer_l2_len/outer_l3_len to get protocol headers for the
> > > + input packet, rather than parsing the packet header. Therefore,
> > > + before call GRO APIs to merge packets, user applications
> > > + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len
> > > + to the same values as the protocol headers of the packet.
> > > +
> > > +- GRO library doesn't support to process packets with IPv4 Options.
> > > +
> > > +- GRO library just supports to process the packet organized
> > > + in a single MBUF. If the input packet consists of multiple
> > > + MBUFs (i.e. chained MBUFs), GRO reassembly behaviors are
> > > + unknown.
> > > --
> > > 2.7.4