From: "Wiles, Keith" <keith.wiles@intel.com>
To: olegpoly123 <olegp123@walla.co.il>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4] net/tap: fix missing _SC_IOV_MAX
Date: Fri, 8 Mar 2019 19:13:07 +0000 [thread overview]
Message-ID: <EE2EB68F-EFE0-4BF7-9DF6-96D3139F49E6@intel.com> (raw)
In-Reply-To: <20190308190658.6313-1-olegp123@walla.co.il>
> On Mar 8, 2019, at 1:06 PM, olegpoly123 <olegp123@walla.co.il> wrote:
>
> If the value _SC_IOV_MAX is missing, sysconf returns -1.
> In this case, iov_max is set to a default value of 1024.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Oleg Polyakov <olegp123@walla.co.il>
> ---
> drivers/net/tap/rte_eth_tap.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 6f5109fca..2a7e6aa00 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -68,6 +68,8 @@
> /* IPC key for queue fds sync */
> #define TAP_MP_KEY "tap_mp_sync_queues"
>
> +#define TAP_IOV_DEFAULT_MAX 1024
> +
> static int tap_devices_count;
> static struct rte_vdev_driver pmd_tap_drv;
> static struct rte_vdev_driver pmd_tun_drv;
> @@ -1326,6 +1328,12 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
> struct rx_queue *rxq = &internals->rxq[rx_queue_id];
> struct rte_mbuf **tmp = &rxq->pool;
> long iov_max = sysconf(_SC_IOV_MAX);
> +
> + if (iov_max <= 0) {
> + TAP_LOG(WARNING,
> + "_SC_IOV_MAX is not defined. Using %d as default\n", TAP_IOV_DEFAULT_MAX);
> + iov_max = TAP_IOV_DEFAULT_MAX;
> + }
> uint16_t nb_desc = RTE_MIN(nb_rx_desc, iov_max - 1);
> struct iovec (*iovecs)[nb_desc + 1];
> int data_off = RTE_PKTMBUF_HEADROOM;
> --
> 2.14.1
>
Acked-by Keith Wiles <keith.wiles@intel.com>
Regards,
Keith
next prev parent reply other threads:[~2019-03-08 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 19:06 olegpoly123
2019-03-08 19:13 ` Wiles, Keith [this message]
2019-03-08 21:51 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE2EB68F-EFE0-4BF7-9DF6-96D3139F49E6@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=olegp123@walla.co.il \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).