From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18493A0471 for ; Thu, 18 Jul 2019 04:33:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D26263977; Thu, 18 Jul 2019 04:33:34 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F227328EE; Thu, 18 Jul 2019 04:33:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 19:33:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="175886814" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jul 2019 19:33:28 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 19:33:28 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 19:33:27 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 10:33:24 +0800 From: "Yang, Qiming" To: "Wang, Ying A" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 1/3] net/ice: fix flow get inputset check Thread-Index: AQHVPQuX+Jj9MLV5e0uDFPXGY9gvZabPqAQQ Date: Thu, 18 Jul 2019 02:33:23 +0000 Message-ID: References: <1563413923-404004-1-git-send-email-ying.a.wang@intel.com> <1563413923-404004-2-git-send-email-ying.a.wang@intel.com> In-Reply-To: <1563413923-404004-2-git-send-email-ying.a.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 1/3] net/ice: fix flow get inputset check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" It's no need to add RTE_FLOW_ITEM_TYPE_VOID because we have skipped all the= VOID items. -----Original Message----- From: Wang, Ying A=20 Sent: Thursday, July 18, 2019 9:39 AM To: Zhang, Qi Z Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A ; stable@dpdk.org Subject: [PATCH 1/3] net/ice: fix flow get inputset check ice_get_flow_field should not set error if item->type is RTE_FLOW_ITEM_TYPE= _VOID. This patch fixes this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: stable@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_generic_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_gener= ic_flow.c index c2931a1..464f6ec 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -465,7 +465,7 @@ static uint64_t ice_get_flow_field(const struct rte_flo= w_item pattern[], case RTE_FLOW_ITEM_TYPE_NVGRE: nvgre_spec =3D item->spec; nvgre_mask =3D item->mask; - /* Check if VXLAN item is used to describe protocol. + /* Check if NVGRE item is used to describe protocol. * If yes, both spec and mask should be NULL. * If no, both spec and mask shouldn't be NULL. */ @@ -480,6 +480,8 @@ static uint64_t ice_get_flow_field(const struct rte_flo= w_item pattern[], is_tunnel =3D 1; =20 break; + case RTE_FLOW_ITEM_TYPE_VOID: + break; default: rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, -- 1.8.3.1