From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yskoh@mellanox.com>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
(mail-db5eur01on0049.outbound.protection.outlook.com [104.47.2.49])
by dpdk.org (Postfix) with ESMTP id 44CF74CBD
for <stable@dpdk.org>; Sun, 2 Sep 2018 21:30:12 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=ePE01vIPjmf+uFIFPVVFKh7y+/wfB1vVFIfKwuxwVmQ=;
b=aMWWc4fl7bdPSP3JXV1cPlce3x2z5Ia+75+inCkLdjYDyg2AR0k0f7ihlOO0VlMkgyJfPmPFW+vkoM7P0iYdTx7DSqgkwOODXCvrP2G4630wfCL2VoiRLhE47P3ZUOZVnJx2hULnYCT/BKJ369RWXhAuMUtUZMK2Lqr956kP1Gk=
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by
DB3PR0502MB4075.eurprd05.prod.outlook.com (52.134.72.156) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1080.17; Sun, 2 Sep 2018 19:30:11 +0000
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com
([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com
([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1101.016; Sun, 2 Sep 2018
19:30:11 +0000
From: Yongseok Koh <yskoh@mellanox.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
CC: "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when
__aarch64__ is defined
Thread-Index: AQHUQutHksvtrTRwPEy6+Zaj0UhVC6TdYOGA
Date: Sun, 2 Sep 2018 19:30:11 +0000
Message-ID: <F91EA7A4-DD1E-403A-9983-5BD007462A9C@mellanox.com>
References: <1535913120-22426-1-git-send-email-honnappa.nagarahalli@arm.com>
In-Reply-To: <1535913120-22426-1-git-send-email-honnappa.nagarahalli@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is )
smtp.mailfrom=yskoh@mellanox.com;
x-originating-ip: [73.222.116.174]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4075;
6:rh3Zkl0FItS2eJcK3TBHj8Tegcv8f8yAMOXDr2TsvX/3ZNK4nNnB7wLY3Y5AKxNbKcVxySW/viC+DaLmu/nVcYKdVVwHTFuPsEgvLWEWiH9v3o55K2nHu+j7akuLDUK631vJ7uadD2LQQHlZCfeyT/WaCEldLM1/sHZuBkzcixoWo0fKNCZpJgEWr6yZ2lrGSVCds9ytb7b9wNao+h0XNAHJPbMcdIHvWtfsCuG2pd1vgQPal6DTXqjGea4/ror72w/P8sblG8zVSyanWEZ9o1Lqdf7MI3vlhVtMys+PXdu9G1xjIvAQTVjXvkqNfTUGVW5gRLDp9nEIKYGCAhEdoBdG0QEEOJ7K3Z51oLHjVgUzgOA8QRNe6adz4X535AOK0dkSq/yF/opaE0BqMwPWjfqy9I9suDmJhWMS2P6PlNz5OigDqPNmf0jdoz8mJku3fY0ZbkqLSlybHiOgijh5dA==;
5:/WnW+hpjVW0AviGcxJd5ZQVopU8VOAl/CNsFX+kullSI3tIGtqXMbDcz4oTR70Cqj68jqbRMzZP74yOB8Ba3fILrAHV8lkygasnRqSnBU0nYZXx/fQwET/A0kRoJeFLdgZL0y75LUapbA6UDZMk2s+qN7jvhtJBSgB4dQAIKueQ=;
7:OFBd9wJwxy75IN96nSYj/qZKXo9LlPC9Wf9BBDi3fN5jJXPLYznb7nHQELrhrYQh24oOsOVHEjnfgQJppH1OUWx7oNouXx1VgLtoyrs7jpHNFYEVajeBURS7IiYthr6uFIW3GR/Xx18MSeS7Yx4VeKL0cuvhx8gEN+4Ly+68fzZycVZIP5k3aq19mrPxKs0bHtfaj7U6YxxQFcqfWc5iIAjvwpLpV3v0akxFTpGQwngi9rFhm/tL8UtwQ+h3rwfj
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 2c7065be-525e-4a73-ee87-08d6110a7ff3
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);
SRVR:DB3PR0502MB4075;
x-ms-traffictypediagnostic: DB3PR0502MB4075:
x-microsoft-antispam-prvs: <DB3PR0502MB407598FA41720AD00004FC4EC30D0@DB3PR0502MB4075.eurprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(180628864354917);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699016);
SRVR:DB3PR0502MB4075; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4075;
x-forefront-prvs: 078310077C
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(376002)(39860400002)(136003)(346002)(366004)(396003)(199004)(189003)(83716003)(14454004)(229853002)(11346002)(97736004)(8936002)(5660300001)(36756003)(6486002)(446003)(6512007)(486006)(6436002)(86362001)(2616005)(476003)(316002)(81156014)(81166006)(6246003)(26005)(305945005)(2900100001)(3846002)(105586002)(186003)(6916009)(14444005)(102836004)(6506007)(66066001)(6116002)(5250100002)(82746002)(68736007)(76176011)(53936002)(25786009)(256004)(2906002)(478600001)(7736002)(4326008)(106356001)(99286004)(53546011)(33656002);
DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4075;
H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
permitted sender hosts)
x-microsoft-antispam-message-info: QO0FjgpFYRetHNG9zKLiHkwq4Yvw3TmHNDLIj4F9kqlbX7wPp7UjMYucQcYf8UArqltTtQVTnNtw3DA9X7oHgHaaAKMOz+836eqZg7d8+2nh7ZP95i6uNcMFLW41Cj42Sl6sIdJ5WWSExYP2hWVqY0+K4sQZ+fQuuzp1Z7jH/bow3F+L+hhPqxD5Djpay0OfBns1wUnskdbcWuHn1qlcUz1C4L3LbvTJ7avYYeesiy7qK7xDyAY7rZ2881gVk+tMbNTZUA947gkWICg0G2OlZ3L97UKR+oRAYx9mbxpThaUArQDdA9HujkxEEFP3rpHaWeU89OtNmesdTuJ9BdFEXzkPdx4HpqqU7rr1Z8UUnCM=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E148438952555346B1D58FFB707FE9CD@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c7065be-525e-4a73-ee87-08d6110a7ff3
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2018 19:30:11.2140 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4075
Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags
when __aarch64__ is defined
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Sep 2018 19:30:12 -0000
Hi,
Thanks,
Yongseok
> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli <Honnappa.Nagarahalli@a=
rm.com> wrote:
>=20
> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not
> optional for ArmV8. Hence NEON related code can be enabled
> when __aarch64__ is defined.
>=20
> Bugzilla ID: 82
> Cc: stable@dpdk.org
>=20
> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Reported-by: Thomas F Herbert <therbert@redhat.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Acked-by: Gavin Hu <gavin.hu@arm.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> V2:
> * Corrected the order of contribution tags
> * Added Jerin's Ack
I didn't check out the details yet but a quick question.
Do you want me to include this patch in 17.11.4?
Thanks,
Yongseok
> config/arm/meson.build | 3 ++-
> mk/rte.cpuflags.mk | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 40dbc87..94cca49 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -157,7 +157,8 @@ else
> endif
> message(machine_args)
>=20
> -if cc.get_define('__ARM_NEON', args: machine_args) !=3D ''
> +if (cc.get_define('__ARM_NEON', args: machine_args) !=3D '' or
> + cc.get_define('__aarch64__', args: machine_args) !=3D '')
> dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1)
> compile_time_cpuflags +=3D ['RTE_CPUFLAG_NEON']
> endif
> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
> index 6071313..43ed841 100644
> --- a/mk/rte.cpuflags.mk
> +++ b/mk/rte.cpuflags.mk
> @@ -89,7 +89,7 @@ CPUFLAGS +=3D VSX
> endif
>=20
> # ARM flags
> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),)
> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),)
> CPUFLAGS +=3D NEON
> endif
>=20
> --=20
> 2.7.4
>=20