patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Abdullah Ömer Yamaç" <aomeryamac@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Dharmik Jayesh Thakkar <DharmikJayesh.Thakkar@arm.com>,
	Yipeng Wang <yipeng1.wang@intel.com>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	nd <nd@arm.com>
Subject: Re: [PATCH v2] lib/hash: Set the maximum reclamation size to user provided value
Date: Mon, 13 May 2024 16:17:17 +0000	[thread overview]
Message-ID: <FB7453BE-AA11-4C92-835D-CC28639CBFD2@arm.com> (raw)
In-Reply-To: <CA+sj1i-8fkRT7pk4MpKCW69frzX+pqKZzNzEUkVV1Aq=8_qA=g@mail.gmail.com>



> On May 13, 2024, at 10:22 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> 
> Hello,
> I saw two comments, and the first one 
> " Please add:
> stable@dpdk.org to the Cc list" then I added stable@dpdk.org to Cc. Would you like me to add it to the commit?
I thought it needs to be added to the commit message as per contributing guidelines [1].

[1] https://doc.dpdk.org/guides/contributing/patches.html#patch-for-stable-releases
> 
> Second one :
> “Set the maximum reclamation size to user provided value”  I set this comment to the header. I thought it was more meaningful in the header. If you want also, I can insert it in the description part.
I meant that we should simplify the long commit message.

> 
> Do I miss something else?
> 
> 
> On Mon, May 13, 2024 at 5:34 PM Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote:
> Hi Abdullah,
>         I do not see the changes I suggested in this version.
> 
> > On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:
> > 
> > In the previous implementation, the maximum reclamation size was set
> > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> > uses the configuration argument to set the maximum reclamation size.
> > 
> > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> > Cc: dharmik.thakkar@arm.com
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Cc: Yipeng Wang <yipeng1.wang@intel.com>
> > Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> > Cc: Bruce Richardson <bruce.richardson@intel.com>
> > Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > 
> > Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
> > ---
> > lib/hash/rte_cuckoo_hash.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> > index 9cf94645f6..f7f0fdfd21 100644
> > --- a/lib/hash/rte_cuckoo_hash.c
> > +++ b/lib/hash/rte_cuckoo_hash.c
> > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
> > if (params.size == 0)
> > params.size = total_entries;
> > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> > + params.max_reclaim_size = cfg->max_reclaim_size;
> > if (params.max_reclaim_size == 0)
> > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
> > params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> > -- 
> > 2.34.1
> > 
> 


  reply	other threads:[~2024-05-13 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <396BD6B3-B936-42F3-9FA9-B07578786FE5@arm.com>
2024-05-13 10:00 ` Abdullah Ömer Yamaç
2024-05-13 14:34   ` Honnappa Nagarahalli
2024-05-13 15:22     ` Abdullah Ömer Yamaç
2024-05-13 16:17       ` Honnappa Nagarahalli [this message]
2024-05-13 16:35         ` [PATCH v3] lib/hash: setting the maximum reclamation size Abdullah Ömer Yamaç
2024-05-14 20:52           ` Honnappa Nagarahalli
2024-06-18 14:09             ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FB7453BE-AA11-4C92-835D-CC28639CBFD2@arm.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=DharmikJayesh.Thakkar@arm.com \
    --cc=aomeryamac@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=sameh.gobriel@intel.com \
    --cc=stable@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).