From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0070.outbound.protection.outlook.com [104.47.1.70]) by dpdk.org (Postfix) with ESMTP id CBAB4288C for ; Fri, 27 Jul 2018 03:27:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekxzlKOPBIAaOGgUT8mCdcMd1N9Yt0uR89TimHsF7Ms=; b=YiMk8BogICVbwj6kRjcCw6QRjGyr3oXKzifRKYnzLGzrzRI/xM/7mf5B2u01KnRp9mQQnaOCLa/frL+GvUywnNfunVLyMJdxMwd1Z8aCKo6XIcjk8bsCEFWlnN2qmBMGmc8Ce8F7UV5BgC0ouH+jkp5t0gR2rtcdQE5WPb0X29Q= Received: from HE1PR0501MB2043.eurprd05.prod.outlook.com (10.167.245.149) by HE1PR0501MB2297.eurprd05.prod.outlook.com (10.168.34.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Fri, 27 Jul 2018 01:27:35 +0000 Received: from HE1PR0501MB2043.eurprd05.prod.outlook.com ([fe80::d522:78b6:d5c7:c16a]) by HE1PR0501MB2043.eurprd05.prod.outlook.com ([fe80::d522:78b6:d5c7:c16a%3]) with mapi id 15.20.0973.022; Fri, 27 Jul 2018 01:27:35 +0000 From: Yongseok Koh To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "stable@dpdk.org" , Luca Boccassi Thread-Topic: [PATCH] net/mlx5: fix silent error for unsupported flow items Thread-Index: AQHUHnKtUDxWeIT0ck+egrrWXFfneKSiVRaA Date: Fri, 27 Jul 2018 01:27:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2297; 6:Ghr56Ox+hhwvkyw3+HQrHNt6y6noYt9z9Xbn3zsa8yEyCygsRiXCqBzDnQUDxvsGrCZyFJISDM0AYO738sTGzvUv+xinsH/S07IrojxvniEUYH/TewJvRiYu5goPkEpQ+XTmhkHUq4Giix+r+phHQYhwjvB8wupRTy2pvsHG1jXNPG2GSxPKmn2GTexSM2f9yA9cR1ldpO7Ba9oxlUvJWFejFpwABzlO+fl5uZhqa45dan42xi8Qn4p5wg3v+jsXZyihodqcyASy52OLd7oTMHYs4d81mEQs0VaDRawMAXLMfcy8F1JvDWWcVlt6yHvwm6OPiv36UHt2KQGi4Wx+Wt/WHKRjbwPUaL8GILcnvTDFpuJRfXU8JZdc10AnZMfjCZni6KKTRc6ReyopLFxBErmxKfxzxDxNiLoVrf9htSudtTaOTKBT2pWGM4yxqwW3WCo+UhH7A+FqqZ7aXAHguA==; 5:G7wxmx5fS23KkKeY/Y2k7QnbyeWmrjo2O4xBuqDaSX9El1w2D9m+v7sIKHA1/MQAV2oM0xI2lj5uAiDs2OzO3CYmpvhrP52fgMsHRuKgKWLuEJBkcjQFLp7R86353DlyHBTIudm/rMJJ45Q00oqiTAVZDASQo5HRHAO9rcP0Yaw=; 7:/uSehVmenIt7Jf3dhQvk/szvk1yYMPCETB50P1i7e5tItWH4zmKMt8APaW5X/BL25KhPJXtdcFCBeQt68C+lR0oBzbF//IcnXSc5vwFy8uzTL29u+XD00FjGYVkvzLaA9CCgnlw09+yfOMt0177l9lB3bPJH96pNwloY9e05uWtl+xUP6nPd7RYx8Pb8CxpizGnp62HEIKcjhSdmQ6X7pIsfzU/v1zE6cbw6fCJ0NycJFZF0CJHKho69TflzbHDj x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b3791d8c-c691-4b6f-4d39-08d5f36021e2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2297; x-ms-traffictypediagnostic: HE1PR0501MB2297: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2297; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2297; x-forefront-prvs: 07467C4D33 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(136003)(366004)(39860400002)(199004)(189003)(6512007)(26005)(81156014)(83716003)(486006)(33656002)(476003)(97736004)(81166006)(76176011)(68736007)(186003)(2900100001)(106356001)(2906002)(316002)(2616005)(54906003)(8936002)(53546011)(6486002)(6506007)(6916009)(6436002)(6306002)(229853002)(105586002)(8676002)(478600001)(66066001)(36756003)(14444005)(53936002)(99286004)(82746002)(4326008)(6246003)(11346002)(6116002)(5250100002)(5660300001)(3846002)(7736002)(256004)(575784001)(86362001)(14454004)(446003)(25786009)(102836004)(305945005)(966005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2297; H:HE1PR0501MB2043.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Tvhs3p5c2roUK8HTk8+T008cIi7qLK7179Ks4GTQoq6PXttmXO4EQlGtJtOKbbTCB3y1Xoxj/64Ga3sy1Bq7IvaZ8c8JzK7IoVE2/tkT8Xgv/oMMAcublnlr1IkNYb/Md2q2f2Ep5ivIkgpJ2596vZoQN0EFdwiw+WuOTBWy301AqBgvz2BjaE5J1al0d8e+Nwx/BM3p2d3RcsAGDdCNG0oWFeJxxKQKddvyman+gH8O2eGkpqprk+/sKm25FFEWqY9xZJtVvv5xLcVUFN3eH0TMjm2kfGHvp6NCaUbk8i9IHdizqsb55b5fLiyLTm2R3jdBVDf3b7I7UFgUY97UmD9UiGJghGf0fQgvYpOf0A0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <17CE56A74F4C5A48A1442E13EFF4E866@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3791d8c-c691-4b6f-4d39-08d5f36021e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2018 01:27:34.8525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2297 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 01:27:37 -0000 Hi, Nelio This patch has already been included by different title. Can you confirm th= e patch in the following link is identical to yours and I can skip it for 17.= 11.4? https://git.dpdk.org/dpdk-stable/commit/?h=3D17.11&id=3Dfa532bac18bc3cf8efc= 9a9ecac12b5fa0b3e0d78 Thanks, Yongseok > On Jul 18, 2018, at 1:37 AM, Nelio Laranjeiro wrote: >=20 > Not supported items are causing a silent error which does not stops the > conversion of the flow rule. This silent error ends in case of a flow > create by segmentation fault. >=20 > Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") >=20 > Signed-off-by: Nelio Laranjeiro >=20 > --- >=20 > The commit impacts the following stable branches: > v17.02, v17.05, v17.08, v17.11, v18.02, v18.05 > --- > drivers/net/mlx5/mlx5_flow.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index f48b68945..8ebc0928b 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -801,8 +801,10 @@ mlx5_flow_convert_items_validate(const struct rte_fl= ow_item items[], > break; > } > } > - if (!token) > + if (!token) { > + ret =3D -ENOTSUP; > goto exit_item_not_supported; > + } > cur_item =3D token; > ret =3D mlx5_flow_item_validate(items, > (const uint8_t *)cur_item->mask, > --=20 > 2.18.0 >=20