patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Jiang, YuX" <yux.jiang@intel.com>
To: Xueming Li <xuemingl@nvidia.com>,
	Brian Dooley <brian.dooley@intel.com>,
	Akhil Goyal <gakhil@marvell.com>,
	Fan Zhang <fanzhang.oss@gmail.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Dooley, Brian" <brian.dooley@intel.com>
Subject: RE: [PATCH] test/crypto: fix callback setup tests
Date: Tue, 22 Apr 2025 06:14:25 +0000	[thread overview]
Message-ID: <IA0PR11MB8336504939A78A28D0056F6BFEBB2@IA0PR11MB8336.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20241107140926.4937-1-brian.dooley@intel.com>

Hi Xueming,
Can you pls make the patch queue to stable release 23.11.x?

> -----Original Message-----
> From: Brian Dooley <brian.dooley@intel.com>
> Sent: Thursday, November 7, 2024 10:09 PM
> To: Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>
> Cc: stable@dpdk.org; Dooley, Brian <brian.dooley@intel.com>
> Subject: [PATCH] test/crypto: fix callback setup tests
> 
> The test_deq_callback_setup and test_enq_callback_setup tests are asserting
> the incorrect case and need to be reversed to reflect correct callbacks being
> called.
> 
> Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case")
> 
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> ---
>  app/test/test_cryptodev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 6cd38aefae..005d3a87f9 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -13727,7 +13727,7 @@ test_enq_callback_setup(void)
>  			"qp %u on cryptodev %u",
>  			qp_id, ts_params->valid_devs[0]);
> 
> -	TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not
> called");
> +	TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not
> +called");
> 
>  	return TEST_SUCCESS;
>  }
> @@ -13848,7 +13848,7 @@ test_deq_callback_setup(void)
>  			"qp %u on cryptodev %u",
>  			qp_id, ts_params->valid_devs[0]);
> 
> -	TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not
> called");
> +	TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not
> +called");
> 
>  	return TEST_SUCCESS;
>  }
> --
> 2.25.1

  reply	other threads:[~2025-04-22  6:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 14:09 Brian Dooley
2025-04-22  6:14 ` Jiang, YuX [this message]
2025-04-22  8:05   ` Xueming Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IA0PR11MB8336504939A78A28D0056F6BFEBB2@IA0PR11MB8336.namprd11.prod.outlook.com \
    --to=yux.jiang@intel.com \
    --cc=brian.dooley@intel.com \
    --cc=fanzhang.oss@gmail.com \
    --cc=gakhil@marvell.com \
    --cc=stable@dpdk.org \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).