[PATCH] test/crypto: fix callback setup tests

[PATCH] test/crypto: fix callback setup tests

[Brian Dooley]

The test_deq_callback_setup and test_enq_callback_setup tests are
asserting the incorrect case and need to be reversed to reflect correct
callbacks being called.

Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case")

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
---
 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 6cd38aefae..005d3a87f9 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -13727,7 +13727,7 @@ test_enq_callback_setup(void)
 			"qp %u on cryptodev %u",
 			qp_id, ts_params->valid_devs[0]);
 
-	TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not called");
+	TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not called");
 
 	return TEST_SUCCESS;
 }
@@ -13848,7 +13848,7 @@ test_deq_callback_setup(void)
 			"qp %u on cryptodev %u",
 			qp_id, ts_params->valid_devs[0]);
 
-	TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not called");
+	TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not called");
 
 	return TEST_SUCCESS;
 }
-- 
2.25.1

RE: [PATCH] test/crypto: fix callback setup tests

[Jiang, YuX]

Hi Xueming,
Can you pls make the patch queue to stable release 23.11.x?

> -----Original Message-----
> From: Brian Dooley <brian.dooley@intel.com>
> Sent: Thursday, November 7, 2024 10:09 PM
> To: Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>
> Cc: stable@dpdk.org; Dooley, Brian <brian.dooley@intel.com>
> Subject: [PATCH] test/crypto: fix callback setup tests
> 
> The test_deq_callback_setup and test_enq_callback_setup tests are asserting
> the incorrect case and need to be reversed to reflect correct callbacks being
> called.
> 
> Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case")
> 
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> ---
>  app/test/test_cryptodev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 6cd38aefae..005d3a87f9 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -13727,7 +13727,7 @@ test_enq_callback_setup(void)
>  			"qp %u on cryptodev %u",
>  			qp_id, ts_params->valid_devs[0]);
> 
> -	TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not
> called");
> +	TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not
> +called");
> 
>  	return TEST_SUCCESS;
>  }
> @@ -13848,7 +13848,7 @@ test_deq_callback_setup(void)
>  			"qp %u on cryptodev %u",
>  			qp_id, ts_params->valid_devs[0]);
> 
> -	TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not
> called");
> +	TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not
> +called");
> 
>  	return TEST_SUCCESS;
>  }
> --
> 2.25.1

Re: [PATCH] test/crypto: fix callback setup tests

[Xueming Li]

[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]

Hi Jiang,

Thanks for reminding, patch included and created new tag v23.11.4-rc5. Please check.

Thanks,
Xueming Li
________________________________
From: Jiang, YuX <yux.jiang@intel.com>
Sent: Tuesday, April 22, 2025 2:14 PM
To: Xueming Li <xuemingl@nvidia.com>; Brian Dooley <brian.dooley@intel.com>; Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>
Cc: stable@dpdk.org <stable@dpdk.org>; Dooley, Brian <brian.dooley@intel.com>
Subject: RE: [PATCH] test/crypto: fix callback setup tests

Hi Xueming,
Can you pls make the patch queue to stable release 23.11.x?

> -----Original Message-----
> From: Brian Dooley <brian.dooley@intel.com>
> Sent: Thursday, November 7, 2024 10:09 PM
> To: Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>
> Cc: stable@dpdk.org; Dooley, Brian <brian.dooley@intel.com>
> Subject: [PATCH] test/crypto: fix callback setup tests
>
> The test_deq_callback_setup and test_enq_callback_setup tests are asserting
> the incorrect case and need to be reversed to reflect correct callbacks being
> called.
>
> Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case")
>
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> ---
>  app/test/test_cryptodev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 6cd38aefae..005d3a87f9 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -13727,7 +13727,7 @@ test_enq_callback_setup(void)
>                        "qp %u on cryptodev %u",
>                        qp_id, ts_params->valid_devs[0]);
>
> -     TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not
> called");
> +     TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not
> +called");
>
>        return TEST_SUCCESS;
>  }
> @@ -13848,7 +13848,7 @@ test_deq_callback_setup(void)
>                        "qp %u on cryptodev %u",
>                        qp_id, ts_params->valid_devs[0]);
>
> -     TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not
> called");
> +     TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not
> +called");
>
>        return TEST_SUCCESS;
>  }
> --
> 2.25.1

[-- Attachment #2: Type: text/html, Size: 5068 bytes --]