From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CF9B458C9 for ; Mon, 2 Sep 2024 04:01:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60D2840269; Mon, 2 Sep 2024 04:01:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 117C5400D7 for ; Mon, 2 Sep 2024 04:01:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725242496; x=1756778496; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=4f5uviWHNZ+09ph4xfhVtnTr7UqMi9nUd4JCTq5UEpI=; b=NYoxYPHi2ii1ZmV4tCopGB1VWjEOe1ej6fCugKl5iadPdBTlnAlaRdao QuFBLpiGRdgEWM2lh9Ij0TfbGrtnYPEhQyGQ4GJuDzctVO7DWUVuYxInx e0+kDO3OdMWio7BLEvEt2XilaP8TMJsqjwWK1mTT3y+kqjFDujPtx9c5j 6G3stLYC3uKsFlWPeIxxE12DfZIhWqpAXOY7gsQZhyYmA4QBPLnP7GU4G s8FszuQ5CALWEKGkxAK8YvDNkCCqRxFOizEod6NOSabE9ESA1laL7SzBJ 0AIEbheUDsknkpLXdgWvusGiNPRZ3Kp/Yi0XZAxSrK255YngCf4/wNXx2 w==; X-CSE-ConnectionGUID: 2bFBuc2pQZybfwuqCZU1DQ== X-CSE-MsgGUID: 2r1tXFHNSx6gmbNVn9wPqg== X-IronPort-AV: E=McAfee;i="6700,10204,11182"; a="23945026" X-IronPort-AV: E=Sophos;i="6.10,194,1719903600"; d="scan'208,217";a="23945026" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2024 19:01:34 -0700 X-CSE-ConnectionGUID: yKpGpOcHRxW6gBphMnNB7A== X-CSE-MsgGUID: e8fsBEmyQ5OAw1/YnCD8EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,194,1719903600"; d="scan'208,217";a="69265230" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Sep 2024 19:01:34 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 1 Sep 2024 19:01:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Sun, 1 Sep 2024 19:01:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Sun, 1 Sep 2024 19:01:33 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sun, 1 Sep 2024 19:01:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HBxLREKLrdSR0PiS83xkVcXVnRZIGNrR21NmmR2poGGw5+GAEXwORs++v8Bcpu/h+vF10UytsWA0QOZ2nJiObxCAliMCm2W1iajn04jJsYb53HrpSR5bt/KQWyx0klR+nEn3l0j6kbOnroVP1URqgDqRJ1HBAv4DHuWm6s1a0O+KNLs9/6bock5Bya5J9ntM5vPPev5Nxq69Sd3UdsS1fMzyBVnjJu7f+jd5ZQ75Eok7a6nR0h1qnqLYdc5zvJRNHzX4RV3Yge/88PUx1nFGLDxOvNaqy4ITaFQL0tOsiB3eFsdza+c9g+uZrFdxKrsXKMPtIZpMzd/bgHzu6VhorA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VMjIhzKxmIr5VjuuJKM04emVlpyJx6GeYOkeumzF4Zs=; b=OSu3jAW6fYGpmBVo3bFRWQkq4o2oA+PcPH+rd9CUCnU/kfxqQ6RidK6SCfXSUTb7iITrJPPdrqrk3IW0zrZzg0tKEJG93gzNOV7XyA4dIBwMCwJU4Er+cQ4nvaNPrNdoLe1xPqz7hKAIK9u88kMN4xtA4jh3IkLwEpetjFwDspwVyeYXDMKCY1roY8q0E/t1lQxw1JNiifx+Hf8TIWkOp54p3/A0VgtsxdezI0UE6iYmstGaDuWZZWs/zZIV8waLxyuegDZFc17toUsY2+hqVmI643SL5aHLysHMLl2cIvfV7xrKKpT3mhXva4c7s4VDF7W0HcFiTeWB1mug9Zapag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA0PR11MB8336.namprd11.prod.outlook.com (2603:10b6:208:490::22) by SJ2PR11MB7600.namprd11.prod.outlook.com (2603:10b6:a03:4cd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.23; Mon, 2 Sep 2024 02:01:30 +0000 Received: from IA0PR11MB8336.namprd11.prod.outlook.com ([fe80::46a3:ee0:a7c5:8518]) by IA0PR11MB8336.namprd11.prod.outlook.com ([fe80::46a3:ee0:a7c5:8518%7]) with mapi id 15.20.7897.021; Mon, 2 Sep 2024 02:01:30 +0000 From: "Jiang, YuX" To: Xueming Li , "Ye, MingjinX" , "Xu, HailinX" CC: dpdk stable Subject: RE: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Topic: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Index: AQHa1EtNp7cjU9/DSEGK5VUvDl/LL7H6N38AgEeKToCAAkYRUA== Date: Mon, 2 Sep 2024 02:01:30 +0000 Message-ID: References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712110153.309690-1-xuemingl@nvidia.com> <20240712110153.309690-21-xuemingl@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR11MB8336:EE_|SJ2PR11MB7600:EE_ x-ms-office365-filtering-correlation-id: c60ed325-551a-42f0-a008-08dccaf32985 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?atjxRK9x64d/UCbdnwaG8EfLDfKj6ngPQwizJIVGh7OFAH/d+ELMomLCy5/K?= =?us-ascii?Q?DycKxxaP8kpdLI4i2NToQ/Pfx9opdmzB5rKQmZF30is7KbpUDhXCV1MxuPe2?= =?us-ascii?Q?T+vihbglTFC8+NIT86YEXEdLI+kIiWxab/zl55aXp1oGro2BYJTbQ+pKqvCH?= =?us-ascii?Q?o6gMaDw981qD0C6PMLawDucFp7TrYuSGUiLfMdRdjXTbKJ2TIQ6ZOjLTWYM7?= =?us-ascii?Q?jiEiufSEpOVnmT69ppy5bejnCkmSMIyPnsD8IL7N8RC7WKaxbcBH+OIwLBq7?= =?us-ascii?Q?uZyVbWz1lHPfd1LF7/csb+HWwWnxaH2X1iQKsGYwsd3DBGi/QAPjqBPYau0U?= =?us-ascii?Q?SKcG/4R3Xna8QCF+f9YS0FtYEk8vuhTL9EiLqww2MIj8AZ5bEbPh08r0qn8/?= =?us-ascii?Q?YHcjobLIRg9fVTPzfCr6eMh9poZnfS+QQ6ZBuluAVhCSVRcScdCwH31Nf6JF?= =?us-ascii?Q?Y0NDXpkbd6R94ai+OeQR3yX8ct6E74y/5kpHXQJvOInCTssNab7GLo5HV/RR?= =?us-ascii?Q?Z2Vuipql/dshRQxVeOZqPwsI7fn4pf6KREMvd3Wdr3e1YJ1WOa1PmsRyf9Nq?= =?us-ascii?Q?3RIyoP26CkZLN7XNjZ1zuzJlz3cwpaNxhhU70nnD2XZf7kjTH6Smp7Z5jhPM?= =?us-ascii?Q?4uRfTvWwDCnM0AsVcCu+qNkcG0+5t/fB6BtGgjnpVotOPVwUPzEznJMln29m?= =?us-ascii?Q?cy196pAIDZrioCsz7EyRbj1MT/CyU6Md0oQTAHnD8pv0kJjhSLVgoXZj1J2E?= =?us-ascii?Q?IzCfqZboOgEDPRPDiIEXlkVRdf3NquMiiB1o3mCdyII7skNT8XQpMFGZp5yV?= =?us-ascii?Q?ubTnIgWwKmXuA5T/jIDD3nD1xq/aBi7Jzed2n2ghPZgwtPwFuBIOL1oBl0Bf?= =?us-ascii?Q?ph1tu+71xL4TAAO9viuxiYcxi6v2o0VqRtpQH9EiQ5bjbM4z8/CfcDjwdI4h?= =?us-ascii?Q?4aAoG2IlJAomF+NYI8hr1W3g+OEPRUMECWa/6sbzPLbeVjXoXw40IKc+5aHs?= =?us-ascii?Q?Dz9no1ke4+IyhB0IQXuRGjsTkYEELPWYiqrpZFYAlTuh6mn0Jn+sf0vk6gch?= =?us-ascii?Q?p7l4z7HAS76g0jMrH2LcAJ47IqdMYOhf26sYTXGPyG8pbm7+D5/5+yZKB+WN?= =?us-ascii?Q?TZX7hh7dm8rSCLYw0OGi1iNVNryaK7jRHA4iR470oERhYDQlbojAkQV1jYLI?= =?us-ascii?Q?mof06bUP9dIZr1osQrhlk/8gU8g1gtWBVkiMCFMywg6A7KYVPu8ch3m1hO6i?= =?us-ascii?Q?bkbTaAb7LetnvJ1DZ+doQ94/kyipncYl0FXDlxitfN6oXRliKy98GWwg6pyu?= =?us-ascii?Q?5xgkP5B0vpLQbnsEgErdtxqDQYbBL2nqtVkN53C+AJHdOD313XowwTd+vxXx?= =?us-ascii?Q?OF6cwao=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA0PR11MB8336.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FHEMb01sxcnPYl0U8AMKHp6ziUfHMCrY3kH9+8bf8Hbv4GN6DeNc1STRGJLW?= =?us-ascii?Q?A+H//lk9whDPW0LaXgKOQy/394T2ERyqhxV3F11X55Xs5RQ4WFDejQKqTIu4?= =?us-ascii?Q?w67VjaGQ05hkNJDfnfe4OOObJe/1qZYD3nHNSm7v0hN+U1wBAB2wyZNIm7eV?= =?us-ascii?Q?2wqyymXhWN24fJV7gh2WCXMonv2CXebV5rp4OE/NZOgLrR90Isfnc+At4AUd?= =?us-ascii?Q?GZkoeuv2ExQEG0cY7U3ydW2hls511Y2jmqFQjsUsmj3ZmdscUFrv9oir/1yB?= =?us-ascii?Q?ZxpyFNjv1vqisdghIUxKxKz4b36ziktZEjIYvrAnzYHtn+kNrCcDRkfJN+x/?= =?us-ascii?Q?Je7c8ZjPtkwUSME5p963ImQBeeMcZhCumXnPCUCnZwHgsH8K8oIEiZQ1cdLu?= =?us-ascii?Q?XNCt5Ap/ukXyWWCwSUcJk+3qO40giGHrLzSo+PVt8hYY/YF4s9ptNCptUoCq?= =?us-ascii?Q?N6st55uMLlC2rg6QCQgCUEnILObOElgvVaTApkURVnioiSsmKpUsqqKQdXTs?= =?us-ascii?Q?T5Mf6tR1Z9eG7XPtUf5sHadBvQgVlSiDkA8Xia9sgJRDrADjNyFExx+jlPnl?= =?us-ascii?Q?LOAqmEzwwGNjHmJDKsaaLVH8k3VcK5/J/NXO1iWqpthlhwmGPWsvG9zWjPjq?= =?us-ascii?Q?7C/AcqK8wkj/Jh/facwMfWCWhebxo6nUBEMjMX0QHMC2jaW7OX7CG8cLLusj?= =?us-ascii?Q?uiJr+robWndj+0A3wb+gi1PUdYWmc9uCH5JwzMwPX6dvgOv6jmRieHOOQfUi?= =?us-ascii?Q?/n6NgEvcrIgaaKkfDqFpuCR/IFgGUKCGxw0HEV4s2QMFpC3NcQ7BRqI4x6Qf?= =?us-ascii?Q?M9WrldwrX6ARoxse2aa97FI+/nD7/tBO/Duz9ax78mVrZ0pFVYQRGwyxflaL?= =?us-ascii?Q?o8CCDFu+5gBuYrq87FkjpIhfEskT9d9oTgbMKbBv5hFhHzh4mmyHFlTxpj0l?= =?us-ascii?Q?tNfMfaC8Qa1iX9GaKDHL/7UUe8rADFHeBLVTzlRn8R7KFfNu5LoJ48fk2oj2?= =?us-ascii?Q?IFBNbsSOOEvErEm/SrdIjg7zSWb5FSXTF8QzbwsAyKf7moR64RftFB4O4RFb?= =?us-ascii?Q?DnwcvdZda2uHPEImRmtRo80wUQ1W7/HJjBVizmrhfUS1OQkx2CtQEqU2dgb0?= =?us-ascii?Q?+va9MuW5j1SW0CTq+XTG6oZ0i3Ob5YbyJL64RTYr7986vSwLIwoV5Wd0kMpJ?= =?us-ascii?Q?Sq66gDJdI83YeKSApjDaBzonZ6xAilL4AiXTkIspkgjOElkkvJ+lGF28afii?= =?us-ascii?Q?thi+em3KHYGjwmOO7RgzIeSs6xHWH9SE36hakt99RL0kiJ87pvLYPdZfnFIt?= =?us-ascii?Q?R98py4joQqV+Kl3nQ4GxougV4sM/87COPVHLdeb5LPveKo3K3Qs98LMUjbg9?= =?us-ascii?Q?giIhUJKb53SVhyy2pBUe99nweyBpQjr7N5NxfPIoBx0H2vJ/9JvopFweZur/?= =?us-ascii?Q?8HPhAODx0TVCHhp5/XrCD3DUSWDL0PKAn9NBesh24d7oe/3rco7rclsoKf14?= =?us-ascii?Q?q/r6AAZ1RITVxSzByjuqJYi5rni2piIPUWqNUuvQG3rwor2H8XoFIPWwTpf3?= =?us-ascii?Q?Nk2e3SSBniHT7q3wJzM=3D?= Content-Type: multipart/alternative; boundary="_000_IA0PR11MB8336D1405A153D533BE2FF8CFE922IA0PR11MB8336namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB8336.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c60ed325-551a-42f0-a008-08dccaf32985 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2024 02:01:30.2161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yQeNHEZvrSMTAwEa2mGcPIzUdxSoLHLAa4tlX0UQ0tLi0ri0UgDGPN/VOqKPc6akpbqI3FxO+nEp+C7mnwbD+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7600 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --_000_IA0PR11MB8336D1405A153D533BE2FF8CFE922IA0PR11MB8336namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Xueming, Yes, we need the fix. It should be backporting to 23.11.x, since the previous commit "bus/vdev: f= ix devargs in secondary process" which is also backporting to 23.11.1 that = cause bug 1450 - Regression: vdev device not setup in secondary process (dp= dk.org) exists in 23.11 stabl= e branch. This bug's resolution is the fix (http://git.dpdk.org/dpdk/commit/?id=3D22c= e39b3aa) in main branch, so pls schedule this fix patch to 23.11.3. root@virtio-tester-217:~/jiangyu/LTS/dpdk# git show 6148604a43 commit 6148604a438aad21e5d74f414976666b370582c1 Author: Mingjin Ye mingjinx.ye@intel.com Date: Fri Sep 1 07:24:09 2023 +0000 bus/vdev: fix devargs in secondary process [ upstream commit 6666628362c94a0b567a39a0177539c12c97d999 ] When a device is created by a secondary process, an empty devargs is temporarily generated and bound to it. This causes the device to not be associated with the correct devargs, and the empty devargs are not released when the resource is freed. This patch fixes the issue by matching the devargs when inserting a device in secondary process. Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") Fixes: a16040453968 ("eal: extract vdev infra") Signed-off-by: Mingjin Ye mingjinx.ye@intel.com Acked-by: Anatoly Burakov anatoly.burakov@intel.com Best regards, Yu Jiang From: Xueming Li Sent: Saturday, August 31, 2024 10:51 PM To: Ye, MingjinX ; Xu, HailinX Cc: dpdk stable Subject: Re: patch 'bus/vdev: revert fix devargs in secondary process' has = been queued to stable release 23.11.2 Hi Hailin, This patch was originally queued to 23.11.2 list, but removed per Mingjin's= request. If we do need the fix, let's schedule it to 23.11.3. Regards, Xueming ________________________________ From: Ye, MingjinX > Sent: Wednesday, July 17, 2024 10:21 AM To: Xueming Li > Cc: dpdk stable > Subject: RE: patch 'bus/vdev: revert fix devargs in secondary process' has = been queued to stable release 23.11.2 Hi, Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything. Thanks, Mingjin > -----Original Message----- > From: Xueming Li > > Sent: Friday, July 12, 2024 7:02 PM > To: Ye, MingjinX > > Cc: dpdk stable > > Subject: patch 'bus/vdev: revert fix devargs in secondary process' has be= en > queued to stable release 23.11.2 > > Hi, > > FYI, your patch has been queued to stable release 23.11.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 07/14/24. So please shout= if > anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging > > This queued commit can be viewed at: > https://git.dpdk.org/dpdk-stable/commit/?h=3D23.11- > staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b > > Thanks. > > Xueming Li > > > --- > From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > From: Mingjin Ye > > Date: Thu, 14 Mar 2024 09:36:28 +0000 > Subject: [PATCH] bus/vdev: revert fix devargs in secondary process > Cc: Xueming Li > > > [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > > The ASan tool detected a memory leak in the vdev driver alloc_devargs. Th= e > previous commit was that when inserting a vdev device, the primary proces= s > alloc devargs and the secondary process looks for devargs. This causes th= e > device to not be created if the secondary process does not initialise the= vdev > device. And, this is not the root cause. > > Therefore the following commit was reverted accordingly. > > After restoring this commit, the memory leak still exists. > > Bugzilla ID: 1450 > Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") > > Signed-off-by: Mingjin Ye > > --- > drivers/bus/vdev/vdev.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args) > return devargs; > } > > -static struct rte_devargs * > -vdev_devargs_lookup(const char *name) > -{ > - struct rte_devargs *devargs; > - char dev_name[32]; > - > - RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { > - devargs->bus->parse(devargs->name, &dev_name); > - if (strcmp(dev_name, name) =3D=3D 0) { > - VDEV_LOG(INFO, "devargs matched %s", dev_name); > - return devargs; > - } > - } > - return NULL; > -} > - > static int > insert_vdev(const char *name, const char *args, > struct rte_vdev_device **p_dev, > @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, > if (name =3D=3D NULL) > return -EINVAL; > > - if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) > - devargs =3D alloc_devargs(name, args); > - else > - devargs =3D vdev_devargs_lookup(name); > + devargs =3D alloc_devargs(name, args); > > if (!devargs) > return -ENOMEM; > -- > 2.34.1 > > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2024-07-12 18:40:18.570682691 +0800 > +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch 202= 4- > 07-12 18:40:14.356594197 +0800 > @@ -1 +1 @@ > -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00 > 2001 > +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > > + > +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > @@ -20 +22,0 @@ > -Cc: stable@dpdk.org --_000_IA0PR11MB8336D1405A153D533BE2FF8CFE922IA0PR11MB8336namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Xueming,

 

Yes, we need the fi= x.

It should be backpo= rting to 23.11.x, since the previous commit “bus/vdev: fix devargs in= secondary process” which is also backporting to 23.11.1 that cause b= ug 1450 – Regre= ssion: vdev device not setup in secondary process (dpdk.org) exists in = 23.11 stable branch.

This bug’s re= solution is the fix (http://git.dpdk.org/dpdk/commit/?id=3D22ce39b3aa) in main branch= , so pls schedule this fix patch to 23.11.3.

 

root@virtio-tester-= 217:~/jiangyu/LTS/dpdk# git show 6148604a43

commit 6148604a438a= ad21e5d74f414976666b370582c1

Author: Mingjin Ye = mingjinx.ye@intel.com

Date:   F= ri Sep 1 07:24:09 2023 +0000

 

    = bus/vdev: fix devargs in secondary process

 

    = [ upstream commit 6666628362c94a0b567a39a0177539c12c97d999 ]

 

    = When a device is created by a secondary process, an empty devargs is

    = temporarily generated and bound to it. This causes the device to not

    = be associated with the correct devargs, and the empty devargs are not<= /o:p>

    = released when the resource is freed.

 

    = This patch fixes the issue by matching the devargs when inserting a

    = device in secondary process.

 

    = Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct&quo= t;)

    = Fixes: a16040453968 ("eal: extract vdev infra")=

 

    = Signed-off-by: Mingjin Ye mingjinx.ye@intel.com

    = Acked-by: Anatoly Burakov anatoly.burakov@intel.com<= o:p>

 

Best regards,<= /o:p>

Yu Jiang=

 

From: Xueming Li <xuemingl@nvidia= .com>
Sent: Saturday, August 31, 2024 10:51 PM
To: Ye, MingjinX <mingjinx.ye@intel.com>; Xu, HailinX <hail= inx.xu@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: patch 'bus/vdev: revert fix devargs in secondary proces= s' has been queued to stable release 23.11.2

 

Hi Hailin,

 =

This patch was originall= y queued to 23.11.2 list, but removed per Mingjin's request. If we do need = the fix, let's schedule it to 23.11.3.

 =

Regards,

Xueming

From: Ye, Mi= ngjinX <mingjinx.ye@int= el.com>
Sent: Wednesday, July 17, 2024 10:21 AM
To: Xueming Li <xu= emingl@nvidia.com>
Cc: dpdk stable <stabl= e@dpdk.org>
Subject: RE: patch 'bus/vdev: revert fix devargs in secondary proces= s' has been queued to stable release 23.11.2

 

Hi,

Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything.

Thanks,
Mingjin

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Friday, July 12, 2024 7:02 PM
> To: Ye, MingjinX <<= span style=3D"font-size:11.0pt">mingjinx.ye@intel.com>
> Cc: dpdk stable <stable@dpdk.org>
> Subject: patch 'bus/vdev: revert fix devargs in secondary process' has= been
> queued to stable release 23.11.2
>
> Hi,
>
> FYI, your patch has been queued to stable release 23.11.2
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-= stable yet.
> It will be pushed if I get no objections before 07/14/24. So please sh= out if
> anyone has objections.
>
> Also note that after the patch there's a diff of the upstream commit v= s the
> patch applied to the branch. This will indicate if there was any rebas= ing
> needed to apply to the stable branch. If there were code changes for > rebasing
> (ie: not only metadata diffs), please double check that the rebase was=
> correctly done.
>
> Queued patches are on a temporary branch at:
> https://git.dpdk.org/dpdk-stable/log/= ?h=3D23.11-staging
>
> This queued commit can be viewed at:
> https://git.dpdk.org/dpdk-stable/commit/?= h=3D23.11-
> staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b
>
> Thanks.
>
> Xueming Li <xuemingl@nvidia.com>
>
> ---
> From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> From: Mingjin Ye <<= span style=3D"font-size:11.0pt">mingjinx.ye@intel.com>
> Date: Thu, 14 Mar 2024 09:36:28 +0000
> Subject: [PATCH] bus/vdev: revert fix devargs in secondary process
> Cc: Xueming Li <xuemingl@nvidia.com>
>
> [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
>
> The ASan tool detected a memory leak in the vdev driver alloc_devargs.= The
> previous commit was that when inserting a vdev device, the primary pro= cess
> alloc devargs and the secondary process looks for devargs. This causes= the
> device to not be created if the secondary process does not initialise = the vdev
> device. And, this is not the root cause.
>
> Therefore the following commit was reverted accordingly.
>
> After restoring this commit, the memory leak still exists.
>
> Bugzilla ID: 1450
> Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process&= quot;)
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
>  drivers/bus/vdev/vdev.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)=
>        return devargs;
>  }
>
> -static struct rte_devargs *
> -vdev_devargs_lookup(const char *name)
> -{
> -     struct rte_devargs *devargs;
> -     char dev_name[32];
> -
> -     RTE_EAL_DEVARGS_FOREACH("vdev", de= vargs) {
> -           &nb= sp; devargs->bus->parse(devargs->name, &dev_name);
> -           &nb= sp; if (strcmp(dev_name, name) =3D=3D 0) {
> -           &nb= sp;         VDEV_LOG(INFO, "de= vargs matched %s", dev_name);
> -           &nb= sp;         return devargs;
> -           &nb= sp; }
> -     }
> -     return NULL;
> -}
> -
>  static int
>  insert_vdev(const char *name, const char *args,
>            = ;    struct rte_vdev_device **p_dev,
> @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, >        if (name =3D=3D NULL)
>            = ;    return -EINVAL;
>
> -     if (rte_eal_process_type() =3D=3D RTE_PROC_P= RIMARY)
> -           &nb= sp; devargs =3D alloc_devargs(name, args);
> -     else
> -           &nb= sp; devargs =3D vdev_devargs_lookup(name);
> +     devargs =3D alloc_devargs(name, args);
>
>        if (!devargs)
>            = ;    return -ENOMEM;
> --
> 2.34.1
>
> ---
>   Diff of the applied patch vs upstream commit (please doubl= e-check if non-
> empty:
> ---
> --- - 2024-07-12 18:40:18.570682691 +0800
> +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch &= nbsp;     2024-
> 07-12 18:40:14.356594197 +0800
> @@ -1 +1 @@
> -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00
> 2001
> +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00
> 2001
> @@ -4,0 +5,3 @@
> +Cc: Xueming Li <xuemingl@nvidia.com>
> +
> +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ]
> @@ -20 +22,0 @@
> -Cc: stable@dpdk.org<= /o:p>

--_000_IA0PR11MB8336D1405A153D533BE2FF8CFE922IA0PR11MB8336namp_--