* [PATCH] net/igc: fix xstats name
@ 2025-04-09 1:07 Kaiwen Deng
2025-04-09 3:55 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Kaiwen Deng @ 2025-04-09 1:07 UTC (permalink / raw)
To: dev; +Cc: stable, Kaiwen Deng, Ferruh Yigit, Alvin Zhang
The xstats name needs to be changed correctly
tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.
Fixes: e6defdfddc3b ("net/igc: enable statistics")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/intel/e1000/igc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
index e712cfcf7c..68444e4fba 100644
--- a/drivers/net/intel/e1000/igc_ethdev.c
+++ b/drivers/net/intel/e1000/igc_ethdev.c
@@ -181,7 +181,7 @@ static const struct rte_igc_xstats_name_off rte_igc_stats_strings[] = {
{"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats, ptc511)},
{"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
ptc1023)},
- {"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
+ {"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
ptc1522)},
{"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
{"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/igc: fix xstats name
2025-04-09 1:07 [PATCH] net/igc: fix xstats name Kaiwen Deng
@ 2025-04-09 3:55 ` Stephen Hemminger
2025-04-10 6:57 ` Deng, KaiwenX
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2025-04-09 3:55 UTC (permalink / raw)
To: Kaiwen Deng; +Cc: dev, stable, Ferruh Yigit, Alvin Zhang
On Wed, 9 Apr 2025 09:07:11 +0800
Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
> The xstats name needs to be changed correctly
> tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.
>
> Fixes: e6defdfddc3b ("net/igc: enable statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/intel/e1000/igc_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
> index e712cfcf7c..68444e4fba 100644
> --- a/drivers/net/intel/e1000/igc_ethdev.c
> +++ b/drivers/net/intel/e1000/igc_ethdev.c
> @@ -181,7 +181,7 @@ static const struct rte_igc_xstats_name_off rte_igc_stats_strings[] = {
> {"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats, ptc511)},
> {"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
> ptc1023)},
> - {"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
> + {"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
> ptc1522)},
> {"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
> {"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},
Please don't send same patch twice.
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] net/igc: fix xstats name
2025-04-09 3:55 ` Stephen Hemminger
@ 2025-04-10 6:57 ` Deng, KaiwenX
0 siblings, 0 replies; 3+ messages in thread
From: Deng, KaiwenX @ 2025-04-10 6:57 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, stable, Ferruh Yigit, Alvin Zhang
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, April 9, 2025 11:56 AM
> To: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>;
> Alvin Zhang <alvinx.zhang@intel.com>
> Subject: Re: [PATCH] net/igc: fix xstats name
>
> On Wed, 9 Apr 2025 09:07:11 +0800
> Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
>
> > The xstats name needs to be changed correctly
> > tx_size_1023_to_max_packets should be tx_size_1024_to_max_packets.
> >
> > Fixes: e6defdfddc3b ("net/igc: enable statistics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > ---
> > drivers/net/intel/e1000/igc_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/intel/e1000/igc_ethdev.c
> > b/drivers/net/intel/e1000/igc_ethdev.c
> > index e712cfcf7c..68444e4fba 100644
> > --- a/drivers/net/intel/e1000/igc_ethdev.c
> > +++ b/drivers/net/intel/e1000/igc_ethdev.c
> > @@ -181,7 +181,7 @@ static const struct rte_igc_xstats_name_off
> rte_igc_stats_strings[] = {
> > {"tx_size_256_to_511_packets", offsetof(struct e1000_hw_stats,
> ptc511)},
> > {"tx_size_512_to_1023_packets", offsetof(struct e1000_hw_stats,
> > ptc1023)},
> > - {"tx_size_1023_to_max_packets", offsetof(struct e1000_hw_stats,
> > + {"tx_size_1024_to_max_packets", offsetof(struct e1000_hw_stats,
> > ptc1522)},
> > {"tx_multicast_packets", offsetof(struct e1000_hw_stats, mptc)},
> > {"tx_broadcast_packets", offsetof(struct e1000_hw_stats, bptc)},
>
>
> Please don't send same patch twice.
Hi Stephen,
Thanks for your review.
The two patches I posted earlier were fixes for the same issue for both igb and igc drivers.
Now I merged those two patches into one patch to fix the issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-10 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-09 1:07 [PATCH] net/igc: fix xstats name Kaiwen Deng
2025-04-09 3:55 ` Stephen Hemminger
2025-04-10 6:57 ` Deng, KaiwenX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).