From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0438045629 for ; Wed, 17 Jul 2024 04:21:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD2C840299; Wed, 17 Jul 2024 04:21:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id DBF494025F for ; Wed, 17 Jul 2024 04:21:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721182905; x=1752718905; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nh2pdZt7hkyYNP7CNeOuQKdvgRVyhOJQxGL+bBPZmyE=; b=WYGv5hNibWdHSFvOzvMFMaFRfXz/AUBZGnuMu/Lt21N2DKE3I+nBulwn d94rzkGXUPLw1oFH7QRojEHkY3PPuzLj7OuTtdSDP1bOIfhnAfAxJVk7Z xovr6CTljIEakQ2S4clXEPfQ3FMIOrQLKhchp+b/ZlZfnGVqxsC50w0is OkWLRdzb445s2bvHHoOxayNffsUw/rMAicGewgHefOdYiGmFFVOoJJyfb uUrzIIM2MeGQFcWeC0y4Otpo9gfmSRUS7EpK1bbeUKVOJkb+PKGKNtJ/3 HvDe4D/bchu1Y1NiZS6yqCMmpWUa/3jY6bWXqLDb4FLq+SezO9R/F5jcX A==; X-CSE-ConnectionGUID: UCJA6WKmRvKHdhd4fG+erg== X-CSE-MsgGUID: eYm4NMe2SSqoeDUq48utXA== X-IronPort-AV: E=McAfee;i="6700,10204,11135"; a="29247435" X-IronPort-AV: E=Sophos;i="6.09,213,1716274800"; d="scan'208";a="29247435" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2024 19:21:43 -0700 X-CSE-ConnectionGUID: KEwy7tJpSDyIzbn6JieKPQ== X-CSE-MsgGUID: Yn5gJHVbT+OS5nDPuny/xg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,213,1716274800"; d="scan'208";a="55375107" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Jul 2024 19:21:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 16 Jul 2024 19:21:42 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 16 Jul 2024 19:21:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 16 Jul 2024 19:21:41 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 16 Jul 2024 19:21:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rCwuE6BCInA7jWlPe7Ut+7eI1i3fLimA6xVFb2yD1+RbmHJ2C1QJe8Vwev9c9f87dgtWlLKzsobCNWgicGk7ql59hGlJS/F5Uept4rsiJGiK7yDHx24hmBJxJ4twNf7wDVDMME+ewjppAG14AIT7ICzJma/048vi0/99ykn2CJSUo0+P6nmj0pfnZbfLbrb9wGvXOzckauc6vlSOX/9mNpD80Dee2hwUCrndCfpzqfyuaN1IO4Owxn8X95+p06IxlyeYdmY4uvYHds73vC8JZdhg4Lvbmh3Gd/yQbmyOX1YTceaTTwuUZ1m2SczqDUBXswFzuY3LxY1G6heRaN3WrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zcV5EiD2TaOgUs14uiB9qB/zT/yDleuLaY+nx+YdoKg=; b=aMylsowDZ8RDsFCYbVCv7MCiuuZGQJjG89udtY9OQszm/NyCYZX/PQaCqSwSV8KFuoDZnv3MOeU1THCt8o0eXv3QegsWY7DvnGSeT3MKP2ETot14j6hN+xK8kwJ0GzohJ0V8tDgH0b0ZuTnxj2eq6vSAShgO8PxdTTDmktR5vppcHC2YkSn/dUhvZ2CCFI3NYDnLIDvPDTyqby0YELLWrMUNhga8UKBPEvCGcOachKWsNb3+wplvSXK+Xi3+tIqdWy5CyqWZhlVRS4T2PhI5lDK34w5xW2yWT+YETKvR34Y/I2qOqbAiZlXdppK7fBDYj/HlZ7hubJ8+5UklmGS+og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV3PR11MB8601.namprd11.prod.outlook.com (2603:10b6:408:1b8::8) by DS7PR11MB7952.namprd11.prod.outlook.com (2603:10b6:8:eb::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.28; Wed, 17 Jul 2024 02:21:34 +0000 Received: from LV3PR11MB8601.namprd11.prod.outlook.com ([fe80::7878:b054:82bf:b5b]) by LV3PR11MB8601.namprd11.prod.outlook.com ([fe80::7878:b054:82bf:b5b%3]) with mapi id 15.20.7784.015; Wed, 17 Jul 2024 02:21:34 +0000 From: "Ye, MingjinX" To: Xueming Li CC: dpdk stable Subject: RE: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Topic: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.2 Thread-Index: AQHa1EtIJysnk16aF0mMy80vNbGpVLH6NDFg Date: Wed, 17 Jul 2024 02:21:34 +0000 Message-ID: References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712110153.309690-1-xuemingl@nvidia.com> <20240712110153.309690-21-xuemingl@nvidia.com> In-Reply-To: <20240712110153.309690-21-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV3PR11MB8601:EE_|DS7PR11MB7952:EE_ x-ms-office365-filtering-correlation-id: b5fb3f01-8ea7-47ce-159a-08dca6072df7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?cb1k1mMmHN/StkqiK0L+l4TQKdsVCRGYNEnIOvh9p3IHiC7x54o4zQe0sBGZ?= =?us-ascii?Q?GOd0qfDhDnri34a97M33DZb0txNnOMjZwhTV6lzW4axu4NpwoBRCN/XDGoCD?= =?us-ascii?Q?6hZxDYmnGCNchGhNgPQlUdekENXxolU1zb265KIPBq2kwMAZWErH7FI0rjil?= =?us-ascii?Q?XF8BeGACCH6E3SJqF/RS5C6zIz5doSMFRy2T6bN1taXnmu6nmSSd6erzKEkE?= =?us-ascii?Q?DcksAvwMo7hFionLF44L4KbLQflYSCQ1YkpGfhA4s1bgqIfqYWv5Uk6li6sv?= =?us-ascii?Q?eyaal+tPZR/QmEZnTdZE9jit9zlfkqvoa5sbzX52925hxBMvUFh6YudB33TR?= =?us-ascii?Q?SZJZ+3FsTr22vMwwzV/0P5HIGDuUSTQmYKDMlWKJ9YTMNssDOABU2ytfBYVz?= =?us-ascii?Q?Zz6DuVNfEfbCPTOK0ZpDRFP28yc0BWaJWycjS346X+pSpZnIBi60zrapIoN+?= =?us-ascii?Q?5ri2uyOpXF1OyUdXAcH7BFFzq6pVzv9A1IHlEJ79MVQ7eeGAXttmb7ymkQD7?= =?us-ascii?Q?ennAslvWspFFdzYeBrLhAnx6jNo9UXTTcPYed1XmzXzpPJrjuChIqZg6Y95O?= =?us-ascii?Q?Xt3Qs+MSwMGcmDWV3dmFBFaa3eQ7TK4cB97EZCpVuR+7lNsTVIzqXeHL0MTt?= =?us-ascii?Q?dOzKe1PDz/rtwvhxoMNVEWq98s2zcGStfpp/xN6Urdwaqv1FenrHIUpNSro0?= =?us-ascii?Q?+O8MtNFwXhNx89oMEO+zHOmDfw9VR3V/lTacC/5xwOX+JKJE7Z/9dU+RCG5f?= =?us-ascii?Q?bdOfk+nNk5p5augk2b98jOer2iJZseuHtpBFCCrcWFtxJYAJ4wOq24MXpDf/?= =?us-ascii?Q?tJgmLkC8CEpLYw1eLZT2+YQljXdFKYDGZRAPj7WQtVYMP6og0Mq9BtsDC21c?= =?us-ascii?Q?9jWeifFTOh9D28dZPrEVI2w0Qnt8zZDNWb02faVhHqb/FApmtMGUZRbRXfH3?= =?us-ascii?Q?M02sV4wFXnRLPwgiefZ/xlhIIm6CpjVA+THT8R7Ajjv9E2y9g+1qwCCdxz1o?= =?us-ascii?Q?NhpWEIYkgknIE208JneD57Cu/qMLbSnPmbrTfKqICx9/CvtM291d9T2lEMn1?= =?us-ascii?Q?TgssVn4AzuGUkxCpgxKBi7XhG244NPJLzhkq6eWWaHAvtxRm1SrFFjKWNVr4?= =?us-ascii?Q?8iL0eY5PMBvxHGxWTEys6cMAswN4M1/P4M8z7EmxM4Rcoa8YLWsFwOuX5f4l?= =?us-ascii?Q?Gep8rTgiJpkCIsFm8FOQKfK9OfKYcxBu46K+enIqUvCs1q68SYnZhm4nkno0?= =?us-ascii?Q?jio9rTcjP5cmITnhK9G0SiRwPQdJqvcyJtORAoU2Dppnk/MGl29cpMqQV6On?= =?us-ascii?Q?hBS3PIkcgnrVbW4TM1Hls9y05nc6pJBa71VYOgcdiXZkstokOjnSuyaAG+OD?= =?us-ascii?Q?H/NFkm4=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV3PR11MB8601.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B+RZg8SkicdgL+cVfvIgt6NfRTjBA+c+DQlY3jYFtnH44WWpB3hkgDmaU7qw?= =?us-ascii?Q?83v+W0diBse8Ssv/12b4tdn2ZtfkmjkWyCvLeRMNjX7nPtSfAFDnkygwF2GI?= =?us-ascii?Q?aVGEfjo7yDZEuNfTjnujMlQ0qJ+2XS5046GpGk6iiLmQKU7j8PFg7t8kuxxU?= =?us-ascii?Q?S4IdUBj2zB197b4N+2o1djAHmiihsFJDwmgfzM/DgL0oGlvkXuqBu/rB1Au4?= =?us-ascii?Q?jH+FRH761QlW5HF8PduF5Z9HMpU1bR/4BUWqYRqrJiKSgmXYVCKC0OGsxXfI?= =?us-ascii?Q?1trBWktl7obUb9+7JzJzjLUNQW5PF9/SnOpvIOVOsBgg3KorOzTX3d7duOf5?= =?us-ascii?Q?h0LdRTH0ck8A1uOE8dfpjSCZOgFBD9KYn3gs9AD7fV8POixk6un9GyrFy0LA?= =?us-ascii?Q?A9GeMGViil00J5U1811IatB6f4Cx9KdbLJZ8Y9/mhhhRduFsdCi5ZrINU3NC?= =?us-ascii?Q?sUYSAQXyZiufj1wWNkgzi3in8lAOiUmJ+1iPI1nL6VDUJ9A0lOHAA26ZLsaW?= =?us-ascii?Q?wq5/bJsdj8Dh8TughagaLj+hGBmNhTPddUJeAr9eA0ASbe8JohMSX1xwlkhw?= =?us-ascii?Q?Y75ShnrYkwJ/gWwikU/CDsXP4paIltJj65SYfRKvniHyR6ucXkGvckRaFKiV?= =?us-ascii?Q?CZa9EDHJ0ZjXCN0+ZARlSiPhwI8trL8pO+lkXK5u43Jcs3T5ASQxkZWq1MSF?= =?us-ascii?Q?M/suxEItqoxZxlOUYhMorLnn2arQDFnDQVXcAzZ7fIZO2j9w1doV0N8olFWi?= =?us-ascii?Q?rGrhj4LqRX4hRm5+KWA2yHsRekbsG69fsID5guzwL5u1a/BdmDKPJzLdjTbD?= =?us-ascii?Q?xgaQ1ZloZDeI7amHy26TKkzqdEG1Q31XRGWW5azoAmT2Uc09CCOgaGoHicZu?= =?us-ascii?Q?RLD5pQi2v24HETeVlImz9vfolOo+HG0h81l5J1ITBqympxhsNL9v785NSzgf?= =?us-ascii?Q?EolYrEg9UL0hIlra2J+jGL2MG3SL+Hiyb7ejSA3jddfUnT1OuihH6QtskUv7?= =?us-ascii?Q?MhXCtMRC3SDsVLrHY3cO1lrhsuvf+1QqQqbZiEuMVfYSifJyQl87ywpYa7Dy?= =?us-ascii?Q?/5UbHmonZ2MRtSFB1M/9CqWXSwGvJ9rV5NuCH1bbb3Vk4aJjQ89SqHgGT0XO?= =?us-ascii?Q?T5TaW7CMmW7gp8+5RRTYuCu9wUaj8rbSF0bKv879xODqVJyznb76s+XrH7DB?= =?us-ascii?Q?GBVN7iSX0xQa+cW0q2OYERxs0BlXdeXg4ewq6ApAlijYZhAHbjkyin/Q3swa?= =?us-ascii?Q?hVsRI7VsAsAriRH1zNkMxv2JlGTYDkItKd6yl8YIOJ0YcQ2RTAjAXuLcJ7GG?= =?us-ascii?Q?UXg4FTtDV7KDLyOllK/s+j6wpcKLBpsxxOeSQPhZGnthpKeYhFjAyCy1V6aD?= =?us-ascii?Q?Q7yau2O5oI7JJMEHNu8cV9RrS+2jlBAVslMLfjb3VoqncWOhzzWp6492TVz4?= =?us-ascii?Q?R3/yCS5IqS1sOmfqIoAOhDaiQ8QUcvR86SL87GUw9z+xa+Vy7qVXQP8LIb8Z?= =?us-ascii?Q?51IBUZAbuNnkEaq61Pvfd9rB4ZIC1Db24jH0lAHXT11NsiEbpeG7AU8DJw53?= =?us-ascii?Q?bAIxoRH9/FvztKGMwFu9RpnImtDf1Cu4fEtf8zZs?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8601.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5fb3f01-8ea7-47ce-159a-08dca6072df7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2024 02:21:34.5610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JUQofDWbDk66GZgHSgcwz3h6w4124IqWcG2+UjCEO83dKehDxOLjEIRUkylgtnO85Vr0DpSgql9xDLiUtkOh+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7952 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, Please not backport this revert commit. DPDK 23.11.2 does not need to do an= ything. Thanks, Mingjin > -----Original Message----- > From: Xueming Li > Sent: Friday, July 12, 2024 7:02 PM > To: Ye, MingjinX > Cc: dpdk stable > Subject: patch 'bus/vdev: revert fix devargs in secondary process' has be= en > queued to stable release 23.11.2 >=20 > Hi, >=20 > FYI, your patch has been queued to stable release 23.11.2 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 07/14/24. So please shout= if > anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://git.dpdk.org/dpdk-stable/log/?h=3D23.11-staging >=20 > This queued commit can be viewed at: > https://git.dpdk.org/dpdk-stable/commit/?h=3D23.11- > staging&id=3D8b75cfb86f90c816bdda28b8696beb18d553fd2b >=20 > Thanks. >=20 > Xueming Li >=20 > --- > From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > From: Mingjin Ye > Date: Thu, 14 Mar 2024 09:36:28 +0000 > Subject: [PATCH] bus/vdev: revert fix devargs in secondary process > Cc: Xueming Li >=20 > [ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] >=20 > The ASan tool detected a memory leak in the vdev driver alloc_devargs. Th= e > previous commit was that when inserting a vdev device, the primary proces= s > alloc devargs and the secondary process looks for devargs. This causes th= e > device to not be created if the secondary process does not initialise the= vdev > device. And, this is not the root cause. >=20 > Therefore the following commit was reverted accordingly. >=20 > After restoring this commit, the memory leak still exists. >=20 > Bugzilla ID: 1450 > Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") >=20 > Signed-off-by: Mingjin Ye > --- > drivers/bus/vdev/vdev.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) >=20 > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index > 14cf856237..38d05a9fe9 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args) > return devargs; > } >=20 > -static struct rte_devargs * > -vdev_devargs_lookup(const char *name) > -{ > - struct rte_devargs *devargs; > - char dev_name[32]; > - > - RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { > - devargs->bus->parse(devargs->name, &dev_name); > - if (strcmp(dev_name, name) =3D=3D 0) { > - VDEV_LOG(INFO, "devargs matched %s", dev_name); > - return devargs; > - } > - } > - return NULL; > -} > - > static int > insert_vdev(const char *name, const char *args, > struct rte_vdev_device **p_dev, > @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, > if (name =3D=3D NULL) > return -EINVAL; >=20 > - if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) > - devargs =3D alloc_devargs(name, args); > - else > - devargs =3D vdev_devargs_lookup(name); > + devargs =3D alloc_devargs(name, args); >=20 > if (!devargs) > return -ENOMEM; > -- > 2.34.1 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2024-07-12 18:40:18.570682691 +0800 > +++ 0100-bus-vdev-revert-fix-devargs-in-secondary-process.patch 2024- > 07-12 18:40:14.356594197 +0800 > @@ -1 +1 @@ > -From 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 Mon Sep 17 00:00:00 > 2001 > +From 8b75cfb86f90c816bdda28b8696beb18d553fd2b Mon Sep 17 00:00:00 > 2001 > @@ -4,0 +5,3 @@ > +Cc: Xueming Li > + > +[ upstream commit 22ce39b3aadb109cbefabb91aad44c94e8c2a5e6 ] > @@ -20 +22,0 @@ > -Cc: stable@dpdk.org