From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F1F9A0C51 for ; Tue, 13 Jul 2021 15:31:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 361B3406FF; Tue, 13 Jul 2021 15:31:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 821CA406FF for ; Tue, 13 Jul 2021 15:31:56 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="295806448" X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="295806448" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 06:31:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="654361533" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 13 Jul 2021 06:31:40 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 06:31:40 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 06:31:39 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 13 Jul 2021 06:31:39 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 13 Jul 2021 06:31:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EZjKWcwU4PlzCqm5a9WniK1waIk4syLYaF1OVF7RygJMVDxVs56JJLykDvJVKvlApL0eptFPkk1TZXr7xbvFSHdqqcbbH6MvHSAUmGYsW3mM8DwhLZ5T2Odq6pZjMSkT6CpJBpyrluD4XIb0DLU2DFIx+bjGl6W41U/qgWmOFcb0+4KQlxyY9HPh3lSZFZXxfqoo7V4eTDZ5SEpLnTRJ1l453rFYm80FGtZAYltvRtiLd4YZHlA+CF3LJPhhONbiswyzNufDO+F0qP6f+aBIaXxsnPHFB8dbEcChToU0PmnWgy5EN0brBfdNCEpcH5sIjLZ/0JjLuNWVqGoqaGFVew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7bqusveRljaoo+Bj9bWn6nRaWT0clk2zCNXkQCFc8s=; b=LVqVFw7MOaFdIr63PabFOOdJsWb/Hp2jkRrlKcJfYuX/26LQPJCEWr0B4Xh3TX37jdAHN7GJMEjrn7nE6oewn5FXq7LuhSfD89RODI0lGpIK+HzJDyWAplgdCJZgod6pG2eIpKaxOzdP/0gZ4pOHhTrfePHVvo2TyZiAXXkHn4XSt5DzoQb3MXaNWsvvDDCc/GdYvcs9uGxSTBF3bgoXyGMSN2tbwoPnSQ5kE/CswpWBnsH7XAO0P6CjmCRIh7Se2CbME9rP1t3cmlJACUi5HYSqOSNn/KkdUUjPAB9iP/81dngR3pRmKzNgDD0MVFts0fQ4YRhTVV/6aDw0h0zIQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7bqusveRljaoo+Bj9bWn6nRaWT0clk2zCNXkQCFc8s=; b=QmJOySpBLxzpf8hwZM8EvR/ZSK6mx3h3foUxgjxqQPszbov0jrRiVv1hQjZuLNC/jnFelz2ofKDBJ1wSq3zcwJW8gW5rdtOmT33nsdcyVvWLf+rEFjfYrh05p/zp8bpf6tJL1QAhxVxy79arTW1iH6iO7cjq9O3NNHpGqceZ0Bk= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB4696.namprd11.prod.outlook.com (2603:10b6:208:26d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Tue, 13 Jul 2021 13:31:38 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3%6]) with mapi id 15.20.4331.021; Tue, 13 Jul 2021 13:31:38 +0000 From: "Power, Ciara" To: "Zhang, AlvinX" , "christian.ehrhardt@canonical.com" , "Chen, LingliX" , "Jiang, YuX" , "Van Haaren, Harry" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4] telemetry: fix race in telemetry control thread creation Thread-Index: AQHXd7Ip2FijMk2aN06GOAzPP4WMQKtA5oqw Date: Tue, 13 Jul 2021 13:31:38 +0000 Message-ID: References: <20210713064137.12488-1-alvinx.zhang@intel.com> In-Reply-To: <20210713064137.12488-1-alvinx.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e71511a6-3286-4b79-bd0a-08d946028ace x-ms-traffictypediagnostic: MN2PR11MB4696: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cZMuU/QzIygQMhLFWhSd3nNvIG9FUL0i6Wsc0IzXL+vyqBQIeamEKI0T/PhhnRasJ5ECfhl7W4OcFgFBxoAma85GQePepDTTj2q3tPSaTgpXmjv59U7HauenN+l/fLx0JpK9wEXJO2ULM1LbgAb5vbZw/E5F0CyIGxwY0XETbfOKxWlR3q5+P+b/nZkg33dFgkPiN1mu2LXMWHlJqNwRSkFFNn8CZBaqI6bp5WvH5muT47tqvXk9iOpToYC6kH39y5v2xpRb8Vf8XyZUWBUXn3PdajJaDpGjU15OBPBtIL2OOrpH+a7p8I8TI6e1MpCzMwM7d7NJEvupoVTjnHQmJmpA9Afuxg5ARZa6C1mq7Zh1byMr1YF/FdLvXb5rU6MsIfGQzj2q4T2in22DWb24Ht8krCih5ufT4zh3TSXefJt1bGMEaEvuLzvbNRLtG9gucGsmyfo45dU/VNE+vrhnw4gm1MxkA/n7YMi1wYvzOfO3s0renYxNCrLud2KTJnSnTyTevKZDsMSDQYuqgg0mUANnpzH8lt5rMTh5dWeUn9VXnFi86B7ZGx12IeyrS2dV4d8nerkxP9Lx2zlE2Mfsf2MKq4tVz68w1ZKvgQK1tV5z61MibfWmACyx55y1TrQS9JZXuM/STPTxi2I2ltw0h+AkKrNQsu25TlC4q3z6WsHSQXhbJJo2TyJJfP/Uy0wHF+AGmSYVZUxhCU0zIQag20Flqnbi5MFVlV4clxhGcK0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(136003)(376002)(396003)(39860400002)(64756008)(66446008)(71200400001)(26005)(316002)(478600001)(6636002)(186003)(7696005)(9686003)(6506007)(2906002)(38100700002)(8936002)(86362001)(122000001)(5660300002)(8676002)(55016002)(966005)(66946007)(4326008)(110136005)(33656002)(66476007)(76116006)(4744005)(52536014)(66556008)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a9wkos86IFBcF3f62En30XurUR3cy4Xb4L/J4PoL5Z3t1gLTdyEejPEuR5AY?= =?us-ascii?Q?T9kU0JGfNHlNSTRAa6DakaMcxwDJhO5KnWCqSDKbzpCo6LhCPNQZka5c+szH?= =?us-ascii?Q?o6oS6FCb75uuSB+qm6UXzR0pOeQeWQ5wS+hEGacTYo4OfCneWjU+lALyz0uJ?= =?us-ascii?Q?fbN82wht9BTVGg5JHrV5lw1XLu4bjLdaJDVS0XIxU3CVTJwd/y1KuzoSDXYn?= =?us-ascii?Q?0iEzvtqGVBP09Xq2lbp0z3US5O13ssmHIGkIsNTX4JOZHZ0dh3cNJ8eI2WKT?= =?us-ascii?Q?yBIyJXSt+pzTgQeGmtYItXAHxWkJhDAFoLsRGV/2MpsP82UHkjraA3KKffoS?= =?us-ascii?Q?uPYlH8C9CWXfC5YvMioll/YEjWKHR+9viumlVj3wWPCJGJpT9wBirernXi0z?= =?us-ascii?Q?RIjLAe2H2frK618v7Sw6Ut6ykfoShWDNxpDWP7ERWrzAMDGD4pxRc9el6bPE?= =?us-ascii?Q?+/Kz4ASTERCuNM3wjA2KjLlA51QISKvaIbtEGaBnMTk8v1u86V3Ugad3s/0d?= =?us-ascii?Q?Qw0KFLgzgIKFhUf1XoiTDmjiiiKZPq3YA70for6RJQ3Se+JZO6GJ44BkTvYG?= =?us-ascii?Q?7L3Eq+hFFH7MhzDjqzAEstS33jeSIYiqFebJDxKRUl0SfUU6Hzrn8PnPXap9?= =?us-ascii?Q?n5MKADrHnQ53h1yqPIIt9xwKP7DyrItMh2NjAwLCdQUpjwnV0FuD1CwioXRn?= =?us-ascii?Q?qsJGEidFBqGgwm+ICfx0d6RG+Wx9zl1t/C5lawH0qwDRcW/+omckXLkJPdal?= =?us-ascii?Q?lh0SYrgpONIj8q4TYPgXry10+S0xGcN72O0sZlJCuqHmEF46YXCqIt7fRk4f?= =?us-ascii?Q?e2VfdUygMJLvqyvamwIfatRbCeqTSlCyZRHnd5iWW152G53H7aMUE07spAAm?= =?us-ascii?Q?BP3eo+j9iC5BYP+Gef92TDK6syJMwSC6PDR7gAwF/2ks2mC50+xQXbQS1nzz?= =?us-ascii?Q?gXeIDbv1lP3+zMhJWD8cOLZ1mL6l5sIK4HIYJzrwMk6uNpCrPSzNm0Sngtyc?= =?us-ascii?Q?2exIgQv3BK3A6tlI5ybnqiY08r13F+ABuHyd07ifhOk0Q8bjPlz4QoH4d669?= =?us-ascii?Q?DuyxL5i+WUMHa9C37YSKMtQiwoEdyEmlsD4rbA/4wuplHW1BQBFF25AhmPkT?= =?us-ascii?Q?h/Y/R78VFtERuF2iu/UCEeYgXIyaiySPijzzoloVCzifsYGIm9phNbiRY56I?= =?us-ascii?Q?NSdfE+wKfoO9rT9alTLQhmn6L08FC1Hld+APmErmi/Sp4W6ix5vsmFVaVOG4?= =?us-ascii?Q?W204v1e/3BjoirU8thvso66e8L7tDUzDc9Ub94sbBmnt9R8ysXlsk5bt+mR6?= =?us-ascii?Q?Al8TnX47yIpas0iCm9qTqhWc?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e71511a6-3286-4b79-bd0a-08d946028ace X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 13:31:38.1120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hpN240/1SXmYCjBvjoXg81eolP/b4oQPHXPqN28DLyQAsdGuHix4ZJFr3xamPNDGV+AUjLOqxfAEaE2bBCYKww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4696 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v4] telemetry: fix race in telemetry control thread creation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Alvin, >-----Original Message----- >From: Zhang, AlvinX >Sent: Tuesday 13 July 2021 07:42 >To: christian.ehrhardt@canonical.com; Chen, LingliX ; >Jiang, YuX ; Power, Ciara ; Va= n >Haaren, Harry >Cc: Zhang, AlvinX ; stable@dpdk.org >Subject: [PATCH v4] telemetry: fix race in telemetry control thread creati= on > >Before the caller returns from function "rte_ctrl_thread_create", the newl= y >created thread may have ran, and because the thread control flag was not s= et >before, the new thread may exit soon. >This is not what the developer expected. > >This patch puts the setting thread control flag to the place that before c= reating >new thread. > >Reported-at: https://bugs.dpdk.org/show_bug.cgi?id=3D731 >Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") >Cc: stable@dpdk.org > >Signed-off-by: Alvin Zhang >--- > Thanks for this, I guess it is targeted towards both 18.11 and 19.11 stable= releases? This file was removed in 20.11 so won't be needed there. Acked-by: Ciara Power