patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Power, Ciara" <ciara.power@intel.com>
To: "Troy, Rebecca" <rebecca.troy@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
	"jianjay.zhou@huawei.com" <jianjay.zhou@huawei.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	 Akhil Goyal <gakhil@marvell.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] test/crypto: fix autotest function parameters
Date: Tue, 29 Jun 2021 14:32:09 +0000
Message-ID: <MN2PR11MB3821CA4D3F6AD0D2537A2A5DE6029@MN2PR11MB3821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210628161529.386889-1-rebecca.troy@intel.com>

Hi Rebecca,

Looks good, thanks.
One minor change added inline below.

With this change,
Acked-by: Ciara Power <ciara.power@intel.com>


>-----Original Message-----
>From: Troy, Rebecca <rebecca.troy@intel.com>
>Sent: Monday 28 June 2021 17:15
>To: dev@dpdk.org
>Cc: Power, Ciara <ciara.power@intel.com>; Troy, Rebecca
><rebecca.troy@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
>jianjay.zhou@huawei.com; De Lara Guarch, Pablo
><pablo.de.lara.guarch@intel.com>; Zhang, Roy Fan
><roy.fan.zhang@intel.com>; akhil.goyal@nxp.com;
>hemant.agrawal@nxp.com; stable@dpdk.org
>Subject: [PATCH] test/crypto: fix autotest function parameters
>
>Fixed parameters on autotest functions by removing comments.
>
>Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
>Fixes: 4ed1e79e7819 ("test/crypto: add tests for virtio-crypto")
>Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library")
>Fixes: 27a1c4714d54 ("app/test: add KASUMI crypto")
>Fixes: 4c99481f49c4 ("app/test: add ZUC")
>Fixes: c8e69fce7046 ("crypto/scheduler: add unit test")
>Fixes: ae002048bbea ("test/crypto: add DPAA2 crypto functional test")
>Fixes: b674d6d0381a ("test/crypto: add dpaa crypto test cases")
>Fixes: a8dbd44d6b4c ("test/crypto: add CAAM JR validation cases")
>Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
>
>Cc: declan.doherty@intel.com
>Cc: jianjay.zhou@huawei.com
>Cc: pablo.de.lara.guarch@intel.com
>Cc: roy.fan.zhang@intel.com
>Cc: akhil.goyal@nxp.com

This should be updated to Akhil's new email address (cc'd): <gakhil@marvell.com>

>Cc: hemant.agrawal@nxp.com
>Cc: stable@dpdk.org
>
>Signed-off-by: Rebecca Troy <rebecca.troy@intel.com>
>---
> app/test/test_cryptodev.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
>39db52b17a..c18730f138 100644
>--- a/app/test/test_cryptodev.c
>+++ b/app/test/test_cryptodev.c
>@@ -14521,19 +14521,19 @@ run_cryptodev_testsuite(const char
>*pmd_name)  }
>
> static int
>-test_cryptodev_qat(void /*argv __rte_unused, int argc __rte_unused*/)
>+test_cryptodev_qat(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
> }
>
> static int
>-test_cryptodev_virtio(void /*argv __rte_unused, int argc __rte_unused*/)
>+test_cryptodev_virtio(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_VIRTIO_PMD));
> }
>
> static int
>-test_cryptodev_aesni_mb(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_aesni_mb(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_AESNI_MB_PMD));
> }
>@@ -14579,19 +14579,19 @@ test_cryptodev_null(void)  }
>
> static int
>-test_cryptodev_sw_snow3g(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_sw_snow3g(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_SNOW3G_PMD));
> }
>
> static int
>-test_cryptodev_sw_kasumi(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_sw_kasumi(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_KASUMI_PMD));
> }
>
> static int
>-test_cryptodev_sw_zuc(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_sw_zuc(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_ZUC_PMD));
> }
>@@ -14611,7 +14611,7 @@ test_cryptodev_mrvl(void)  #ifdef
>RTE_CRYPTO_SCHEDULER
>
> static int
>-test_cryptodev_scheduler(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_scheduler(void)
> {
> 	uint8_t ret, sched_i, j, i = 0, blk_start_idx = 0;
> 	const enum blockcipher_test_type blk_suites[] = { @@ -14719,13
>+14719,13 @@ REGISTER_TEST_COMMAND(cryptodev_scheduler_autotest,
>test_cryptodev_scheduler);  #endif
>
> static int
>-test_cryptodev_dpaa2_sec(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_dpaa2_sec(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD));
> }
>
> static int
>-test_cryptodev_dpaa_sec(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_dpaa_sec(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA_SEC_PMD));
> }
>@@ -14749,7 +14749,7 @@ test_cryptodev_octeontx2(void)  }
>
> static int
>-test_cryptodev_caam_jr(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_caam_jr(void)
> {
> 	return
>run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_CAAM_JR_PMD));
> }
>@@ -14767,7 +14767,7 @@ test_cryptodev_bcmfs(void)  }
>
> static int
>-test_cryptodev_qat_raw_api(void /*argv __rte_unused, int argc
>__rte_unused*/)
>+test_cryptodev_qat_raw_api(void)
> {
> 	int ret;
>
>--
>2.25.1



  reply	other threads:[~2021-06-29 14:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 16:15 Rebecca Troy
2021-06-29 14:32 ` Power, Ciara [this message]
2021-06-30 14:01 ` [dpdk-stable] [PATCH v2] " Rebecca Troy
2021-06-30 15:50   ` Hemant Agrawal
2021-07-07 14:16     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB3821CA4D3F6AD0D2537A2A5DE6029@MN2PR11MB3821.namprd11.prod.outlook.com \
    --to=ciara.power@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=rebecca.troy@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git