From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Vipul Ashri <vipul.ashri@oracle.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "edwin.leung@oracle.com" <edwin.leung@oracle.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro
Date: Wed, 19 Aug 2020 01:25:07 +0000 [thread overview]
Message-ID: <MN2PR11MB40631BBE4A2AE27F19086DD69C5D0@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200813072837.1468-1-vipul.ashri@oracle.com>
> -----Original Message-----
> From: Vipul Ashri <vipul.ashri@oracle.com>
> Sent: Thursday, August 13, 2020 3:29 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; vipul.ashri@oracle.com;
> edwin.leung@oracle.com; stable@dpdk.org
> Subject: [PATCH v3] net/virtio: fix wrong variable assignment in helper
> macro
>
> Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always
> failing as assignment done using var_ having local scope only.
> This leads to TX packets not going out and found broken due to cleanup
> malfunctioning. This patch fixes the wrong variable assignment.
>
> Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
> ---
> drivers/net/virtio/virtqueue.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/virtio/virtqueue.h
> b/drivers/net/virtio/virtqueue.h
> index 105a9c00c..20c95471e 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)
>
> /* avoid write operation when necessary, to lessen cache issues */
> #define ASSIGN_UNLESS_EQUAL(var, val) do { \
> - typeof(var) var_ = (var); \
> - typeof(val) val_ = (val); \
> - if ((var_) != (val_)) \
> - (var_) = (val_); \
> + if ((var) != (val)) \
> + (var) = (val); \
> } while (0)
>
> #define virtqueue_clear_net_hdr(hdr) do { \
> --
> 2.28.0.windows.1
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2020-08-19 1:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200812092306.1345-1-vipul.ashri@oracle.com>
[not found] ` <20200813072837.1468-1-vipul.ashri@oracle.com>
2020-08-13 7:35 ` Xia, Chenbo
2020-08-19 1:25 ` Xia, Chenbo [this message]
2020-09-16 5:57 ` [dpdk-stable] [PATCH v4] " Vipul Ashri
2020-09-17 15:54 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2020-09-18 9:55 ` [dpdk-stable] [PATCH v5] " Vipul Ashri
2020-09-18 12:22 ` Maxime Coquelin
2020-09-18 12:30 ` Maxime Coquelin
[not found] <20200807125731.1287-1-vipul.ashri@oracle.com>
[not found] ` <20200813162222.1635-1-vipul.ashri@oracle.com>
2020-08-14 1:25 ` [dpdk-stable] [PATCH v3] " Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB40631BBE4A2AE27F19086DD69C5D0@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=edwin.leung@oracle.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=vipul.ashri@oracle.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).