Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bnxt: fix variable size of port id

["Xia, Chenbo" <chenbo.xia@intel.com>]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, August 6, 2020 4:18 AM
> To: Xia, Chenbo <chenbo.xia@intel.com>; Wang, Yinan <yinan.wang@intel.com>
> Cc: dev@dpdk.org; ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com;
> kishore.padmanabha@broadcom.com; venkatkumar.duvvuru@broadcom.com;
> stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix variable size of port id
> 
> 04/08/2020 19:41, Chenbo Xia:
> > Currenly the variable size of ethdev port id is 8 bits. This
> > patch standarizes it to 16 bits.
> >
> > Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Yinan Wang <yinan.wang@intel.com>
> > Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> > ---
> >  drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > index 9fb1a028f..ff5aed3d7 100644
> > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> > @@ -397,7 +397,7 @@ void
> >  bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
> >  {
> >  	struct bnxt_ulp_df_rule_info *info;
> > -	uint8_t port_id;
> > +	uint16_t port_id;
> 
> There are more occurences in bnxt, introduced by the same patch.
> 
> In general, in other drivers, it would be good to make this clean-up.

Sure, I could do the clean-up. Btw, only net drivers, right?

> 	git grep 'uint8_t port' | wc -l
> 	297
>