Re: [dpdk-stable] [EXT] patch 'net/mvneta: fix ierror statistics' has been queued to LTS release 18.11.3

[Liron Himi <lironh@marvell.com>]

queued commit looks okay.

Regards,
Liron

-----Original Message-----
From: Kevin Traynor <ktraynor@redhat.com> 
Sent: Friday, August 23, 2019 12:43
To: Liron Himi <lironh@marvell.com>
Cc: Yuri Chipchev <yuric@marvell.com>; dpdk stable <stable@dpdk.org>
Subject: [EXT] patch 'net/mvneta: fix ierror statistics' has been queued to LTS release 18.11.3

External Email

----------------------------------------------------------------------
Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/28/19. So please shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/a9b869ed83f19ecac2255ff4fe4063be7a547fff

Thanks.

Kevin Traynor

---
From a9b869ed83f19ecac2255ff4fe4063be7a547fff Mon Sep 17 00:00:00 2001
From: Liron Himi <lironh@marvell.com>
Date: Mon, 1 Jul 2019 11:00:22 +0300
Subject: [PATCH] net/mvneta: fix ierror statistics

[ upstream commit 09a6afe7e4bff1d4b2961e031fcae1b7a1f042d3 ]

Error packets were counted twice due to use of redundant counters.

Fixes: e9d5faffd10c ("net/mvneta: support basic stats")

Signed-off-by: Liron Himi <lironh@marvell.com>
Reviewed-by: Yuri Chipchev <yuric@marvell.com>
Tested-by: Liron Himi <lironh@marvell.com>
---
 drivers/net/mvneta/mvneta_ethdev.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index 2d7666454..919856885 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -707,8 +707,5 @@ mvneta_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 			  ppio_stats.rx_overrun -
 			  priv->prev_stats.imissed;
-
-	stats->ierrors = ppio_stats.rx_packets_err +
-			ppio_stats.rx_errors +
-			ppio_stats.rx_crc_error -
+	stats->ierrors = ppio_stats.rx_packets_err -
 			priv->prev_stats.ierrors;
 	stats->oerrors = ppio_stats.tx_errors - priv->prev_stats.oerrors;
--
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-22 19:38:22.720052952 +0100
+++ 0035-net-mvneta-fix-ierror-statistics.patch	2019-08-22 19:38:20.456026427 +0100
@@ -1 +1 @@
-From 09a6afe7e4bff1d4b2961e031fcae1b7a1f042d3 Mon Sep 17 00:00:00 2001
+From a9b869ed83f19ecac2255ff4fe4063be7a547fff Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 09a6afe7e4bff1d4b2961e031fcae1b7a1f042d3 ]
+
@@ -9 +10,0 @@
-Cc: stable@dpdk.org
@@ -19 +20 @@
-index 965744406..d6e64a849 100644
+index 2d7666454..919856885 100644
@@ -22 +23 @@
-@@ -708,8 +708,5 @@ mvneta_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
+@@ -707,8 +707,5 @@ mvneta_stats_get(struct rte_eth_dev *dev, struct 
+rte_eth_stats *stats)