From: Anoob Joseph <anoobj@marvell.com>
To: Timothy Redaelli <tredaelli@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [EXT] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10
Date: Wed, 5 Feb 2020 12:59:21 +0000 [thread overview]
Message-ID: <MN2PR18MB28773B269A78A906BC8C137BDF020@MN2PR18MB2877.namprd18.prod.outlook.com> (raw)
In-Reply-To: <f028dcdd91e4452d9911942bc1fd53c59c3afe15.1580906522.git.tredaelli@redhat.com>
> ----------------------------------------------------------------------
> GCC 10 defaults to -fno-common, this means a linker error will now be reported
> if the same global variable is defined in more than one compilation unit.
>
> Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton")
> Cc: anoobj@marvell.com
> Cc: stable@dpdk.org
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> drivers/crypto/octeontx2/otx2_cryptodev.c | 2 ++
> drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +-
> drivers/crypto/octeontx2/otx2_cryptodev_ops.h | 2 +-
> 3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c
> b/drivers/crypto/octeontx2/otx2_cryptodev.c
> index 7fd216bb3..957bcd720 100644
> --- a/drivers/crypto/octeontx2/otx2_cryptodev.c
> +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
> @@ -24,6 +24,8 @@
>
> int otx2_cpt_logtype;
>
> +uint8_t otx2_cryptodev_driver_id;
> +
> static struct rte_pci_id pci_id_cpt_table[] = {
> {
> RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM,
> diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h
> b/drivers/crypto/octeontx2/otx2_cryptodev.h
> index 8e0ebc292..c0aa661b3 100644
> --- a/drivers/crypto/octeontx2/otx2_cryptodev.h
> +++ b/drivers/crypto/octeontx2/otx2_cryptodev.h
> @@ -38,6 +38,6 @@ extern int otx2_cpt_logtype;
> /*
> * Crypto device driver ID
> */
> -uint8_t otx2_cryptodev_driver_id;
> +extern uint8_t otx2_cryptodev_driver_id;
>
> #endif /* _OTX2_CRYPTODEV_H_ */
> diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h
> b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h
> index a2724f722..f83e36b48 100644
> --- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.h
> +++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.h
> @@ -16,6 +16,6 @@ enum otx2_cpt_egrp {
> OTX2_CPT_EGRP_AE = 2
> };
>
> -struct rte_cryptodev_ops otx2_cpt_ops;
> +extern struct rte_cryptodev_ops otx2_cpt_ops;
>
> #endif /* _OTX2_CRYPTODEV_OPS_H_ */
> --
> 2.24.1
Acked-by: Anoob Joseph <anoobj@marvell.com>
next prev parent reply other threads:[~2020-02-05 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1580906522.git.tredaelli@redhat.com>
2020-02-05 12:50 ` [dpdk-stable] " Timothy Redaelli
2020-02-05 12:59 ` Anoob Joseph [this message]
2020-02-05 12:50 ` [dpdk-stable] [PATCH 2/3] app/test: " Timothy Redaelli
2020-02-05 13:41 ` Medvedkin, Vladimir
2020-02-05 12:50 ` [dpdk-stable] [PATCH 3/3] app/test-pipeline: " Timothy Redaelli
2020-02-05 13:26 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB28773B269A78A906BC8C137BDF020@MN2PR18MB2877.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).