From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58AABA0A0C for ; Thu, 8 Apr 2021 11:23:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D05014103E; Thu, 8 Apr 2021 11:23:21 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2056.outbound.protection.outlook.com [40.107.237.56]) by mails.dpdk.org (Postfix) with ESMTP id 96B5E40138; Thu, 8 Apr 2021 11:23:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSp+e9nMr4q1I/U6PjXq03YIwAkeAPoDlZ3uOBe/GfTTAzCvEuORj1RN8Gv5FqvFheSdFtLHUuUUfIRThKEGvRI2k2bWZISCgSeQve6ME9MnIPK8GEXDgVn9qemjFR0bU+X1M1v5o8Wa4WqiDpACTqhSQeyuaTvrUZ1w1+vJCnsjMgU2S3EL0Mt/oa/kQvreB/Rb/xZCocvDOWV7cADJyDg6IIADbMLDImhO1NO17JsELGXFmNohkeUrse5CHDylqzVtycnCa40Ez6aIZlUW1tlqMqqQt1Shi+dZkc+jKWTbnDPu+8+heSw1UMVJNrEpBPrKtKyeD8U1/qC+iwr4Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ny5K9D1kHkbK53+kJjx+bmRrp5mXrQ60y1mBmq3rJR8=; b=lA9wA72lPIrx4gabUitY0plJelGnYtu1F8aFKkinEa0LAfPNyKhVZTCScZLAV2R1wfg17AGacO/HVgfUjiVLozsBG9KtAQkBsaL/cQP5/nf6nk5MtThHhLsWdJ11DIOQxY2ClqxMdZtW9n6T8WinRhQD7w7oqjelid3adFXR0Ouyj7dAyq2K3vYM2tOo/7kgIdf768r1+DGDCWBzC9s8g9n5xBghWgv8V7T+HiNh+z4H9IUijDSkGjHUf20UbRgpH9u7uHiy30gbp/6OLxM6vnLXu2gbUC2dSzekSvgJYVozr08NPnAKnP/nQWdZD0CH+FD1HPdRn2amk/LNHMN2nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ny5K9D1kHkbK53+kJjx+bmRrp5mXrQ60y1mBmq3rJR8=; b=NCvW7+Dfq4ZTeCToi6kgChA3M4N6C1apph5uN6EHog1RUloQ+mRDYJE4dbXgeHt6+P1qH9LzWPG3iOl4h6yQOgobPr01DlDOPFEnhZTCL6MHGogfGV5kWr0H2Fi33mRDQQ44011Juqub1DrQzDz23LACUgsaTtIv5ATvzejz4w6ZSkhTTi+qkxZi/yrpUcV4e0zKrGiysw3MEIalGnqu9udqYTm4UZpXqaCWrI6YhSYWwE3Fbo1/lmXrWh4Qv2zwt6NXfInFYao0yaLJ+iZutKtxKRZw5485eZvKzV0dSWLwybIUd34o8VoHUQs2CpyE6utgvrSRRDzDPKgx2XSLYQ== Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MWHPR1201MB2510.namprd12.prod.outlook.com (2603:10b6:300:e8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Thu, 8 Apr 2021 09:23:15 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90%7]) with mapi id 15.20.3999.032; Thu, 8 Apr 2021 09:23:15 +0000 From: Matan Azrad To: Jack Min , Shahaf Shuler , Slava Ovsiienko , Jack Min , Ori Kam CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix redundant flow after RSS expansion Thread-Index: AQHXJWpIwHnApn9DQUWSwe1P8r3F16qqZoLA Date: Thu, 8 Apr 2021 09:23:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [216.228.117.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eaaccef8-1954-408c-3ce0-08d8fa6ff096 x-ms-traffictypediagnostic: MWHPR1201MB2510: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YtuoPCfirvXccGyun7MkH18iotvLSbvuiI0IS+DRsXVIfkJJNyrK/tcr+XnWDcBPA/4TTvNSUS9EFLM9jjiO3sy8vk7PJBKmIGz++NOf6Z4VUvpCHD+MU1nIrYjq9DJH1kLg4Y9oKtNhWHIi0nfbpxMF75p9gaqlvCNuQEMfyy7DxwO+Wxbkm2QIhqTzok/a+P3Wm6MoIWjoy8c1+SYl4jQJ0/nRvRqq9+5NIw8s6R3wec0y7lsCubhfNJZVyROI9wKAE716WimqiRrB2WZRbDZfwu/hk9olEH1P4G2F7AV3wZADvdnLEYmuP/n7UoJ+PL/WJK86mx+HnCjQe1mc+4/i4P8PWceye19CUOnUPBSgS1qPTD/Jlg3yTVR28CtuFrrJDjhHMjz5FIG7bKsIF/99kgQkLi2V40ru6XBXG9HZsDGDhyWHhQaU2922nidrzh+JC/JqqL+5+7BpPUR5cIGFmIGpHLYnQ6uIbQ5JJyc8JYG8krSMt2KnwE6Fm6CYngcwURVZaVLB6uoZte7xlBhIrePPA9i8cgDOjuqFlqzC7nFeMhLzsXX2FL5s18FTA/0OrZjk0wnKOLh6jYLLAAauE0bxDBvEc0HUP8PYFLPicGut/1FHE3XLYAmfL2HLhB5K4DZlgmtMO9kb3+zIC3ZYOuiF2BkNRqXbM4yz9xE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(366004)(136003)(376002)(8676002)(71200400001)(478600001)(6506007)(450100002)(7696005)(26005)(186003)(4744005)(52536014)(316002)(66446008)(64756008)(4326008)(5660300002)(66556008)(6636002)(66476007)(76116006)(54906003)(110136005)(66946007)(86362001)(8936002)(2906002)(33656002)(9686003)(83380400001)(38100700001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XUaSkoZykHfL1EuUynZbh7PJLk6DZF9bd7ZrMR/rkxMfSI7SuFJK8t0pyjj1?= =?us-ascii?Q?QpKwNlxFmGJ9pNlus8rqluPZ0B/Ed0n+C5N69yT1YdH1Z6LJt04p68G8PKKC?= =?us-ascii?Q?+VzN4iTO1uD6T5rm6cJXfc+VBy/lQ2gh5i3EUBNOpOHjox8zciVUy5F0imPA?= =?us-ascii?Q?NPxMgriuywaDhB9fmbG8rxesLZ5tLrY2zrLObV/EElXnbqLK0YpamPbQGoPt?= =?us-ascii?Q?+3MuOkSBxyPd2w+Wkm4fkAFcFjNkcY+j1Z3AdubMyTXUxyTYzmQCGn0xy13z?= =?us-ascii?Q?k+x2K+pWQmdErKV4f6uf6YrjavCfKCLNJ9qf4EDJRK03GJDVhVR+SZsOqx5b?= =?us-ascii?Q?eIJDkknXMb4gVjkpJkF+OdZ5U7Umvbaax+9BiEX0oUwmRr7sOXsmTXOeY0lF?= =?us-ascii?Q?yJyEqol/bhzPInY6cH2iPz6UMP03JPnx3mhaIG9ZuXESwOAxzTsFkJOvNeWn?= =?us-ascii?Q?z3SKZTEcJ4Dcx/EnO5z+D4cKLYPPUv+MvN6xm6ejlQ9YCROfA0ZLWFB6BdCU?= =?us-ascii?Q?sNT2OnTaGoSmv1bSnZ33RSQsuDWNl3t6mt1Lhwsflocz9zggtKaRIQdezbkD?= =?us-ascii?Q?7DAep1mahlp5msnMdrENg8RA9ABEEiiX0MhIm5a4TkwkGu6u4t49Ei3iKmBI?= =?us-ascii?Q?8m/GSA9BL8Y84vh3YX1KNs5ZYC5LGXUR5feSz0Q+WNSFfsS8Z2T/tfDmmocN?= =?us-ascii?Q?D9CAFel/lz6ZeErKm2w4GJ2wtOJjNBKH9QZOA+c3krQ570b3F+6Kz8ohkKa0?= =?us-ascii?Q?HVMBFnMKmcHEAK/b+burmp2l5YsSZjC3lfd1I6U78MRbVWw0bfa8z1ASBHTk?= =?us-ascii?Q?0psDnmP1vlRLelvKb7apGjJIsS+87qGNjyMIf4xGbJS87oYbJUJjCdCyJj9Y?= =?us-ascii?Q?H1U+fPafNpbdINVQXqVsikQZApCYcYAb5aCRXmqXLZBkgHcBoUoqLB8fnRxo?= =?us-ascii?Q?aclMVXMQECvoUM3vrzXOUyCkiTprQbksBORXa0xqwf1bm7BBTaUJAtqTjXtg?= =?us-ascii?Q?82o5iX6Pt59Z6k4LXHNBEi6BP9zDJSMaERNgNt8CTJGl/euVrYtyNq41/Amu?= =?us-ascii?Q?WYD1rbMee82gP+T7+R6ODXIlR/KA8sl/7pgTTmo0k6KPBRIhRYzclVQR+4H4?= =?us-ascii?Q?/vm6WOxxLsRFAQ+fFqzm6Q/KxPWWybWPSCehjIgq1GCSwaShwHeDIeAb7Foo?= =?us-ascii?Q?+sTv7BwjE99tw4Wft8gd9caYCM70fV540fsQ9BIwq433vS3TqkrAyeB27a2w?= =?us-ascii?Q?q7Uyys6tNU1sBqoywq3leFm9KjlSgfWT14RTmRB2si8hObDaUHqjr7ePOmY5?= =?us-ascii?Q?sCCQSILnF/vcDCYuRZvFFk05?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaaccef8-1954-408c-3ce0-08d8fa6ff096 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 09:23:15.4958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3Sy0pDNX3RN3Q5ZP3KEWetNgQHuXRBcNH4LwMMeAd2g/rHlcqGAo0m+0OT2WqIJmBsp2zOgeBaBw2Tr9UVEtRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB2510 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix redundant flow after RSS expansion X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Archived-At: List-Archive: From: Xiaoyu Min > When RSS expand, if there is no expansion happened but completion happene= d > because user only input next protocol field instead of item i.e, ether ty= pe =3D=3D > 0x8100 instead of VLAN, an extra flow is created with missing item in ord= er to > filter traffic strictly. >=20 > However, after [1] and [2] the rte_flow_item_eth itself is enough to filt= er out > VLAN traffic, the VLAN item is not needed. >=20 > This redundant flow will cause faiure in some scenarios on group 0 due to= they > are the same FTE. >=20 > Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows") > Cc: stable@dpdk.org >=20 > [1]: > commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN > items") >=20 > [2]: > commit 86b59a1af671 ("net/mlx5: support VLAN matching fields") >=20 > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad