From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D725A034F for ; Wed, 13 May 2020 01:50:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C42641BFE3; Wed, 13 May 2020 01:50:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D5E071BF93; Wed, 13 May 2020 01:50:19 +0200 (CEST) IronPort-SDR: VYgsIr13Ffe5iritKSujlBRJZiBSLrjvcBUQJu3035uqqQ1le7pRyK4VfUwQlonV6uUC7f0Pr+ izV1Z1HS6vlw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 16:50:18 -0700 IronPort-SDR: MOmU/sITZYtVRgHKDp5Zpsx/ZOc8Jk5mhtoNLjHIJaafVg4/A0tQBC6PSwoo261Cvxez2utL8h j9YKDJX+sDUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,385,1583222400"; d="scan'208";a="253025573" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 12 May 2020 16:50:18 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 16:50:19 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 16:50:18 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 16:50:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Grv0wG2H6mZd6aLGrRI0bJDKKcQW9y2KSyyL2QHzBb3daaraPHov36nYMr1WwwdQrgJINfGDkC2Sza3ti7p0JiKOFRcbSZipxKwujKmvk9bdenVPhSgV8qMx3NmjjdaA2KkEEKTu1rCqny/4PLd8/rzMCLXJQ5IAiHK+A+V9PVnoNxkBQVJAX7LdtZqsAzihOb98HxeXE23CupwBiwT0pa8/RTX36mIMhDM6uTONc4cfLM9v/cnMmUhIGELpjDcrhaJ79CWj5AQ1cBasXsaNbcikSqJvmdA6eC5M28D4IBMImGgy5FjMqKhV5XJs8vhtK78jnLb/1aGtK4pDG6UW3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AX6iDgLLgTVP24a9kJEnSxGtIgbLOmSnBArqsDNSqJQ=; b=VxfzjHAD4Hqf3RrUxHRtqdovjQqgw3Arvu/26TJfEXCHVFxR+qOEOeq3cj4vCQ1iQpG7DiB/xv2gOGsSNs7UCPNxxwNFkNBvKB1iPFwE0WOQvNnQu+xEppiBMTnf4exF7H5msWZddJD1Xh6VTkB9kbfk/N4KD7LCQjm1yu8qotddWVW8XSIoyp04Gnpp4iI1fmy19QGF6LnsIsQwckqsvr+15EZrLW/+GNOoN6w4LCl09jDaT06HjdVHNXB6RfNQNbZy3PAU9xwPHSU3VSR7ADPDsEdqNnoVlRIMYpH2h/BZMgcHDANeWYp5SEQCJiYvcfb8jD4GqHFwHkYjA3ovYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AX6iDgLLgTVP24a9kJEnSxGtIgbLOmSnBArqsDNSqJQ=; b=kG/KeAX6xBVedAXsV21I4nfxy5H8QNTZcgGVuYnaa2HALlLdBj4Yf8Kwkq7i39HozVhiSJakvOVviIspe09x21UGjKrPmuQoHPuZCjq/d8IV91TYmSf4zmUYvo5Cp1ZcuzY+hPnAwi5qe0drgcgRyHP+LM/6kDDEhfA67zubE0o= Received: from MW3PR11MB4684.namprd11.prod.outlook.com (2603:10b6:303:5d::14) by MW3PR11MB4617.namprd11.prod.outlook.com (2603:10b6:303:59::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.29; Tue, 12 May 2020 23:50:16 +0000 Received: from MW3PR11MB4684.namprd11.prod.outlook.com ([fe80::f9:c325:bf1e:4b6d]) by MW3PR11MB4684.namprd11.prod.outlook.com ([fe80::f9:c325:bf1e:4b6d%8]) with mapi id 15.20.2979.033; Tue, 12 May 2020 23:50:16 +0000 From: "Wang, Yipeng1" To: "Lilijun (Jerry)" , "'dev@dpdk.org'" CC: wangyunjian , xudingke , "'stable@dpdk.org'" Thread-Topic: [dpdk-dev] [PATCH] lib/librte_hash: avoid iterate bugs with delete keys. Thread-Index: AdYcRaxOBIK0iMKdQzaoWZN1CFUPDQMcbgag Date: Tue, 12 May 2020 23:50:16 +0000 Message-ID: References: <40280F65B1B0B44E8089ED31C01616EBA49922F6@dggeml529-mbx.china.huawei.com> In-Reply-To: <40280F65B1B0B44E8089ED31C01616EBA49922F6@dggeml529-mbx.china.huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7547ce60-25c6-4413-5cc6-08d7f6cf38e4 x-ms-traffictypediagnostic: MW3PR11MB4617: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tPEH6qsbhzhrvjA8cgbpjO+k+QFzyT349HEwO31G+PRufqzvEbyhNqaE5nLSxgrsV2YgSMtN9M/KI7IxgJx69Mw00JEaAkEdJKP1rxcPdUblx9bm3iDiJ9+mBPwaVDr+7ubeCoJpNfgX69bRXu45O0lt2TPWaQlotgHWeSUGH24+BIAB9JGrahwEu6fCIbcMDAEts4sfnJRuwZJ3gHFPtg/NM0/2RrsSckA1cFX5hnY9IFNDotlFlm8XfNlxG+dLh8H8iatM0Lb3b5G/xoc9xRCzUfg8h+8GGwgSGrl97LTIP6247Brpzw3q9AqTSqX9FliI4J6F+OLXSXpK3R5fsFGyAcN9QkRxkErF6rHGSOlhkRDKckqmG1mJFtrnaRv1fgpPs90t8ec255Km1w54p29yeRrZqp4z1IubanaTL1q6C6RDHgYIqV0mYcH/Sb6VsPEnlTQWEM/XNh+WlZ/paIToHnBAz9fTEsstTQJb71RRMldovFpraVxtkdp957ztz6OWascbsLM7W7APfBo/+MOmE2Z2PHODg8JWbNqSSTA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4684.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(346002)(39860400002)(396003)(376002)(366004)(33430700001)(33440700001)(5660300002)(6506007)(8676002)(54906003)(2906002)(52536014)(478600001)(7696005)(8936002)(53546011)(316002)(76116006)(186003)(66476007)(66946007)(55016002)(9686003)(66556008)(110136005)(66446008)(33656002)(4326008)(71200400001)(26005)(86362001)(64756008)(491001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: GCkZXNL3uOkmCedDzjJOfLZSaxAzEVvL3t6JPnW1JzbNpcWeqlVU99PQqmdcqVkJFt9aNobGkQln3ngRFgvH2c468dgc5I+4oIc4Bw9zUnu6psv0bsoDqaaD3rXWXM+XBX8kBq8fv7La0/npOk/zZbjFF9SWnC0uCzH3xeDRz/HUbhgXCCjkLub85GMt+rkahvtg62Br4Y+L55S2JIypD3of8I6zVsx/AlOcf7b33+iYIv/4v73mVCS0sDlxhkzq7CR7UzbobkD1mu0ftKEu934HWgL13QX114wniBKtSk5Zyv5RxCrrN+JpPI51WaVTtVV8FTRGtnz2vLhay7GDPEh+Qg4lKYML2h2eylyl0eAvJrTnHWce4lZU2fpGv8Wm7IhfnDjeHCu1Wyjpk9XL5Y8rZgn2GU8TIUZpvLEeOQ2ZmsD++kyriGsgCtz6H0NkupgIFAoBwur6vFIP5LZWkdxKiFNqRyIK93cYQhywhwM= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7547ce60-25c6-4413-5cc6-08d7f6cf38e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 23:50:16.6988 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A/UmQ5caJO0C405Q/uhE9ubuMGY0gV8xv4rKCuaN2o5LMWNZTogZDVkRZj6GC1VEv996n0FRcvckHI1sJuX4Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4617 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] lib/librte_hash: avoid iterate bugs with delete keys. X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Lilijun (Jerry) > Sent: Sunday, April 26, 2020 8:41 PM > To: 'dev@dpdk.org' > Cc: wangyunjian ; xudingke > ; 'stable@dpdk.org' > Subject: [dpdk-dev] [PATCH] lib/librte_hash: avoid iterate bugs with dele= te > keys. >=20 > From 0faea722b82ffe30adfa55d5ea4ad3a23ed30d4e Mon Sep 17 00:00:00 > 2001 > From: Yunjian Wang > Date: Mon, 27 Apr 2020 11:12:25 +0800 > Subject: [PATCH] lib/librte_hash: avoid iterate bugs with delete keys. >=20 > The keys idx are stored in rte_hash main and extend bucket key slots. > We iterate every no empty Keys in h->buckets and h->buckets_ext from > start to last. When deleting keys the function > __rte_hash_compact_ll() may move last_bkt's key to previous bucket in > order to compact extend bucket list. > If the previous bucket has been iterated, the moved key may be missed for > users. Then those missed keys are leaked and rte_hash table can't be > cleanup. > So we add a new API rte_hash_del_key_fixed() used in iterate loop to avoi= d > this bugs. >=20 > Signed-off-by: Lilijun > Signed-off-by: Yunjian Wang > --- > -- > 2.19.1 [Wang, Yipeng]=20 Is this the same patch to the previous one? Please see my reply on the prev= ious thread. You could add " --in-reply-to" to supersede the previous version, which wil= l make the maintaining work easier.