RE: 21.11.9 patches review and test

["Xu, HailinX" <hailinx.xu@intel.com>]

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, December 18, 2024 1:48 AM
> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Richardson,
> Bruce <bruce.richardson@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Subject: Re: 21.11.9 patches review and test
> 
> On 17/12/2024 11:30, Kevin Traynor wrote:
> > On 17/12/2024 10:01, Xu, HailinX wrote:
> >>> -----Original Message-----
> >>> From: Kevin Traynor <ktraynor@redhat.com>
> >>> Sent: Wednesday, December 4, 2024 11:59 PM
> >>> To: stable@dpdk.org
> >>> Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> >>> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> >>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>;
> >>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> >>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> >>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> >>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> >>> <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>;
> Thomas
> >>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com
> >>> Subject: 21.11.9 patches review and test
> >>>
> >>> Hi all,
> >>>
> >>> Here is a list of patches targeted for stable release 21.11.9.
> >>>
> >>> The planned date for the final release is 17th December 2024.
> >>>
> >>> Please help with testing and validation of your use cases and report
> >>> any issues/results with reply-all to this mail. For the final
> >>> release the fixes and reported validations will be added to the release
> notes.
> >>>
> >>> A release candidate tarball can be found at:
> >>>
> >>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
> >>>
> >>> These patches are located at branch 21.11 of dpdk-stable repo:
> >>>     https://dpdk.org/browse/dpdk-stable/
> >>>
> >>> Thanks.
> >>>
> >>> Kevin
> >>>
> >>> ---
> >> Update the test status for Intel part. Vhost part is done, the other part is in
> progress and Found one build issue.
> >>
> >> issue:
> >>     DPDK meson build failed with EXTRA_CFLAGS='-O1' on Ubuntu 24.04.1
> >> -> fix patch from Kaiwen Deng <kaiwenx.deng@intel.com>
> >>
> >
> > Thanks Hailin. What is the issue reported ? Are you saying the patch
> > below [1] is cause ? The patch seems fine to me, it is just adding a
> > NULL check before dereference:
> >
> > -     if (vf->vf_res->vf_cap_flags &
> > -         VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> > +     if (vf->vf_res != NULL &&
> > +         vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> >
> > [1]
> > commit c78d01172de035fa7e997841d44b01f58ed7cf83
> > Author: Kaiwen Deng <kaiwenx.deng@intel.com>
> > Date:   Tue Aug 6 08:35:27 2024 +0800
> >
> >     net/iavf: fix crash when link is unstable
> >
> >     [ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ]
> >
> >     Physical link instability may cause a core dump because unstable
> >     physical links can result in a large number of link change events. Some
> >     of these events may be captured by vf before vf resources are allocated,
> >     and that will result in a core dump.
> >
> >     This commit will check if vf_res is invalid before dereferencing it.
> >
> >     Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message
> > without interrupt")
> >
> >     Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> >     Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> Hi Hailin/All,
> 
> I have an update on 21.11. I had to make the release due to a CVE embargo
> lifting, so I wrote up the validation status at the time of release.
> 
> There is a link to this thread in the release notes, so any further testing
> reported here can be found. Thanks for your testing.
> 
> On the compiler issue reported above. I tested on Ubuntu 24.04 with -O1 and
> there is a maybe-uninitialized warning on the iavf code. For ref [1]. However, it
> is not new in 21.11.9 and is not caused by the patch above.
> 
> I can reproduce it as far back as 21.11.3, and probably earlier (can't confirm as
> earlier version have other build issue with new the latest gcc).
> 
> It was too late for a fix so I listed it as a known issue in the release notes.
> 
> thanks,
> Kevin.
> 
Hi Kevin,

Sorry, I may not have expressed it clearly, what I mean is that the solution to this issue has already been provided by Kaiwen.

From: Kaiwen Deng <kaiwenx.deng@intel.com>
Date: Wed, 11 Dec 2024 10:15:49 +0800
Subject: [PATCH] net/iavf: fix uninitialized variable

This patch fixes the variable 'descs_bh' may be used uninitialized.

Fixes: 6ad2944f4e82 ("net/iavf: support Rx timestamp offload on AVX2")

Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
 drivers/net/iavf/iavf_rxtx_vec_sse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rxtx_vec_sse.c
index 3f1d5e2ce8..199f5f5ccd 100644
--- a/drivers/net/iavf/iavf_rxtx_vec_sse.c
+++ b/drivers/net/iavf/iavf_rxtx_vec_sse.c
@@ -825,7 +825,7 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,
 	     rxdp += IAVF_VPMD_DESCS_PER_LOOP) {
 		__m128i descs[IAVF_VPMD_DESCS_PER_LOOP];
 #ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC
-		__m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP];
+		__m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP] = {_mm_setzero_si128()};
 #endif
 		__m128i pkt_mb0, pkt_mb1, pkt_mb2, pkt_mb3;
 		__m128i staterr, sterr_tmp1, sterr_tmp2;
--

Regards,
Xu, Hailin

> [1]
> In file included from
> /usr/lib/gcc/x86_64-linux-gnu/13/include/xmmintrin.h:1322,
>                  from
> /usr/lib/gcc/x86_64-linux-gnu/13/include/immintrin.h:31,
>                  from
> /usr/lib/gcc/x86_64-linux-gnu/13/include/x86intrin.h:32,
>                  from ../lib/eal/x86/include/rte_vect.h:31,
>                  from ../lib/eal/x86/include/rte_memcpy.h:17,
>                  from ../lib/net/rte_ether.h:21,
>                  from ../lib/ethdev/rte_ethdev.h:172,
>                  from ../lib/ethdev/ethdev_driver.h:22,
>                  from ../drivers/net/iavf/iavf_rxtx_vec_sse.c:6:
> In function \u2018_mm_unpacklo_epi32\u2019,
>     inlined from \u2018flex_desc_to_olflags_v\u2019
> at ../drivers/net/iavf/iavf_rxtx_vec_sse.c:338:4,
>     inlined from \u2018_recv_raw_pkts_vec_flex_rxd\u2019 at
> ../drivers/net/iavf/iavf_rxtx_vec_sse.c:969:3:
> /usr/lib/gcc/x86_64-linux-gnu/13/include/emmintrin.h:1048:19: error:
> \u2018descs_bh[0]\u2019 may be used uninitialized [-Werror=maybe-
> uninitialized]
>  1048 |   return (__m128i)__builtin_ia32_punpckldq128 ((__v4si)__A,
> (__v4si)__B);
>       |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/iavf/iavf_rxtx_vec_sse.c: In function
> \u2018_recv_raw_pkts_vec_flex_rxd\u2019:
> ../drivers/net/iavf/iavf_rxtx_vec_sse.c:828:25: note:
> \u2018descs_bh[0]\u2019 was declared here
>   828 |                 __m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP];
>       |                         ^~~~~~~~
> 
> 
> >> # Basic Intel(R) NIC testing
> >> * Build & CFLAG compile: cover the build test combination with latest
> GCC/Clang version and the popular OS revision such as
> >>   Ubuntu24.10, Ubuntu24.04, Fedora40, RHEL8.10, RHEL9.4,
> FreeBSD14.1,
> >> SUSE15, AzureLinux3.0, OpenAnolis8.9 etc. -> one new issue is found
> >> - All test done. No new dpdk issue is found.
> >> * PF(i40e, ixgbe): test scenarios including
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >> - All test done. No new dpdk issue is found.
> >> * VF(i40e, ixgbe): test scenarios including VF-
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> 
> >> - All test done. No new dpdk issue is found.
> >> * PF/VF(ice): test scenarios including Switch features/Package
> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> Descriptor, etc.
> >> - on going. No new dpdk issue is found.
> >> * Intel NIC single core/NIC performance: test scenarios including PF/VF
> single core performance test, etc.
> >> - on going. No new dpdk issue is found.
> >> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> QAT&SW/FIB library, etc.
> >> - on going. No new dpdk issue is found.
> >>
> >> # Basic cryptodev and virtio testing
> >> * Virtio: both function and performance test are covered. Such as
> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> testing/VMAWARE ESXI 8.0, etc.
> >> - All test done. No new dpdk issue is found.
> >> * Cryptodev:
> >>   *Function test: test scenarios including Cryptodev API
> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>     - on going. No new dpdk issue is found.
> >>   *Performance test: test scenarios including Thoughput
> Performance/Cryptodev Latency, etc.
> >>     - on going. No new dpdk issue is found.
> >>
> >>
> >> Regards,
> >> Xu, Hailin
> >>
> >