From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6926245A68 for ; Mon, 30 Sep 2024 15:27:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E8214027C; Mon, 30 Sep 2024 15:27:41 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 67AA94014F for ; Mon, 30 Sep 2024 15:27:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727702860; x=1759238860; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bCs/32H1vXRKHhFjJMid6SBWRFfReNYaehAuIHoCKvA=; b=kXr18yDDdy/OfyGQ+fnRast91WJTP/YwyO6Q0BE+41S4wvHkaS6yf8Gp zA6UzKteRjNNH7bZ7+fiGRFSbQHIm8W9Dj9CfKeugYrQH+VO0IyCJoJI/ zRgM5KuanzLcksIIKyEz4uxP9PPLcjgvrwSa22+d/hQsozMb6d8MoFzJf JfjEJm/2A5aja3B5kDfH0cvVmd6+yWvaj0ZI4GSioRxAOa3rjfVQOYzBi RANROsl+H6zJizQOKKAjgxIsK3TE2YNaaOLvZcsrWRiAaxtqK5OCFKzGs zn16mfAPhJswfph3PC7qnqZ2GI2+lhhVuVo0vH3E2gNTNKz9P69aAj7lA A==; X-CSE-ConnectionGUID: xXuILxgKSKWNTwRICINVPQ== X-CSE-MsgGUID: 8v3vvHs1QQ27v0j7SYwuXQ== X-IronPort-AV: E=McAfee;i="6700,10204,11211"; a="26918004" X-IronPort-AV: E=Sophos;i="6.11,165,1725346800"; d="scan'208";a="26918004" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2024 06:27:38 -0700 X-CSE-ConnectionGUID: lKnlnvfnQDSlLsY5FvRoXg== X-CSE-MsgGUID: NBBCqKbAQ2KzGOmYmP6LYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,165,1725346800"; d="scan'208";a="77379678" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Sep 2024 06:27:39 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 06:27:38 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 30 Sep 2024 06:27:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 30 Sep 2024 06:27:37 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 30 Sep 2024 06:27:37 -0700 Received: from MW6PR11MB8309.namprd11.prod.outlook.com (2603:10b6:303:24c::19) by PH8PR11MB6732.namprd11.prod.outlook.com (2603:10b6:510:1c8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.22; Mon, 30 Sep 2024 13:27:34 +0000 Received: from MW6PR11MB8309.namprd11.prod.outlook.com ([fe80::ba43:b01f:aee0:10a8]) by MW6PR11MB8309.namprd11.prod.outlook.com ([fe80::ba43:b01f:aee0:10a8%3]) with mapi id 15.20.8005.024; Mon, 30 Sep 2024 13:27:34 +0000 From: "Stokes, Ian" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" , "stable@dpdk.org" Subject: RE: [PATCH 1/4] net/i40e: fix AVX-512 pointer copy on 32-bit Thread-Topic: [PATCH 1/4] net/i40e: fix AVX-512 pointer copy on 32-bit Thread-Index: AQHbAGbPJ1p98ImdkEm9P5lUD2HCb7JweBKw Date: Mon, 30 Sep 2024 13:27:34 +0000 Message-ID: References: <20240906141127.628873-1-bruce.richardson@intel.com> <20240906141127.628873-2-bruce.richardson@intel.com> In-Reply-To: <20240906141127.628873-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW6PR11MB8309:EE_|PH8PR11MB6732:EE_ x-ms-office365-filtering-correlation-id: 5ccfad1a-4366-4320-4d11-08dce153a4c9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?alxk8Wecqm9wZC4osbWj2HMS1vFu49+i14VO1K73QHrD4Y5T2xjY7AXhUwh2?= =?us-ascii?Q?cDJHha5JXqqjXUs7czGC5gNT2Rq/GKJ0XsS1OufgQMkGStal9y07WwpKA6Oc?= =?us-ascii?Q?sg5X+udCOzNZvpYhIk97Oy7p2yAKG2LMKAD15/9xKUULGdS1PBAFyTBQGUY6?= =?us-ascii?Q?RjBV4z5N/4uT4MdhpBoMvm0gHiTGmEGwDU36y6HeTAbS3JsNHIsAal+QVAOR?= =?us-ascii?Q?nVz0W/3oBp9xqHLTmjCEiINcTTOYMPG8w3dkI/auk9m5c840ajM2dTusOHuu?= =?us-ascii?Q?TxGbD5BsD8pXfH3NlNf5qOQhfe1r86G6uzsk8qzZOjctMDcJuaR+lT+Vvcuo?= =?us-ascii?Q?i+edL4GPeZvhfSqjuqZOpeXL9Apj7v+bOOad4NEFIDpt505lvyYdaHddQF4t?= =?us-ascii?Q?bvoQWnMItb3TzGDdvsoXiOqxdD/7PJSjdJpdx8fLREQ0v3PUGTvgMMB2MYlU?= =?us-ascii?Q?pFDUseVVw2pkPiUGM/sA4XwB4wNu0ZjCnSwbH5aHSNrh+IZQzx8UY8+tt6l+?= =?us-ascii?Q?cpjGtwQvo9gIMcq6Be2TgmEFMH9W5L1wFFh/hH+WbujkVh+YJ9FLO8NQbaZB?= =?us-ascii?Q?fljeJXDKcWp7snv/taP5pfVolbwbBJJzkioAlFgKV1L60zz1VO/MbfDI8xqA?= =?us-ascii?Q?PNIJyiCv5Gmo2vzeSDx3yWtbt3tsoM3++Ydb6jR5eWJCAuEJ3pN1Wk0etVp7?= =?us-ascii?Q?niPjC9f0DbdXaGf9Y5g2iZFNaJ0u3xQIqNsJg7rPwAtdE1+Q3jup8fR0RhtP?= =?us-ascii?Q?KDrpF6m27+034W8hWUOLApkv1tup/DX4pjsdhsC6u0fjpM4keSVaWzsK+eoH?= =?us-ascii?Q?+G8GNAJUe0d7sU6kW7nHZcFc9fA8erqTQ1SsgbfvzTaUUeocGHyo4Hl4ZjzZ?= =?us-ascii?Q?i/BlbM+7/hZl026aOCvQNI0+g91+sO9oqUmJwB6fmjpnDuEQ0UUpzgyZ8MIt?= =?us-ascii?Q?GjwqYKYmsjK4/uVDKBQrw0BxnYkvW8j6IWFXJWPgrW9665sBGHJCSvFIzsCt?= =?us-ascii?Q?si6Rw6oRMkwz8HGRkCHSRBfkjSnStB5PLu/3wNBtRWJ+uDvdUYwwLd2dB20B?= =?us-ascii?Q?F4cEmIZoMJYZ0zO6fpFP0oV3BhLZr1lCxOT3Ajk5vmPIDP+ZBZtJ3CaRe7wr?= =?us-ascii?Q?nmCTj7rhFccUpruzM9/zTuUYqrSIcbJVwCHJO2G/7KVrNDEkzOlyEPpn7n29?= =?us-ascii?Q?Fo+tO9ZGW7lVN7IvKiA9qUGEaW4ehKwEeExw6kgROJial6Oa5dpKchhV20ol?= =?us-ascii?Q?LZlCKSwglQy1bn+ZvFxrJ3goouIHTrQBzvTLmDcQ9pUhmvvJ/g2FgnS9RBvr?= =?us-ascii?Q?KWEfm8MFjPXKzGhNdmyk7KkfFMZBNHar+WarolxCWWZxrwu4K3kFO/4oTj2F?= =?us-ascii?Q?P7cPYHGlw7zPG+58JrwKPccF2fvlYze+IgcCit0DF/rjTmNQQQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW6PR11MB8309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E/tX2BV9xOp5mx+X6IJaxMQe7d+l+kt3HE9KiX8Afbu9OemlqCksF+ryag3M?= =?us-ascii?Q?6G1botr219Fg7TPiSbG0GQ3V+iF+mEUFmmC6WnTxYZsjer/k1+2aEK1fqwVm?= =?us-ascii?Q?MNMXIZyvFZ742YiqPLm8NtW5VOU2WGKTVAg569Tx7KTKe07U+es6ek6fY4yn?= =?us-ascii?Q?k5Ltyc+semQHJPmE6/OCkhTPmpY3UhV6/+62KAL+jk34UzxcTtEa/Kfjm9Sd?= =?us-ascii?Q?/3v5o86s3vIWhd/g7A553GQd8LCuSXR0LcuUs4hoopn1mkS5SKGKKKrolXCU?= =?us-ascii?Q?mm8NTOma2Y2oP2yvCHEcEBv2ENdxc15AFrduqUwg0UgsN0dvrvK30OhjOqwo?= =?us-ascii?Q?m4d9OAEfWwrY4VTSeabmk/03nn6G4wEjh+bJLWSDlDMFVSr/vQ/FnsrDQD8p?= =?us-ascii?Q?W9YFf9AgTgKY/L4wNZxicvLB7asA1c09OVXiBtwYPuRtvAqzFpDzVxV6NAgX?= =?us-ascii?Q?P9imTrfR1RK4zM4rlS+jQljaUrH+Cc1R0JOE2PnEUO2tq+lj1fOKgJ3HYi5N?= =?us-ascii?Q?SRFFFj85XUC4a4UDxQJfzaRF/lh+CQER3CtM2lbksi+VTam0bTZRAS1h9+bX?= =?us-ascii?Q?Zk6tCSeZeEtARadII9iJbeEtWMVHb2DFj0A5Y19xp5UAIhFq8e1a3mBuX8mG?= =?us-ascii?Q?HmFNMRQdmCy67e3ZPSo1RgH++O81dKcQ58ZJVz2UeRbXR3DOPGxgEvqxv+YQ?= =?us-ascii?Q?t87TGrRRn/LV2Sv/JS8yiwgorTYk8E3bSdHSxvjqsQreiJXndUaLON3V4PHQ?= =?us-ascii?Q?ehXZdzvH0n7NPs+fZ8lRYLyXotbcpWslhJNA052Jd8iZxVAwTWM9noLLsz6U?= =?us-ascii?Q?s5UEDn9L1ovXqieMDM4SxgpwEBtR/rO5LOot1BTCExDPNDAay0USxGg1vOWt?= =?us-ascii?Q?5FK5n7jOouwHLND/689z7+Pzhf+hfruaRMHkcTrEnEWZE5C5QdUTphEggZkl?= =?us-ascii?Q?ABPUmILQ/4O9VPvY2be/4XWfYYkM3JMIWFFv6sxybwvB5xH9x/vNAsq3qVMe?= =?us-ascii?Q?o1nfTmt5UK8PeUyDqIAUFpQE2G84+clZ4cdI8NOWUtpIWILemgt88uAyn5YO?= =?us-ascii?Q?sbV7Eqhu6UjyA4M6b1ImWEGZJU6YZCDP9UY5ZP8ZzxzFJpgswCMO/x9DfUak?= =?us-ascii?Q?ngxyVeXyHBguxrqYXyn3bEsBSd3Bpg2dsHugt/jLFVJvvvZQ+WkrQuFcP/Jn?= =?us-ascii?Q?Xr6WD/VVJWprjvXoEk93DhWUMCLsLqNEwoxHEDN4DcGykowYpoZh67Aw+rrx?= =?us-ascii?Q?0hAHdgk9g0pU5H1DoikchdXf7qxz23Ow7x8OZ7/vBqAa7+I3ITedNgWfiiKG?= =?us-ascii?Q?pmEE7nc/x+etfzud+Ga495Nb0vG4DVpW4O3UU475b4HTQf63LiO2t+fvorwI?= =?us-ascii?Q?A0nwZg+RE7qWM+j1bms2dSi+gDYXpd8SODmmQgcA5NjnJpy8dwvyVA/9eW5d?= =?us-ascii?Q?4uGXndlO9m7kCVELm6b+YKxhN/unmAQe1SSQWgVymKZOzdmMmbGLKWPYz9h1?= =?us-ascii?Q?ENK6zPsRknWYb85mN7LTJlRM8UaLhtCfWw/lx4+YpGgsTzSBATCfkqKPLsuB?= =?us-ascii?Q?/loCgz7p3iMwec95PsgF/0Fuk1wNrfns6VApMNFo?= arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=drjUTwqY4xkS4FGsiL+SUQjg9r50/ot4mQ+LW/HWsKQNu9LYmES+zZzrYGq0p2w9xudQZNiXMsu60Gto+oHctDw7Cd4mVP9iqDMR+8afJMXeHFRNQ3JlgsF7q6H+NyoxXU4mrywCnC5lv2+K5NLzUvIstiPO8FI8tIFSjehbsn6ezoL8+XzClf8H7FxoEH8bMALj7QONjrctoM/KJFaCmldGsvQ2WWDN+Pg5+JJRwfd0aVcAivwkOBSydCQ9qxd0w+iNTpCYB8Anhspb0+dXagcY72T410WyCgOv+Vbu4/d/Llej5RbLqmxB3qkK13PYbuXPbhbaRZjiRGW6HapVIQ== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gd5cEPUmzpv+ajrR1Dmsa2g04Dan+h9q7f8e9Ra7jZs=; b=k4JZkBcuiZbCjtKJui09Qxjn9Z2HPV9HdvWYeq3MrWgNAOEPoEgimpxO8SqA7VoH+JB0TeJnl2xv8p8GfYz2rbBtKM1OBRykE3E/mzAb0ajhN9M3Pxr4fOfMrNuXSoGhHQeYFaE+YQuMcEVdMC62tXikC4BXpQ7kxz5WnBkfY5dG0qIX8A3p2qUVqC6kQRQlawW0sOrofvJQM8p2bXZV38wc1W97F6GUvx2Vj9eu1w0KRhB8ZLRR64HrtQjGnRfRYKQ5XKBWaZ4t/s1nqn3fq+sY9EGjWxKqL4wuf1+MF08exM5+7KPTH8OTZzK9FlzG+pBSW8ByYD8mo4ucNvKxMQ== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none x-ms-exchange-crosstenant-authas: Internal x-ms-exchange-crosstenant-authsource: MW6PR11MB8309.namprd11.prod.outlook.com x-ms-exchange-crosstenant-network-message-id: 5ccfad1a-4366-4320-4d11-08dce153a4c9 x-ms-exchange-crosstenant-originalarrivaltime: 30 Sep 2024 13:27:34.2876 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: zIsE99OvAgs+cnMAtVl1z/xvMGIE6lIt0KxMRSB9WGjhzSPFcNxN7Q9RI0EK3jS9/o3f5NdUUe3Jm3GA67HI+g== x-ms-exchange-transport-crosstenantheadersstamped: PH8PR11MB6732 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > The size of a pointer on 32-bit is only 4 rather than 8 bytes, so > copying 32 pointers only requires half the number of AVX-512 load store > operations. > > Fixes: 5171b4ee6b6b ("net/i40e: optimize Tx by using AVX512") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx512.c > b/drivers/net/i40e/i40e_rxtx_vec_avx512.c > index 0238b03f8a..3b2750221b 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_avx512.c > +++ b/drivers/net/i40e/i40e_rxtx_vec_avx512.c > @@ -799,6 +799,7 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) > uint32_t copied =3D 0; > /* n is multiple of 32 */ > while (copied < n) { > +#ifdef RTE_ARCH_64 > const __m512i a =3D _mm512_load_si512(&txep[copied]= ); > const __m512i b =3D _mm512_load_si512(&txep[copied = + > 8]); > const __m512i c =3D _mm512_load_si512(&txep[copied = + > 16]); > @@ -808,6 +809,12 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) > _mm512_storeu_si512(&cache_objs[copied + 8], b); > _mm512_storeu_si512(&cache_objs[copied + 16], c); > _mm512_storeu_si512(&cache_objs[copied + 24], d); > +#else > + const __m512i a =3D _mm512_load_si512(&txep[copied]= ); > + const __m512i b =3D _mm512_load_si512(&txep[copied = + > 16]); > + _mm512_storeu_si512(&cache_objs[copied], a); > + _mm512_storeu_si512(&cache_objs[copied + 16], b); > +#endif > copied +=3D 32; > } > cache->len +=3D n; > -- > 2.43.0 Looks good to me, ACKED. Thanks Ian