From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Sun, GuinanX" <guinanx.sun@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Sun, GuinanX" <guinanx.sun@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting
Date: Sat, 9 May 2020 07:34:55 +0000 [thread overview]
Message-ID: <MWHPR11MB1391409C7BE42AE1078C7F4AB7A30@MWHPR11MB1391.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200218033931.81821-1-guinanx.sun@intel.com>
Hi, guinan
In this patch, you have add a new parameter of mac_ctrl_frame_fwd, it should not be clear in ixgbe_dev_stop(),
Or it will be over write when do port reset, and also you should add mac_ctrl_frame_fwd in ixgbe_flow_ctrl_get() for FC info get.
Although this patch has been merged, please commit fix patch for it, thanks!
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> Sent: Tuesday, February 18, 2020 11:40 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Sun, GuinanX
> <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting
>
> When the port starts, the hw register is reset first, and then the required
> parameters are set again.
> If the parameters to be used are not set after resetting the register, a read
> register error will occur. This patch is used to fix the problem.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> v4: changes
> * rebase to dpdk-next-net-intel
>
> v3: changes
> * wrap duplication code into a function
> * Modify checkpatch warnings
>
> v2: changes
> * Modify the initial value of requested_mode and current_mode
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 76 +++++++++++++++++++++-----------
> drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
> 2 files changed, 51 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 3aab24e82..08b4cc689 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> + }
> +
> err = ixgbe_dev_rxtx_start(dev);
> if (err < 0) {
> PMD_INIT_LOG(ERR, "Unable to start rxtx queues"); @@ -2900,6
> +2939,8 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
>
> adapter->rss_reta_updated = 0;
>
> + adapter->mac_ctrl_frame_fwd = 0;
> +
Delete it please.
next prev parent reply other threads:[~2020-05-09 7:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 4:43 [dpdk-stable] [PATCH] " Sun GuinanX
2019-12-19 10:17 ` [dpdk-stable] [PATCH v2] " Guinan Sun
2020-02-01 13:12 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2020-02-17 7:51 ` [dpdk-stable] [PATCH v3] " Guinan Sun
2020-02-18 3:39 ` [dpdk-stable] [PATCH v4] " Guinan Sun
2020-02-18 9:21 ` [dpdk-stable] [dpdk-dev] " Konieczny, TomaszX
2020-02-19 7:06 ` Ye Xiaolong
2020-02-19 12:44 ` Konieczny, TomaszX
2020-02-19 15:27 ` Ye Xiaolong
2020-05-09 7:34 ` Zhao1, Wei [this message]
2020-05-09 8:54 ` Sun, GuinanX
2020-05-09 9:30 ` Zhao1, Wei
2020-05-09 9:48 ` Sun, GuinanX
2020-05-09 9:49 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1391409C7BE42AE1078C7F4AB7A30@MWHPR11MB1391.namprd11.prod.outlook.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=guinanx.sun@intel.com \
--cc=jia.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).