From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4D72A04A2 for ; Tue, 12 May 2020 10:39:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C73501C1D8; Tue, 12 May 2020 10:39:52 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1E5651C1BB; Tue, 12 May 2020 10:39:49 +0200 (CEST) IronPort-SDR: tkvPxh/N2aBn4h7bY7mCe3RplEac0zfFfc+6Y0MgC3e9WH8iMvWtOEUUojtuFXTSowGJl6poAP 48q/rJjOKzQw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 01:39:49 -0700 IronPort-SDR: OCvGCBPlsqBbtcnrZ1OpxPglqrpMsxgUFoyCE0rrnvMC1jvwrQqanGdg2DxngDgvIaO7p9HspZ K55qNHrE/s+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,383,1583222400"; d="scan'208";a="437019534" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 12 May 2020 01:39:48 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 01:39:48 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 12 May 2020 01:39:48 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 12 May 2020 01:39:48 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 01:39:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkJngUy3ZhZ1weOX9HJ7PhIIJxCgi4SMm9H18JxhLrZpcU1DuM2xJVorlJplcsJ0QDlI+nkcb9hoBHH2DsAJbgRsY6/b+e7fuadl+WbhG9yRzGFiMU5QqWnCg9IlBhtXLmsUerthxWXtu53FNWESdGnXqPE5gUvjMoSM7X//WiBAzL/IG7JZw+BM36BvVIa6D//T8VqnygpCy1jZRLqhIncLEtco6WAMS8h+60Zb+7cJhKVU8DEE+5lxdJB4CRuEKTjwPb7kNRGDWrIPiNoyPqxe/vY0PMGK9je3ScRwJFa7Lxf+l1dI4U+rXe8mACZNUN06ICtIbEERNATdVw1/hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v32rqL4/uJ3inldBQAjo2AWYidRZl5S41/DQkipmvzs=; b=mEwZK/AD3mB2FnxQZYlPPMGXFSEkcbcT4OW626x3Tre8dqI0cbsg2C1sptt4R91ZNP7CI0o3VqG0dtpcDuaTbw90J3N/mpUMGFIQFayTk5OHoLjPOIIlrdJ9QL5zNsHdvYT3QtCJLeHF1unRsqogMSagasmaH9RbGgqtViJqBuqcyTw0ZStBkuodx0m8T0xdWyfWVAnrAf2W+BAim5tbbnc7qLi03zV6uaLf3lE57nWjI33xxJf2tN+zqoOC3kMjr9ZdYQPGmNW95EEwsTlTqVG7ng3VEe9YzHIHynzfFHc/BFQB3fu9c2xId948Sh3gsNKwPmJt2mTY/TrRREU43Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v32rqL4/uJ3inldBQAjo2AWYidRZl5S41/DQkipmvzs=; b=o6TPXPqIVmyiFiywwwTHvGyX/tbqlwDnKO671GiB38SlZvdKzM1GsMs04UPi5N3QVzAjMRVN53uyhB4odZvV1/827NxeDgPokQ4u2YbgTVMAKO9Dz5w+qmvD8F9hFFw9bt7xCSdLilPkVFo6yiHaluCtOb67yw/aawf8OElCeSk= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1934.namprd11.prod.outlook.com (2603:10b6:300:114::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Tue, 12 May 2020 08:39:46 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2979.033; Tue, 12 May 2020 08:39:46 +0000 From: "Zhao1, Wei" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Sun, GuinanX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control mode Thread-Index: AQHWKDb/+Y6f6KYr+0K/ZxWpTyUtuKikISJQ Date: Tue, 12 May 2020 08:39:45 +0000 Message-ID: References: <20200508082939.32525-1-guinanx.sun@intel.com> <20200512081306.16013-1-guinanx.sun@intel.com> In-Reply-To: <20200512081306.16013-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWM3YTRiM2YtYzE5NC00YTM5LTlkYmMtMzBjNTNjNjBiODY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidzRWVFMrcXVzXC9Wd2g3eGZwd0tuZ2VQVVVLVEVaWVhKK05mZm5ETmp5TWpcL0hoQkJDOHg5RWV6ZVQwQXRUOXlrIn0= dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 917d47b3-be78-491a-e4a3-08d7f650065d x-ms-traffictypediagnostic: MWHPR11MB1934: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:561; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5R3QzsuZOEeNUbTxztTh0QAd1v+8Ib+XQo1eS6bCVVYXIlhr+KF4EI05/M/0zig7Td+74x7RRJ6o+LEaYxRf0PDFyoSlBbBH4OMR52A8xeVZYqKxV4t40MP8KUdWjryiQlr0alxPnxa66E05OPRc5j75d+Hs4fwQPjHc35qaB0yV+qa20Jr0EpltzwcOTiSz1QyTG4gyJ5if8rJW9KzvIq3OBlI/dKhHWlmG333RuLtg1wDPE/nUNJ7eM6AdQhDMOWckdrKhEJNznUPDdTQRR8rqmFBsLUrXpzmSR5ZYC3gew2uA/6iqTm2/l/M3HZ/vy2DgyQNNryHq8rCVUZWOsZjYAMc0h2YnHGYYBEn/29cCM573OF9J9Mr9ME0KRYRpI+7IHuXaHkZLidVCUjMx6Ontb1LTP/5+iKZnUWNGZgHgD/Yg5TXUEYaBcXAC5hjU3NNtnve4YEGIl6y4DCiM3tWVJaDFn5yrhF+ixcF4laYzpHFXPyKqt1JXj9bcKOssBei6s/LfEn50mrizcPYUNw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(39860400002)(346002)(376002)(136003)(396003)(33430700001)(66556008)(186003)(66476007)(66946007)(26005)(478600001)(8936002)(450100002)(6506007)(55016002)(4326008)(9686003)(2906002)(52536014)(53546011)(316002)(54906003)(110136005)(86362001)(66446008)(76116006)(7696005)(64756008)(33440700001)(5660300002)(33656002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 1popg7VFKqzVehM2a2tPnnHDzpmtrb8KnKmJeRbRpPy4OfT4DF7MNHn+tSsVrEoLb5lqEpc6YI/cDGyQsFccAPzQA6UVbpHmAQvrUM6kto+oRBl0dYLcO1tH2pMDZPqUhc1qHqJCoqngKshbKckfECQM0kcTEDrvnmqII+d+1JSETLufltLSiiinwuNttQucvOve6GqAO/7UWnu3Dh80tu8xTPjx1UWO0T8Rc6zMhzoPFm8zs9/EprzkocZOOzIaz3y2SwrzSMHekHiK/hMrPonOL8mwKdO06JR1XKqdXeGE4w0ckzg+quAtedVOBUiQZCWbCl/ebGreyAL1/O9dH3m9mwTpVkGS7G/Fm6tT1cHVzOofo+SyrLuYGUelyCbJWbHGEzdiAYynpPx7dAeytoYk/ero7LrEQx2LgqIsXFRG1jY1t+/que3edUlHjaw+JSKxFKKGUFj6jogdf24xa0k8ShF+hxN7su4/LoGJnrE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 917d47b3-be78-491a-e4a3-08d7f650065d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 08:39:45.9798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QRh56hkNHcPSS4yoKDl/RsjQONVsbCSJtxmwNSVIVdtIUo1KOXaRTLPmNpveboFxh2oKldMbdNCX7O08a79KTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1934 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Reviewed-by: Wei Zhao > -----Original Message----- > From: dev On Behalf Of Guinan Sun > Sent: Tuesday, May 12, 2020 4:13 PM > To: dev@dpdk.org > Cc: Sun, GuinanX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow co= ntrol > mode >=20 > The register autoneg can't be updated synchronously with flow control mod= e > setting in the state of port start , so NIC statistics error occurs. AUTO= _NEG > Advt register should be updated by ixgbe_setup_fc() when enabling flow > control. > The patch fixes the issue. >=20 > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > Cc: stable@dpdk.org >=20 > Signed-off-by: Guinan Sun > --- > v2 changes: > * Replaced mac.ops.setup_fc() with ixgbe_setup_fc() > * Modified commit message. > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index a4e5c539d..f8a84c565 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, > struct ixgbe_hw *hw) > int err; > uint32_t mflcn; >=20 > + ixgbe_setup_fc(hw); > + > err =3D ixgbe_fc_enable(hw); >=20 > /* Not negotiated is not an error case */ > -- > 2.17.1