From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A121A0093 for ; Wed, 20 May 2020 09:43:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A9911D15D; Wed, 20 May 2020 09:43:52 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2BAF41C1E5; Wed, 20 May 2020 09:43:48 +0200 (CEST) IronPort-SDR: KckFvsEiqspo2sMJDwz9Wwd7rRkqBewOMRMmmqTu7C3igiB9fi9gUB+0yHkH8u1XUCFVSkdT4G 4Y8EwkBJVXWQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 00:43:47 -0700 IronPort-SDR: MIEOTNmBYbMe82+oiMl/DswPbIUDW8UR2jo8vcDmwCmfujjy+uEmgmffPx29TQz0IdMueV3xsJ ylEUaow1U8ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,413,1583222400"; d="scan'208";a="253523123" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 20 May 2020 00:43:46 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:43:46 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:43:46 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.56) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:43:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tlg3G7u8VSPc/b2NnYyd3MSke1IsVWWRj1vquDA3hOV6AYMUEFNO581bCZILXQi2fSJ9fWMo1O9Y3eI5iUXX62in+7KXckt/VqgU2aTiHZRiYxPgtfnLSSjCiaK3+8vQHsES+x8pakJSFV6iFCy6Tn7iSxYDKeyOgr9lsnypPZBhuYbcgCun4Cpb/uSouLPDHDxuRpmvNRKnPtN648TZWHQOlA1a9bYx85/QyCdD3bmftK+WQg5gdN/XQo7m/lQQi81w+FG7LuIK2pVtCBKSDzhBUguvPjhf783wzLSsKPYQRzQtHUS396JtESLjzDmOett1EF5Wwnm10uooIH8tbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CPit3hmAUbaC3++wQ7a2GG6s8VQBj3u3KD6NShuLMI=; b=YLjIH8WnLLBt/zFQfo+lpwfrRSF5iXWCsXWsm7xwg0uboiLKfkMhWvYBkbiJeVMp0RS5NnX8eTYWrFo6rZq5TymMPEytmNSqtb871Ip4jPxushYJlry7tlVYt1/+x/MwMd7Js0FTu8+nc4sNURCY2i84ECJ5Qj0PqHg3BW+yPwuwkzFCbTJeO6uhftQgYD+ef5UZHvccZl8CgI972hAB+tZyCoYeb5+WN/A4s3l99CGicKJwB4YeV94vHPcgra3UOSc6tn4rppwnLrLT89r6wjBAPsKbzI25wgTkvhK5s0/r/CwOe63p2100KV48U7FbCFftjvxzs88YV1j5BEmkrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CPit3hmAUbaC3++wQ7a2GG6s8VQBj3u3KD6NShuLMI=; b=PleaJiiXCmdFyJGsx4fouBgw4sFdWhEj6EZEhtkqCeUBc3A+4rPvXrXmubo2KJWJz4bJeHcwqQ/p4fF9hmA8SEwVS5E+zLGKMwiiKfI6oWJFJGli28sGoefF+tju0Tu66VhE8FFF4AZr9S+3VZKoKggAnb/edkqUY/N0G3u8i3E= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1709.namprd11.prod.outlook.com (2603:10b6:300:25::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Wed, 20 May 2020 07:43:44 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3000.034; Wed, 20 May 2020 07:43:44 +0000 From: "Zhao1, Wei" To: "Xing, Beilei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [PATCH] net/i40e: fix flow FDIR enable issue Thread-Index: AQHWLbDS52Dfvw1zOUeWoPquTSBw/qiwXrYAgAAQMUCAACi+gIAAAP0A Date: Wed, 20 May 2020 07:43:44 +0000 Message-ID: References: <20200519071652.26537-1-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTg5MDEzYTYtNTM4ZC00OGJhLTkzZmItYTljYTE3NWJjMDIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid3ZhZmRna2s2S3dBQWt6SVFcLzRsckh0aUhyREJjejBVaW41Z2luTFlvTXBUWGNFM0Y2OEUxaGFcLzM2Ulg0QVhDIn0= dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f37987cc-46a3-4b38-c719-08d7fc918649 x-ms-traffictypediagnostic: MWHPR11MB1709: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L2f4l2t94Xne9L+Wz+jYJcv9y2V1oB7pnc5Oc9noOCwOOHu5Gf5kH/I3VbPTgK90PFfVDJp6DssQ6LqjsbzV4QeFydTAizsUzo/bbl/HgupiGBrwNFQ0h8CFsxOQFS81Jz6SKjv7mRg+5TNOFR165vKvMLr0ouNMaJsllSYIA8XMBnWsT+ws487flDnHn82tXgLEz6Lbhmt+biNbyn1H0FZvXiJMACj9QqAIakj6rfy2BOZ2D3O4RzKFKTunPpSGxdy6PVTpnVyVjfTCeQWb5GeBBHH94d2QZSqXuPGFKiz2XPOjajmJVNst12RMMp5U9w55tOV7w4pM2lzx/86q2t29oqKYwGDMWrGttsBaWOUyMld4xG5mHlyAsNIDFz7yezXNznT/zuoCJPj5gG2DwRANACXqIaewkA/FuLoNGiAlOfNfmHmeHyY0riCBv7hp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(39860400002)(366004)(136003)(346002)(376002)(6506007)(107886003)(478600001)(66446008)(64756008)(4326008)(55016002)(316002)(450100002)(8936002)(76116006)(52536014)(110136005)(66556008)(66946007)(66476007)(2906002)(8676002)(186003)(71200400001)(33656002)(26005)(7696005)(54906003)(86362001)(53546011)(9686003)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: R9m6CnYGwPeg0viwdjmNtihbEr9HL5MxICfFB+wGgnFySfwMT2eW/4WvNPFRmliIjoQ22pf5nDHyHk0HoRFmkcJz7eMpssQ0tS8/uQq8HrYt/mONmNQXhhK3aP9n4QQt1fQTmjgALmZauXHUAu5kSSU9KXdOiVihSy+ySA3dwNvJWZ8U+zJSauBX4RI9i+W/LO4Cy2JXCG382Ku/dbWI17F/7aYJEQHdHPp2efQgovId/Y0zcnRYJZ2gQSP7EqmZt0Y1+CXkKtSo9X3+YmA5/vHowGe0y0hgSi+jlEH7uLsQC+N58WJsB8GZurVw2QU8nFCCZlZ5xfN/bpvIm5/AdNDbwjZ+A1pk6VKEkDtVHIOPKe7Tt8liKAUMZDNop8tWB/V1vHs1z12zUxbAoxs9C39OvI4ouqg50GvD8cwbfPge43HuyORYhkXc61js7ITa6KicWAKLJPbdJCNx6g886b8BlFtEfnS6GM+PP0A7xs4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f37987cc-46a3-4b38-c719-08d7fc918649 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 07:43:44.8024 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jsAzmOgWaX7qizALjkzswiQ1RVlXcFK7YEESS78300QSVX8FSGuzYhcahyMW7v7XpTLyD9dxGxF8nVaOu6BNJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1709 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix flow FDIR enable issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi beilei > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, May 20, 2020 3:37 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Guo, Jia > Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue >=20 >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Wednesday, May 20, 2020 1:13 PM > > To: Xing, Beilei ; dev@dpdk.org > > Cc: stable@dpdk.org; Guo, Jia > > Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue > > > > > > > > > -----Original Message----- > > > From: Xing, Beilei > > > Sent: Wednesday, May 20, 2020 12:14 PM > > > To: Zhao1, Wei ; dev@dpdk.org > > > Cc: stable@dpdk.org; Guo, Jia > > > Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue > > > > > > > > > > > > > -----Original Message----- > > > > From: Zhao1, Wei > > > > Sent: Tuesday, May 19, 2020 3:17 PM > > > > To: dev@dpdk.org > > > > Cc: stable@dpdk.org; Xing, Beilei ; Guo, > > > > Jia ; Zhao1, Wei > > > > Subject: [PATCH] net/i40e: fix flow FDIR enable issue > > > > > > > > When we flush flow FDIR, all queues are disabled for FDIR. > > > > If FDIR rule is created again, then the flow list is empty, as it > > > > is the first time to create rule after flush fdir filter, so we > > > > need to enable FDRI for all queues. And also, disable FDIR for > > > > queues should be done in function i40e_flow_flush_fdir_filter(). > > > > > > > > Cc: stable@dpdk.org > > > > Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director > > > > filter") > > > > Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value > > > > in Rx > > > > queue") > > > > > > > > Signed-off-by: Wei Zhao > > > > --- > > > > drivers/net/i40e/i40e_flow.c | 12 +++++++++--- > > > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > > > b/drivers/net/i40e/i40e_flow.c index > > > > 25c77e7aa..94fc73092 100644 > > > > --- a/drivers/net/i40e/i40e_flow.c > > > > +++ b/drivers/net/i40e/i40e_flow.c > > > > @@ -3462,6 +3462,12 @@ i40e_flow_parse_fdir_filter(struct > > > > rte_eth_dev *dev, > > > > } > > > > } > > > > > > > > + /* If the flow list is empty, it is the first time to create > > > > + * rule after flush fdir filter, so enable fdir. > > > > + */ > > > > + if (TAILQ_EMPTY(&pf->fdir.fdir_list)) > > > > + i40e_fdir_rx_proc_enable(dev, 1); > > > > + > > > > > > i40e_fdir_rx_proc_enable is called in i40e_fdir_configure, so could > > > you check if we can optimize this and if statement > > > (pf->fdir.fdir_vsi =3D=3D NULL) > > above? > > > > No, when "flow flush 0", the pf->fdir.fdir_vs is not NULL, but list > > pf- > > >fdir.fdir_list is empty. >=20 > Then seems i40e_fdir_rx_proc_enable(dev, 1) can be removed from > i40e_fdir_configure, since i40e_fdir_rx_proc_enable(dev, 1) will always b= e > called when the first FDIR rule is created and fdir_list is empty. > Or we can use 'else if (TAILQ_EMPTY(&pf->fdir.fdir_list))' to avoid dupli= cate > execution of i40e_fdir_rx_proc_enable(dev, 1). i40e_fdir_rx_proc_enable(dev, 1) can not be remove by now, because i40e_fdi= r_configure() will be used by legacy fdir. We can remove it only after i40 legacy API disappear. May be some user not = using rte-flow FDIR. >=20 > > > > > > > > > return 0; > > > > err: > > > > i40e_fdir_teardown(pf); > > > > @@ -5330,9 +5336,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, > > > > struct rte_flow_error *error) > > > > return -rte_errno; > > > > } > > > > > > > > - /* Disable FDIR processing as all FDIR rules are now flushed */ > > > > - i40e_fdir_rx_proc_enable(dev, 0); > > > > - > > > > return ret; > > > > } > > > > > > > > @@ -5368,6 +5371,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *p= f) > > > > for (pctype =3D I40E_FILTER_PCTYPE_NONF_IPV4_UDP; > > > > pctype <=3D I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) > > > > pf->fdir.inset_flag[pctype] =3D 0; > > > > + > > > > + /* Disable FDIR processing as all FDIR rules are now flushed > > */ > > > > + i40e_fdir_rx_proc_enable(dev, 0); > > > > } > > > > > > > > return ret; > > > > -- > > > > 2.19.1