From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BD85A00BE for ; Tue, 19 May 2020 03:01:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30DA81D58E; Tue, 19 May 2020 03:01:33 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E4C301D53C; Tue, 19 May 2020 03:01:27 +0200 (CEST) IronPort-SDR: F0CfsV9oedSqVityrsewYyv9JwN6ZUqNAwvznXC7ggRe9DmgdYVPM6BUfA617pC7eKMEtxIvbL ylADr1v2XHyQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 18:01:25 -0700 IronPort-SDR: vucXU4a0ukc8w8lX4W9zNb276qISMN/GcGUK4U9BSUiNtXq4taUxCkECeumXCEXXxuzSqRNBkB 4SL9c7L1yvCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,408,1583222400"; d="scan'208";a="465783584" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 18 May 2020 18:01:24 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 May 2020 18:01:24 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 May 2020 18:01:24 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 May 2020 18:01:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KVSA85lplHqhiPd+CWXJd1QCphR2eXvMRWEgMaJy7G//clvQer9eTa9A+atTCt0TQpDGyVJsYsRbP3OdgvOADLznWM/bbT/fKgEScgayVygt+Bxxky2H2SBYI/LVsfS3MOKTEHT0KtQlSfQ2jAdFmbz8TKVhcmGyHg8PjlKYaFu283UApTLFsRcTPbgmxEz85hvHcKekOVaA+n2MYrpSnXXmErxbbwl50Vmv+EiUd8yaucJP+KdNkWNTrk3HgwGSeWOvkQ4UPgHvdwoy475rjwU24ggR4K5FvDBWBoHmCZ/j8n42+R42ymFIe2n2P+qix3eDKQz8LGdUbolRtmBJhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=StEWT9PHmKZNCCPwlFR6NL7w3QYAG+HWtkra76SA5PI=; b=ejs4Cvubj/Uj8fmx4AQHa66hDM7NupRkTg88GTb5ciG2Ictl7gLj6h1RNAmFW2rN0MbKYqRBCvVH2IyAPvkz4NaDwuHMzZQmnBBWtiwuPXR0YC/dGG2+mAnaUE7eGJiClIOb+S5c1ZLotcHGKAk4XaBna6404VRsf13fSbYPaz/xc72wGhANCdEz6ij8irq9bw1OnUnlgp2NCYxHQzbhbum160I0KFeU8svKr3KnF8uVaqAuPcivO+7Evb+Iwa4KmQ92xn/RT5F07YkfrsRryVCZYUBixw0bADMJAA6JLrlM7kyai9krTofE1ygMTYzQIVpa/lhESjjdWScBv6MPDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=StEWT9PHmKZNCCPwlFR6NL7w3QYAG+HWtkra76SA5PI=; b=dTpcSJa47ovz3Ed7XpEMs0h0Yt39KohL+lLOc0t4J/HVc5wTKQU4uH4eLZsh/rdoIFGpjfcvSqH6yDm/UseJTxtYQLriwyNBDStQgvyNi+9njbWGWcXe9ff8DFy0R2CNv4NcEYPH0COCWaiknFgD5erHKeeyrVfjEm79EP5Ki2g= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1503.namprd11.prod.outlook.com (2603:10b6:301:f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Tue, 19 May 2020 01:01:22 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.3000.034; Tue, 19 May 2020 01:01:22 +0000 From: "Zhao1, Wei" To: "Ye, Xiaolong" CC: "Sun, GuinanX" , "dev@dpdk.org" , "stable@dpdk.org" , "Min, JiaqiX" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF Thread-Index: AQHWLLRtaZuy7bUtpEyu7QlDgEKDEaitZQbAgAEcsACAABa6MA== Date: Tue, 19 May 2020 01:01:22 +0000 Message-ID: References: <20200508015913.48764-1-guinanx.sun@intel.com> <20200508044618.70535-1-guinanx.sun@intel.com> <20200508044618.70535-3-guinanx.sun@intel.com> <20200518012453.GA93575@intel.com> <20200518233923.GD93932@intel.com> In-Reply-To: <20200518233923.GD93932@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWU0MjUwOWYtZTQ3Ny00NWE3LThkMDAtN2Y0OWU0MTYxZWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWmhnUCs3RHh0SGxFblNaN0VDSU0xMThWRkZoVEZJb2NsZVA3TWpkZjFYUkVtQThGXC9aYUo2WmV3T2U3a3o2TmsifQ== dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.220] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dfcd5a7d-7738-479e-2bb4-08d7fb902600 x-ms-traffictypediagnostic: MWHPR11MB1503: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MzXXooZdXknBYS4w4R+17leWa4IXyjCyPGNpnY3jM3SRy9nR2yiT6RE6T7oSagpDVwvr/gVlJkSaqM2YiRw6CHSCc2udpCEDpbRYFwMuws5R0DFiP5rwUdUu2Z1B23uIoWZac7hTMhx5SKcSPeHaYg9wnpELhs6r4AZ/TmuwGhSVI4y+JA2LTNDddE8Fl0xxOwKUgXGMbQZrBHVcn1OrFMkx9C4WJSh4Pgjujtpfwr18OcAkcVX3F/BgBhzTC5rKLoyaUzEQiAvVcyyNGI5hboiYtBDiqSClGKi5ZhmqYsAZNeRxq4X8BIYU8nFuG2JuFkSzxA3Llfvn6UkolOPLoOQiLYW6KG+L5wozXztt5YNmAShdI7c6xnsYDa0u/THeReB4rZf9YwGXs2XEafiYWAmGUQ3hKbcc8y6oV6Lvhk91KeJvuRCCLklnwbwiOEd7p4sSJwJM5wcxmSzhERW/hrjFt7f7AOYHKlJDB7ZtkuaJbFSobuSrB2ymWxMF8W/CoSAWrE6EZVWUfLIQlbMgsA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(366004)(396003)(346002)(376002)(39860400002)(55016002)(6506007)(316002)(71200400001)(76116006)(66446008)(53546011)(26005)(54906003)(107886003)(450100002)(64756008)(4326008)(2906002)(9686003)(6862004)(86362001)(52536014)(6636002)(966005)(186003)(8936002)(5660300002)(7696005)(478600001)(66556008)(8676002)(33656002)(66946007)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: IQZbLO9/X5M1DU5aE/9w+V21zVHULXo2gwcSL3GgIocTqXTIZywcFk3Phyd4nV3ha6TeXn5laiJ19+1xhFEcta8GgexzXNSh/EB7cjoGezO8qBZDje5XTfuXuaXuQxmViTIcIpN4zCaX19mJJ7zdy+0uGfvXqUedcI01xC/1sbYq9ZD8KJQ9oBCTIBCgE3qYYXcZ980zDQOqsziL+V0SpG/lsDWsPS2iMImk9ZllknrE9zw2EmOSZ3hqiTHMLdi5xLWhVyu9RX/mJ7wFHiqCV4JHOhKnfIovwjktJGWLwrOKxaXUKJ+kil4q6vq7JAVd4qmqr4SRpqFhKY1w6FGPxmBozcXJmD44Vz/8zHM7i/mGoNmFBtgCMoIP8mHea/Sajsk5N4XiyrIpT9zBCWsOKva10b7CL1/UEFE8MvzzadxuLfNZwQJ0m9GMpuQlDyk20wvRpkfkgNsrGH1yHWEN8TTk9WEtAp/rniGOQE1kmc0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dfcd5a7d-7738-479e-2bb4-08d7fb902600 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 01:01:22.6093 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mzmJ2099ptde7LkAcupbH3SW8g6As+xSisMTlnjfph2KBsr4AcxMdnEcNnEDpbatsq5ARRshYvMTfAc0j8/IVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1503 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] net/e1000: fix defects of macro in VF X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Ye, Xiaolong > Sent: Tuesday, May 19, 2020 7:39 AM > To: Zhao1, Wei > Cc: Sun, GuinanX ; dev@dpdk.org; stable@dpdk.org; > Min, JiaqiX ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defec= ts of > macro in VF >=20 > Hi, wei >=20 > On 05/18, Zhao1, Wei wrote: > >Hi, xiaolong > > > >> -----Original Message----- > >> From: dev On Behalf Of Ye Xiaolong > >> Sent: Monday, May 18, 2020 9:25 AM > >> To: Sun, GuinanX > >> Cc: dev@dpdk.org; stable@dpdk.org > >> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix > >> defects of macro in VF > >> > >> Hi, guinan > >> > >> On 05/08, Guinan Sun wrote: > >> >The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT > >> exist. > >> >If latest is less than last, we will get wrong result. > >> >The patch fixes the defect. > >> > >> There was similar patch before, > >> https://patches.dpdk.org/patch/65131/, if I understand it correctly, y= ou are > trying to solve the rollover issue, right? > >> Could you find the Ferruh's comment and check if this is a real issue? > > > >this issue has not been fixed by now, we need this patch to fix it. > >If (latest < last), there will be issue, is that right? >=20 > Actually the rollover case has been covered by original code. Yes, you are right. >=20 > Thanks, > Xiaolong >=20 >=20 > > > > > >> > >> > > >> >Fixes: d15fcf76c8b7 ("e1000: move to drivers/net/") > >> > >> This fix commit isn't correct. > >> > >> Thanks, > >> Xiaolong > >> > >> >Cc: stable@dpdk.org > >> > >> > >> > >> > > >> >Signed-off-by: Guinan Sun > >> >--- > >> >v2 changes: > >> >* Aligned line-continuation character "\". > >> >--- > >> > drivers/net/e1000/igb_ethdev.c | 18 +++++++++++++----- > >> > 1 file changed, 13 insertions(+), 5 deletions(-) > >> > > >> >diff --git a/drivers/net/e1000/igb_ethdev.c > >> >b/drivers/net/e1000/igb_ethdev.c index 520fba8fa..4cd4e55c0 100644 > >> >--- a/drivers/net/e1000/igb_ethdev.c > >> >+++ b/drivers/net/e1000/igb_ethdev.c > >> >@@ -47,6 +47,8 @@ > >> > #define IGB_4_BIT_MASK RTE_LEN2MASK(IGB_4_BIT_WIDTH, > uint8_t) > >> > #define IGB_8_BIT_WIDTH CHAR_BIT > >> > #define IGB_8_BIT_MASK UINT8_MAX > >> >+#define IGB_32_BIT_WIDTH (CHAR_BIT * 4) #define IGB_32_BIT_MASK > >> >+RTE_LEN2MASK(IGB_32_BIT_WIDTH, uint32_t) > >> > > >> > /* Additional timesync values. */ > >> > #define E1000_CYCLECOUNTER_MASK 0xffffffffffffffffULL > >> >@@ -261,11 +263,17 @@ static int igb_filter_restore(struct > >> >rte_eth_dev *dev); > >> > /* > >> > * Define VF Stats MACRO for Non "cleared on read" register > >> > */ > >> >-#define UPDATE_VF_STAT(reg, last, cur) \ > >> >-{ \ > >> >-u32 latest =3D E1000_READ_REG(hw, reg); \ > >> >-cur +=3D (latest - last) & UINT_MAX; \ > >> >-last =3D latest; \ > >> >+#define UPDATE_VF_STAT(reg, last, cur) > >> \ > >> >+{ > >> \ > >> >+uint64_t latest =3D E1000_READ_REG(hw, reg); \ > >> >+uint64_t stat =3D 0; \ > >> >+if (latest >=3D last) \ > >> >+stat =3D latest - last; \ > >> >+else \ > >> >+stat =3D (uint64_t)((latest + \ > >> >+((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\ > >> >+cur +=3D stat & IGB_32_BIT_MASK; \ > >> >+last =3D latest; \ > >> > } > >> > > >> > #define IGB_FC_PAUSE_TIME 0x0680 > >> >-- > >> >2.17.1 > >> >