From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58E63A0527 for ; Tue, 21 Jul 2020 05:31:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35A891C00F; Tue, 21 Jul 2020 05:31:30 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5036B1BFEC; Tue, 21 Jul 2020 05:31:26 +0200 (CEST) IronPort-SDR: rXrzKZXeuEMoMoIslxJnEI13AiTbS28lEjOtkf7UHSIB9O+LDahWGZQD7gK0S9yCuHZ5T07nnI QIpubMcW4y4w== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="149211173" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="149211173" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 20:31:25 -0700 IronPort-SDR: rlniUhuTf+84iktuPK4UBtHkoxB1sTrwk0slKGVC3lE2Jg7Io0wsbIj8oI9Cjh9llSO6Chs+6O tyPFMqCqo5gQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="326247203" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jul 2020 20:31:25 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jul 2020 20:31:24 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Jul 2020 20:31:24 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 20:31:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kxyUp9uGWfv28jG4TuwoDtxJZwMFNvD1RkookCY5KqF5DEgVQJTBID05eWeInD4ot/BE2EZ6MYH8aLm5mknOI4flWbGoFubQy3MNQzRK1vC9QUzz+BhE3PfTy9EkrNrAULja0Y9uB+E4P8MEnGLHTinNEDxVuVEuLwRjrzzDBTuO1oPozuvghcZEePWN5Elm2HHyVu5/D7cYdy2nm4dYYgof45DtwwFPcy7aaEbGDy7DSmvsTRsTauA2Im/X8W35CQ9i/g0KAlam4t0vrTkVLPH3qEBWUVXwnUlO6q2JpzgPq8YMp0eOq6/gBeJeVfU+AXUslxV36/OjYqdf0N1QNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DyUPYuT0a7lBIGSapK1e3Zi7RoqH3EV+woBlqTL9YNg=; b=eQzWHl5CW4hDz+tbqB6B7cgP/ngy5kp4R6oBpoulPaR1YztLk1/pC2lpJjKqazWIyfUMRzsF95m4aLpKQdZNT8P7aJ6B7asCUSO+dFpX1nEvqqe9Mr3MhoGq1UEQT5Qlrxa4WHuTwgJnC3NM63lenPowTORRLgtp9vKQ++dbTKknHZmHVc3uDYTmNB0O1yUj5npuWyka5HuZ3hwbcaUtE0eyvRwuCEAjL988JLo3KCQIupymXUNCx5KLE5OpmUgqLbysJaM46gqL9bVLjD75K/YGdNC46+iuRI7yvouOH9GS+LdgmXeitbI2ohEWNDEtD0jMEyLqGPeN/Llq9XHdRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DyUPYuT0a7lBIGSapK1e3Zi7RoqH3EV+woBlqTL9YNg=; b=fBOiQ2bB2Usk6t2hMDHZdpZUKlmN5ipwP4Oug+AK71gnodMzcVkCfMZ+wG4wuFo0zeRTnx6sJAv4nlbmzivUUD+soDOUYPTNfHg31cAaueorRU764oWoroInw9vfX77ovHVkl1XNtQsFiJo0+/wrySpqDuiZEv0EuxTfQdElzqY= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB1871.namprd11.prod.outlook.com (2603:10b6:300:111::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 03:31:21 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::f8f5:b48c:be92:ac17]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::f8f5:b48c:be92:ac17%3]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 03:31:21 +0000 From: "Zhao1, Wei" To: "Peng, ZhihongX" , "Guo, Jia" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [DPDK v3] net/e1000: add VLAN extend feature to capability Thread-Index: AQHWXwvQmFN00/Icxkqqh0h+Bt38Y6kRYHqA Date: Tue, 21 Jul 2020 03:31:21 +0000 Message-ID: References: <20200720064849.14795-1-zhihongx.peng@intel.com> <20200721030514.18947-1-zhihongx.peng@intel.com> In-Reply-To: <20200721030514.18947-1-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWI5NzRiNzUtMzgxOC00OTI0LTlmZDYtZmFkZThjYTQ4MGYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYzRLVUJ3K3JKV2g3RkRQZDQ4TXNqNUN6c0d6XC9Velh4UE52UGplT09FV1lrSE5YN3liSkIxanJzY1luRk1hTFUifQ== dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 427911bb-4f7f-4bdb-61c0-08d82d2689b7 x-ms-traffictypediagnostic: MWHPR11MB1871: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w1vDMMu7uVfTo5DAqUVhjphbC1Vj6MJP6B+NFia4lQMcB4Y8s5xW28d10w+Qk6vG4t5FURVvrF2VxHL7D60QN98Po0etq0BYBaEaP1oJro9odpvlHFekTNz7zfK/3tDh/oDwcT1UIB6Q1NjNO+PXlYeJqL9RxejRUV6/bkprUIpUl/1neMkP9wE2HHxk2b57H6yKsCeFjan1/dp8QFlFYIPcbeORUqSatO+pnx/xROCeBreL3MAXwYjKLUJPf02GOpS2is2PHLOf7sSh8FQPvAfixiUW23uPBrPkA9BP4l84Otx0slMuPJlyAOwWtV9QaITyGozyOjb/YYorefVN5g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(376002)(366004)(39860400002)(136003)(4326008)(33656002)(71200400001)(450100002)(26005)(186003)(316002)(52536014)(5660300002)(9686003)(66476007)(66556008)(8936002)(55016002)(66446008)(64756008)(8676002)(76116006)(86362001)(66946007)(2906002)(83380400001)(110136005)(6636002)(53546011)(6506007)(7696005)(54906003)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: MkjeGc6Wa4Anp8rKLSLzXDPDYzSCLQh+KILlWpt3cYDaN1+tyXMuoLgn/fo1F4/tSFspsugjH6xkkHAcyALhlYAnMR+IPLdy4cPXaiMJlZ8DhBulw99NvTYSrWKbJP84aNUysaIN2sXNe3Mj51/IWceJyYR6M3E+9iuRc3CgEpcPIwZZZGcxSas2hbWzPDGfkpw9CO8TTSNy4JZQWc5R+ZoeoxdjO4oGdSVH4PhH4Yx15IVJzevhhehs12QA1w+YwjGGjapiZ1xUHi7MIjEQDQuiYVD+DUge7PZbNchUiIQVxc10xivtB1m0YTv56qZsKQTBzv0kKjYGqItsfho66e7iD1wG02yEF4TnC7ooD5ZMI/iDj/UvTz2hx7xkvXclYieAgjwoAg+E+qw5XSSPIQ1olBDNy3Mlll9cAc6rK24HJFcz/a6g6mMcv1yDc+xcOgDdTwG8u1SGo84MxROr3fNndeppoCoi7l82/yLP0GUSz8wMBexCRvbre/eRpOMo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1391.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 427911bb-4f7f-4bdb-61c0-08d82d2689b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 03:31:21.4329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ekvsBCDLw43vd8v5EwwtAS5xXv8+gCWvnplrQ7xvZQGmuRPn1L2WkC8ey00yOQMg2Uco8k1KVwIoBqd1V1fSSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1871 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [DPDK v3] net/e1000: add VLAN extend feature to capability X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Reviewed-by: Wei Zhao > -----Original Message----- > From: Peng, ZhihongX > Sent: Tuesday, July 21, 2020 11:05 AM > To: Zhao1, Wei ; Guo, Jia > Cc: dev@dpdk.org; Peng, ZhihongX ; > stable@dpdk.org > Subject: [DPDK v3] net/e1000: add VLAN extend feature to capability >=20 > From: Peng Zhihong >=20 > The rte_eth_dev_set_vlan_offload function will check vlan rx offload capa= bility, > the i350/i210/i211 nics have vlan extend feature but > DEV_RX_OFFLOAD_VLAN_EXTEND is not set into the capability, that will caus= e > setting fail. So need to add this capability in igb_get_rx_port_offloads_= capa > function. >=20 > Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Peng Zhihong > --- > drivers/net/e1000/igb_rxtx.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c = index > 5717cdb70..6411924e0 100644 > --- a/drivers/net/e1000/igb_rxtx.c > +++ b/drivers/net/e1000/igb_rxtx.c > @@ -1637,8 +1637,10 @@ uint64_t > igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev) { > uint64_t rx_offload_capa; > + struct e1000_hw *hw; > + > + hw =3D E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private); >=20 > - RTE_SET_USED(dev); > rx_offload_capa =3D DEV_RX_OFFLOAD_VLAN_STRIP | > DEV_RX_OFFLOAD_VLAN_FILTER | > DEV_RX_OFFLOAD_IPV4_CKSUM | > @@ -1649,6 +1651,11 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev > *dev) > DEV_RX_OFFLOAD_SCATTER | > DEV_RX_OFFLOAD_RSS_HASH; >=20 > + if (hw->mac.type =3D=3D e1000_i350 || > + hw->mac.type =3D=3D e1000_i210 || > + hw->mac.type =3D=3D e1000_i211) > + rx_offload_capa |=3D DEV_RX_OFFLOAD_VLAN_EXTEND; > + > return rx_offload_capa; > } >=20 > -- > 2.17.1