From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40DDBA04A2 for ; Mon, 11 May 2020 03:03:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0AB8D1D15F; Mon, 11 May 2020 03:03:11 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DFA161C435; Mon, 11 May 2020 03:03:07 +0200 (CEST) IronPort-SDR: SF0Bt/7ba8q7u/wP0Mvggt5pc8e0TngPTEUD/kIgq7ths4z3aCSRYdEJRzAxSoNICoci01Q1kh BMebU88gjqfw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 18:03:06 -0700 IronPort-SDR: YvidF04BcD9LVbxFlSQgxBY9ngfAeGATeKI+A1dexwDUsVQo3SOEtEnQbaak6Vc8xhlZjT4Qam qU+RaysScn9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,377,1583222400"; d="scan'208";a="306033331" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by FMSMGA003.fm.intel.com with ESMTP; 10 May 2020 18:03:06 -0700 Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 18:03:05 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX126.amr.corp.intel.com (10.22.240.126) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 18:03:05 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 18:03:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZxtcnBGFXMLpoG6+E6ACMDP7V+cwYa4JmlNU2CTeU7ZoO98BYeCI64t9r2dFoXyFuAECRDqjnd/IKG5jCtBARSgsNoyb+cpNFsRkFa4gWUIrKKgzEX2yDdfFWQsDrXXwijMYx+vpo3sV+WPj6MUGQ5mvGBN1RQkJ8NWYpR5BCJZykVfpXagpbA/HCn9iIadP3uYUhmsnm2Udc7ozDCSjfhhiSnuBJ3OA2M5lgmot81J8N8EnvEVjbH/pCfDHS9dtZ59oxoE19z2s02dWui2qty22SxvEkff3NPRVeA3vuD1e/DXZj2UwduQwfBfsRRZzTz6sot3oJZZY0TGKEyDw6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mrcFNWN1M77wRCJ5psLrPP+2iXF1HBdMuiEETEtUHps=; b=W09IS10CTzxgxQ5Bkuusb4ZPEyb+PQtAYjmOVhuEiysI8MekvHMK7PpMEWZUC/68ViTohsuVFcc9SCml0DsnprOla70l1VbgTeqZnR2MQNqmmEY3A2Spxu/6DU78H+pOXA27VLRlTOM7lCAtzB/F7TAAayRUGBixmd12B75juzFaAvxs8S9sdjBVm6Ykjx1gUPojzggzwzcOu+PlGjyeK39+EDNoO/6ZINnHRPOAf8DhNXLGmYNROIX8DXhaii1X3waSzDgsiqUoeM7MwM8AVvYoGEV6tN9DwM+YK43OaDtYty2Q3m/Hxv5YoMFM6OqoU1Fc6ImQDe3sprudh6FUZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mrcFNWN1M77wRCJ5psLrPP+2iXF1HBdMuiEETEtUHps=; b=A1jhQRGkRf8VJoqKHGhxiezbE2Tb9YPeahSbbz7o63TPJiFLBOYkiPSYaweCRYW7yrXrZ3+OuAXNvb1TwYXKJ9mlREejDQjUg6x7iPEjiwKTKdEehZesGT0ZootsX3y7jlr82asL0i/XtWmD/ePqKwbgpQdSn0bu0ELS/TXUUog= Received: from MWHPR11MB1391.namprd11.prod.outlook.com (2603:10b6:300:23::15) by MWHPR11MB2064.namprd11.prod.outlook.com (2603:10b6:300:27::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Mon, 11 May 2020 01:03:03 +0000 Received: from MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211]) by MWHPR11MB1391.namprd11.prod.outlook.com ([fe80::c809:34b4:173b:d211%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 01:03:03 +0000 From: "Zhao1, Wei" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Sun, GuinanX" , "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode Thread-Index: AQHWJRV/uWzvoAGQYk6gxPEQqML3tKiff+zA Date: Mon, 11 May 2020 01:03:03 +0000 Message-ID: References: <20200508082939.32525-1-guinanx.sun@intel.com> In-Reply-To: <20200508082939.32525-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzgzZTNjYjgtZTRhNy00ODBmLWFjNDMtYTczNjgxOTgyOTgyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiblVPNTg0XC83Rmx0aWVvZmxYS3dCd0lvRVFBVW4waXFRSUhUU0FOWHRqNkppWnRWSWJWOGtkcXlneTVxZ0UrK0QifQ== dlp-version: 11.0.600.7 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96bfe2ec-8ceb-4dcb-6eae-08d7f5470ec2 x-ms-traffictypediagnostic: MWHPR11MB2064: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gzGt1DpdXkqJ1lZk5LhRabXPuFYWOg8a7yH2w6Fi56cOR2WFXz4mPYtw95/FDyLqwRr+2dHCClLLS8SAPd1HdLUpyEv3zwWgdh+enmGp+qLqFdmILp6XlRtXr0f5rbIhq3tNIw74eyVe3PgY7FdKo5b5pa3LAOmV/piLoa2F9FgXsGgQsfDArsFYyRKebGhGvhZlcxEMUIN3uWWxgpF9LLqbjiDhyd3whQ4rVFqkamcLrP0mlmCGJLaVLs5xuqXylHlKLpDHoFCt68rPNL9njuTU8pb7Wjy/e90B/v6m1z56nzsvo5k69GrNGRBtgHwjsbmqRq70HgPSezq4nBv1/04/VI7B/R/WbijWRj+DtcTKAtM41FhUtc6nF8uB/CHC4W2/hauZCfzr0mn81HaF8H9PRtT0Rj0V2zmaMPlyet054zHTZ1v7eaHjnzVdVCiFn+zDrZJjysp/VEOILyElH6mBGOS6ctrep6NO84gEDTZkE02X8Tp/9gsivfdK6vq4YPeFQxxpAHiXDLYzbjUF7A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1391.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(396003)(39860400002)(366004)(346002)(376002)(33430700001)(5660300002)(66556008)(66946007)(33440700001)(66476007)(450100002)(64756008)(71200400001)(8936002)(76116006)(66446008)(4326008)(186003)(86362001)(26005)(110136005)(2906002)(54906003)(107886003)(478600001)(33656002)(52536014)(9686003)(316002)(55016002)(53546011)(7696005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: neiqhs3oBnR54aEWizsbg89Cc5W0ccLI1l9cF8eHdpxA3cKUXgoVTP3Be/AQNp3SjYDrYdjs4WIXfsVJHq55CiTnNz62PtXWlUrE2GCNpw/AYRcRCmdUL2d5Np3lgIwMUUNAMNIsHFGIGRIbjPpK6FO/5zI183xo/DrZnCFcFVxAYgkudxtwu+HaZaUKYJX853PsKHvVebaLadl/0dCx9O5Ist0Mvqs5cwtpPNT2eycfHkXQGBGjBuoO1Ic0iyHWbcNOtrAi5QDPWoeR2NWGbpIUxqDplF9URJ1uUE4wjfPrU9nCAGmGuxppqUkRcvDSHGjRcwwA6JQu6MlMv8mcIgiM6MlCkjkOEAJdYdVP3UXmHFRe8A5YFdid9QoGmE7CGzVtUw1qkDcOV5zRC5QzKCfMncKczDJ/a2OIefg9bv7AW3EVonWX750qQkQ/TKq53UOHwn0X9yU4PpsaEX+X0rqb0cDn05JaEFkP2MmvP1o= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 96bfe2ec-8ceb-4dcb-6eae-08d7f5470ec2 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 01:03:03.4121 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EcMpwJk0lLH0e0AkjEY5yK4I6sazXtvHAi69ZtiZNcu0Z0Y8ha2wDM4PnJxr5ZdlEEOskkqxM8/DgCGhGOYOzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2064 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Guinan > -----Original Message----- > From: dev On Behalf Of Guinan Sun > Sent: Friday, May 8, 2020 4:30 PM > To: dev@dpdk.org > Cc: Sun, GuinanX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow contr= ol mode >=20 > The register autoneg can't be updated synchronously with flow control mod= e > setting in the state of port start , so NIC statistics error occurs. The = patch fixes > the issue. >=20 > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > Cc: stable@dpdk.org >=20 > Signed-off-by: Guinan Sun > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index cf5f1fe70..e6c747aef 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, > struct ixgbe_hw *hw) > int err; > uint32_t mflcn; >=20 > + hw->mac.ops.setup_fc(hw); 1. please use base code API ixgbe_setup_fc(), do not use internal function = directly. 2. please more info for this patch, what register error you want to fix, an= d why it can fix. =20 > + > err =3D ixgbe_fc_enable(hw); >=20 > /* Not negotiated is not an error case */ > -- > 2.17.1