From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D032FA04E6 for ; Tue, 17 Nov 2020 19:06:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 941425916; Tue, 17 Nov 2020 19:06:16 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A4544F90; Tue, 17 Nov 2020 19:06:11 +0100 (CET) IronPort-SDR: JdAn61UtHolQ1/xvb6AYNSpqgQhNr9wcc/KH/+slRMqrBEWVu9GjGbireyqJq+qPbwY3PPtKye OPTwGNe8+4pw== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="150249474" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="150249474" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 10:04:48 -0800 IronPort-SDR: IL5p0ZsPzo/JUcl9186QOwbopEcfhl4gFwdacB1w8HU+v9yeXbaMDarDWTHB0Zr8yCZSEnRjFL qY/1t+/JH7gQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="358993292" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 17 Nov 2020 10:04:47 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Nov 2020 10:04:46 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 17 Nov 2020 10:04:46 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 17 Nov 2020 10:04:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKoyiSXxs6RpxS4GzsnOFsXqWbsqlsZ2VezfZKXqy5FzxsZX3esaSdreiEMAdR4ObRYrevdEsOnPi40wdalLeznL/RxZBH7PUlgmc0FCMXylmZenaVkEcJuiiqPp0NjRMZ8kiLnLRSo+dECSGfkr7vYEuWlYQ6LrjKogvTe7Hnm9CcqkM3hxYnZZgCuqqVByPB3MzzjNnHU6rKEhRgnrMwGXEv6UdECPzmFpduCSrd2BM67GMM7OGNujdJEatf2V+bN9MEUqbHQnGqG5JEXh6qvC05e77oI6aATJcW6O9GZsBBzmGb48Yk7wMocPrFb+MoSfSNFhZkLyOFi02PVMSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8VMb5AzbLbuft7bq+U5udYsHcpV6jDJwnrjFxU06748=; b=P4uP3yVuzCZ50IagjJ0G8b9rTZUnCmickf2kYKzqlNF5drijDFSzXI3bB6YFt4V8E0IeyHo/EqVUQl7pdZKzJr6kj1m4tEGyWZ16LHlgTuljGCaSiKW8VmDKAZun6hqSRcQ9+momZg84Q7yj+Ko70zGdwGba+77S/BuPxM1/JFtWNyYLzJmaQiHXTxfWsRmhdGAOmKw2Kg2SWXGQS0Mu3dgEitp7610zzOWtbQ6Xahz29VSvUD6iW7OCsQ/eES3a9hV6n1zu9pfpmENi4VOFgNNutdN/3pHsd1wMYv+wSB752osKZjdilbnaR97Pp9fPyN9vm3TtcrDAgsp9t3cYAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8VMb5AzbLbuft7bq+U5udYsHcpV6jDJwnrjFxU06748=; b=D4RLvOd6+ebjPqIJF2gXeQwpBwtXeGiwIVZWt4O/4IDr+sHJZ/uoT3tmKprxTlMDPCEmJFQk60ZJzM/vHDHJER/rva34jKjP0rEqOvUh41CJrgHHSmotNcxVfeievYkHlCLAQjJl9EGoisPrrtliJl9o8XigIQTpyO8lMaT52IU= Received: from MWHPR11MB1581.namprd11.prod.outlook.com (2603:10b6:301:d::9) by MW3PR11MB4650.namprd11.prod.outlook.com (2603:10b6:303:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Tue, 17 Nov 2020 18:04:42 +0000 Received: from MWHPR11MB1581.namprd11.prod.outlook.com ([fe80::556:15d2:6ce4:d49d]) by MWHPR11MB1581.namprd11.prod.outlook.com ([fe80::556:15d2:6ce4:d49d%2]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 18:04:42 +0000 From: "Varghese, Vipin" To: "Yigit, Ferruh" , "Tahhan, Maryam" , "Pattan, Reshma" , "Mcnamara, John" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 4/4] app/procinfo: remove useless assignment Thread-Index: AQHWvQU9gkJgl65xcUCXAttHKrUKTqnMnTgQ Date: Tue, 17 Nov 2020 18:04:42 +0000 Message-ID: References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201117171435.2303641-5-ferruh.yigit@intel.com> In-Reply-To: <20201117171435.2303641-5-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.66.79.221] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48fd38f9-0291-4f0b-e0e2-08d88b23424c x-ms-traffictypediagnostic: MW3PR11MB4650: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8BY935XdYeKGmYe/pjM7kjg5+n/KDcnoS4TkHGnxk3DRUa85Q3SGW1nLWp4eT7n+UOwhelVI6IQah22Og7rbwA0YX8fO6mtNw6YZj6Iv792p1dG+CqtPcuRHggJ4p1trBcpALlbwcZhOU7+gjmBG2lR/yHVdRJfSmtq3Lj98L3/mL634Aw83fRQrY7uuCzNfo1G6Axb48kra2O/X8YaHr+jHlpyZYBKd3lQeQhOP0CBKMY44DGzSyRpOp3WNbNSJGLyuAKNt/lLT3G+XtYrnwd0AiB2y83a/4u1j2GJ+c8ZXEl/bMhSkPpGA8LKOoz8MSM73z7HvnsFeQeG6cLcGew== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1581.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(4744005)(5660300002)(2906002)(52536014)(186003)(316002)(66476007)(66446008)(64756008)(76116006)(54906003)(26005)(110136005)(6506007)(66946007)(66556008)(83380400001)(55016002)(9686003)(4326008)(450100002)(71200400001)(7696005)(8936002)(6636002)(478600001)(33656002)(8676002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: d7eQn9YjQiFMSYxcSidGH/f97sukt8Rai3+PvTWOWvkyoeZBpzoUykdisCJE+3hRw/qldJXc+tnshyYDXhOV8d6eM+n3anOGhNaNHQeUowLNmiztip2RFsTeJIjVzaeSWvpVH3z4J8o4E+a0SRpVtiUAjm86GYOk74USMyXWjxE0groWI52COI072momCjqvVr0mhVegpdlB1KU7XvS6z7gvEgFXE7TipVBwA9J7NdrNwbnBHrgma0bHHbmAb4fn3Xqaa/GW0gg705/2tAlpfXutSOfe88YzYeZnc5o5ZSS5nZUeGgGQzQI7XnwEgsLTQhwwiSoNKBxEeeNSOB+u8pMTBgAwaKciqbYRRC8VNF0e6w4F6+YZIpXfumizo9f5wy4pJvTBo+PWTCyvnYmV5+9BjljiThcbnRXyjx/++7YogWIMnlJiKEA28yynTNlk2QEtJcsPP7k5ojurvD9hJZFEjux1smxxLq5RKxUX5KWbgjTqe1JbPnEIa5assgPq06TewTuNp1+i8Hd87/EV6BUTV0+oE7Qm6aS5DfvKLqc/mKZH9XNP44/91jWzpGQym+tA9TErZI2+kBJIp9hJ/c2aR1nNQfDFwOQP5YQpcv372SZbCTfACnTuojx5Uy+3xYNvKqaU8kFtbxyaN3ROsA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1581.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48fd38f9-0291-4f0b-e0e2-08d88b23424c X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 18:04:42.3096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e+zG4VJYqLXR5HNGl+X7JLJa2ReUqvHevzS6Gq7Kg+p36XQ1uyP5dGZSIcB6XsajHJKpt7B5faZlLJIOvzx+BtBB6xU7OJgSUCTIgOnelhA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4650 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH 4/4] app/procinfo: remove useless assignment X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Ferruh, Thanks for the update snipped > show_mempool(char *name) { > - uint64_t flags =3D 0; > + uint64_t flags; >=20 Checking the current code base it makes more sense to move the code inside = `if` condition check. Sample code shared below ``` - uint64_t flags =3D 0; snprintf(bdr_str, MAX_STRING_LEN, " show - MEMPOOL "); STATS_BDR_STR(10, bdr_str); if (name !=3D NULL) { struct rte_mempool *ptr =3D rte_mempool_lookup(name); if (ptr !=3D NULL) { struct rte_mempool_ops *ops; + unsigned int flags =3D ptr->flags; ops =3D rte_mempool_get_ops(ptr->ops_index); ``` But it is ok