patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Ankur Dwivedi <adwivedi@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-stable] [PATCH] test/event_crypto_adapter: set cipher operation in transform
Date: Mon, 18 Jan 2021 12:10:47 +0000
Message-ID: <MWHPR11MB1838D1A25950B0F81A098CD9E8A40@MWHPR11MB1838.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM5PR1801MB1884BAFD413B7CBF1D247496DDA41@DM5PR1801MB1884.namprd18.prod.outlook.com>

Hi Ankur,

> -----Original Message-----
> From: Ankur Dwivedi <adwivedi@marvell.com>
> Sent: Monday, January 18, 2021 5:04 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; akhil.goyal@nxp.com; Anoob Joseph
> <anoobj@marvell.com>
> Subject: RE: [PATCH] test/event_crypto_adapter: set cipher operation in
> transform
> 
> Hi Abhinandan,
> 
> >-----Original Message-----
> >From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> >Sent: Monday, January 18, 2021 2:42 PM
> >To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
> >Cc: stable@dpdk.org; akhil.goyal@nxp.com; Anoob Joseph
> ><anoobj@marvell.com>
> >Subject: [EXT] RE: [PATCH] test/event_crypto_adapter: set cipher
> >operation in transform
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Hi Ankur,
> >
> >> -----Original Message-----
> >> From: Ankur Dwivedi <adwivedi@marvell.com>
> >> Sent: Friday, January 8, 2021 2:11 PM
> >> To: dev@dpdk.org
> >> Cc: stable@dpdk.org; Gujjar, Abhinandan S
> >> <abhinandan.gujjar@intel.com>; akhil.goyal@nxp.com;
> >> anoobj@marvell.com; Ankur Dwivedi <adwivedi@marvell.com>
> >> Subject: [PATCH] test/event_crypto_adapter: set cipher operation in
> >> transform
> >>
> >> The cipher operation in the transform should be set to encrypt.
> >>
> >> Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration")
> >>
> >> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> >> ---
> >>  app/test/test_event_crypto_adapter.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/app/test/test_event_crypto_adapter.c
> >> b/app/test/test_event_crypto_adapter.c
> >> index a0169aa6cf..335211cd8c 100644
> >> --- a/app/test/test_event_crypto_adapter.c
> >> +++ b/app/test/test_event_crypto_adapter.c
> >> @@ -183,6 +183,7 @@ test_op_forward_mode(uint8_t session_less)
> >>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> >>  	cipher_xform.next = NULL;
> >>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> >> +	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >NULL PMD does not refer " RTE_CRYPTO_CIPHER_OP_ENCRYPT ". Is your test
> >code failing without this change?
> [Ankur] Yes the test is failing, because in octeontx2 crypto pmd, during crypto
> session configure there is a check for the cipher xform op. If the op does not
> match either encrypt or decrypt, the session configure fails.
[Abhinandan] Ok. I have not come across such issue on my system.
Could you please add more details into the commit message of the patch and send?
> >>
> >>  	op = rte_crypto_op_alloc(params.op_mpool,
> >>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> >> @@ -382,6 +383,7 @@ test_op_new_mode(uint8_t session_less)
> >>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> >>  	cipher_xform.next = NULL;
> >>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> >> +	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >>
> >>  	op = rte_crypto_op_alloc(params.op_mpool,
> >>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> >> --
> >> 2.28.0


  reply	other threads:[~2021-01-18 12:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  8:40 Ankur Dwivedi
2021-01-12  4:55 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2021-01-18  9:11 ` [dpdk-stable] " Gujjar, Abhinandan S
2021-01-18 11:33   ` Ankur Dwivedi
2021-01-18 12:10     ` Gujjar, Abhinandan S [this message]
2021-01-18 14:54       ` Ankur Dwivedi
2021-01-18 16:19 ` [dpdk-stable] [PATCH v2] " Ankur Dwivedi
2021-01-19  7:13   ` Gujjar, Abhinandan S
2021-01-26 19:32     ` [dpdk-stable] [dpdk-dev] " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1838D1A25950B0F81A098CD9E8A40@MWHPR11MB1838.namprd11.prod.outlook.com \
    --to=abhinandan.gujjar@intel.com \
    --cc=adwivedi@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git