patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
	Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Xueming(Steven) Li" <xuemingl@nvidia.com>,
	 Asaf Penso <asafp@nvidia.com>, Bing Zhao <bingz@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix unix socket server file name
Date: Fri, 13 Nov 2020 14:57:18 +0000
Message-ID: <MWHPR12MB150107021AE3BA138D228265DFE60@MWHPR12MB1501.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1604392123-8397-1-git-send-email-xuemingl@nvidia.com>

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Tuesday, November 3, 2020 10:29
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Asaf Penso
> <asafp@nvidia.com>; Bing Zhao <bingz@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix unix socket server file name
> 
> mlx_steering_dump_parser.py tool failed to dump flow due to socket file name
> changed.
> 
> Change socket file name back to make it consistent.
> 
> Fixes: b1e15224849b ("common/mlx5: fix PCI driver name")
> Cc: bingz@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

> ---
>  drivers/net/mlx5/linux/mlx5_socket.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/mlx5/linux/mlx5_socket.c
> b/drivers/net/mlx5/linux/mlx5_socket.c
> index 08af905126..1938453980 100644
> --- a/drivers/net/mlx5/linux/mlx5_socket.c
> +++ b/drivers/net/mlx5/linux/mlx5_socket.c
> @@ -20,16 +20,11 @@
> 
>  /* PMD socket service for tools. */
> 
> +#define MLX5_SOCKET_PATH "/var/tmp/dpdk_net_mlx5_%d"
> +
>  int server_socket; /* Unix socket for primary process. */  struct
> rte_intr_handle server_intr_handle; /* Interrupt handler. */
> 
> -static void
> -mlx5_pmd_make_path(struct sockaddr_un *addr, int pid) -{
> -	snprintf(addr->sun_path, sizeof(addr->sun_path),
> "/var/tmp/dpdk_%s_%d",
> -		 MLX5_DRIVER_NAME, pid);
> -}
> -
>  /**
>   * Handle server pmd socket interrupts.
>   */
> @@ -186,7 +181,8 @@ mlx5_pmd_socket_init(void)
>  	ret = fcntl(server_socket, F_SETFL, flags | O_NONBLOCK);
>  	if (ret < 0)
>  		goto error;
> -	mlx5_pmd_make_path(&sun, getpid());
> +	snprintf(sun.sun_path, sizeof(sun.sun_path), MLX5_SOCKET_PATH,
> +		 getpid());
>  	remove(sun.sun_path);
>  	ret = bind(server_socket, (const struct sockaddr *)&sun, sizeof(sun));
>  	if (ret < 0) {
> @@ -225,6 +221,6 @@ RTE_FINI(mlx5_pmd_socket_uninit)
>  	mlx5_pmd_interrupt_handler_uninstall();
>  	claim_zero(close(server_socket));
>  	server_socket = 0;
> -	MKSTR(path, "/var/tmp/dpdk_%s_%d", MLX5_DRIVER_NAME,
> getpid());
> +	MKSTR(path, MLX5_SOCKET_PATH, getpid());
>  	claim_zero(remove(path));
>  }
> --
> 2.25.1


  reply	other threads:[~2020-11-13 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03  8:28 Xueming Li
2020-11-13 14:57 ` Slava Ovsiienko [this message]
2020-11-13 19:17   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR12MB150107021AE3BA138D228265DFE60@MWHPR12MB1501.namprd12.prod.outlook.com \
    --to=viacheslavo@nvidia.com \
    --cc=asafp@nvidia.com \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git